Throw an error if --local-engine-host is used without --local-engine by jason-simmons · Pull Request #166948 · flutter/flutter

jason-simmons · 2025-04-10T21:42:34Z

The artifact selector will only use artifacts from the local engine if both of these flags are provided.

bkonyi

LGTM w/ one comment

bkonyi · 2025-04-10T23:35:13Z

packages/flutter_tools/lib/src/runner/local_engine.dart

    String? packagePath,
  }) async {
+    if (localHostEngine != null && localEngine == null) {
+      throwToolExit(_userMessages.runnerHostEngineRequiresLocalEngine, exitCode: 2);


Why exit code 2? Is there a constant for this somewhere if it means something special? At the very least, let's define a local constant with a meaningful name.

This was done for consistency - all other calls to throwToolExit in this file use exit code 2.

Most other throwToolExit calls in flutter_tools also use exit code 2 (although there are a few places that use other exit codes).

I don't know the history of why the tool uses that number, and there is no constant defined for this. It would be helpful to make this more consistent throughout the tool, but that's out of scope for this PR.

The artifact selector will only use artifacts from the local engine if both of these flags are provided.

…-engine (flutter/flutter#166948)

flutter/flutter@ecabb1a...3ed38e2 2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380) 2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228) 2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346) 2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…-engine (flutter/flutter#166948)

…lutter#166948) The artifact selector will only use artifacts from the local engine if both of these flags are provided.

…-engine (flutter/flutter#166948)

jason-simmons requested a review from bkonyi April 10, 2025 21:42

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 10, 2025

bkonyi approved these changes Apr 10, 2025

View reviewed changes

jason-simmons added 2 commits April 15, 2025 18:10

Throw an error if --local-engine-host is used without --local-engine

2b1148d

The artifact selector will only use artifacts from the local engine if both of these flags are provided.

format

a802f03

jason-simmons force-pushed the tool_local_engine_host_warn branch from 4ffb266 to a802f03 Compare April 15, 2025 18:10

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2025

auto-submit bot added this pull request to the merge queue Apr 17, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 18, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

auto-submit bot added this pull request to the merge queue Apr 18, 2025

Merged via the queue into flutter:master with commit ab7a990 Apr 18, 2025
142 of 143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) flutter/packages#9114

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

ab7a990 Throw an error if --local-engine-host is used without --local…

a1fb15e

…-engine (flutter/flutter#166948)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

ab7a990 Throw an error if --local-engine-host is used without --local…

b0aae92

…-engine (flutter/flutter#166948)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

ab7a990 Throw an error if --local-engine-host is used without --local…

a8e2d03

…-engine (flutter/flutter#166948)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

ab7a990 Throw an error if --local-engine-host is used without --local…

dd0d82a

…-engine (flutter/flutter#166948)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

ab7a990 Throw an error if --local-engine-host is used without --local…

24ea8dd

…-engine (flutter/flutter#166948)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

ab7a990 Throw an error if --local-engine-host is used without --local…

1651b8e

…-engine (flutter/flutter#166948)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw an error if --local-engine-host is used without --local-engine#166948

Throw an error if --local-engine-host is used without --local-engine#166948
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jason-simmons:tool_local_engine_host_warn

jason-simmons commented Apr 10, 2025

Uh oh!

bkonyi left a comment

Uh oh!

bkonyi Apr 10, 2025

Uh oh!

jason-simmons Apr 11, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jason-simmons commented Apr 10, 2025

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

bkonyi Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

jason-simmons Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants