feat(RadioListTile):ensure that 'isThreeLine' can be configured through the by StanleyCocos · Pull Request #166964 · flutter/flutter

StanleyCocos · 2025-04-11T06:01:40Z

This PR is a continuation of 165481

Related items also include: SwitchListTile, CheckboxListTile

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

…ugh the

dkwingsmt

LGTM

justinmc

LGTM with nits 👍

justinmc · 2025-04-24T18:43:10Z

packages/flutter/lib/src/material/radio_list_tile.dart

+  /// If null, the value from [ListTileThemeData.isThreeLine] is used.
+  /// If that is also null, the value from the [ListTileThemeData] returned by [ThemeData.listTileTheme] is used.
+  /// If still null, the default value is `false`.


Same comment from the other PR about this being more than 80 characters.

Updated, thank you.

justinmc · 2025-04-24T18:43:35Z

packages/flutter/test/material/radio_list_tile_test.dart

+
+    Widget buildFrame({bool? themeDataIsThreeLine, bool? themeIsThreeLine, bool? isThreeLine}) {
+      return MaterialApp(
+        key: UniqueKey(),


And same comment about a possibly unnecessary UniqueKey here.

Similarly。
I believe this key is useful. Since the same widget tree is called multiple times below with slight modifications, a unique key is needed here to prevent reuse-related errors.

StanleyCocos · 2025-04-28T01:50:38Z

@justinmc @dkwingsmt
Would you mind taking another look?
Thank you.

…hrough the theme. (#166826) This PR is a continuation of [165481](#165481) Related items also include: [SwitchListTile](#166820), [RadioListTile](#166964) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

StanleyCocos · 2025-05-06T01:04:55Z

@dkwingsmt
Thank you. It should now be ready for merging.
Once this request is merged, I will proceed to adjust the other one.

…ough the theme. (#166820) This PR is a continuation of [165481](#165481) Related items also include: [RadioListTile](#166964), [CheckboxListTile](#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…ed through the (flutter/flutter#166964)

…gh the (flutter#166964) This PR is a continuation of [165481](flutter#165481) Related items also include: [SwitchListTile](flutter#166820), [CheckboxListTile](flutter#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]>

…ough the theme. (flutter#166820) This PR is a continuation of [165481](flutter#165481) Related items also include: [RadioListTile](flutter#166964), [CheckboxListTile](flutter#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…ed through the (flutter/flutter#166964)

Roll Flutter from cfb887c to b0f5c8c (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619) 2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...

…ed through the (flutter/flutter#166964)

…hrough the theme. (flutter#166826) This PR is a continuation of [165481](flutter#165481) Related items also include: [SwitchListTile](flutter#166820), [RadioListTile](flutter#166964) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…ed through the (flutter/flutter#166964)

feat(RadioListTile): ensure that 'isThreeLine' can be configured thro…

7a4f950

…ugh the

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 11, 2025

StanleyCocos marked this pull request as ready for review April 11, 2025 07:12

This was referenced Apr 18, 2025

feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. #166820

Merged

feat(CheckboxListTile): ensure that 'isThreeLine' can be configured through the theme. #166826

Merged

dkwingsmt self-requested a review April 23, 2025 18:18

dkwingsmt approved these changes Apr 23, 2025

View reviewed changes

justinmc approved these changes Apr 24, 2025

View reviewed changes

++

695df36

StanleyCocos and others added 2 commits May 1, 2025 22:45

Merge branch 'master' into feature/radio_list_tile

d375b85

Analyze

7950218

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025

auto-submit bot added this pull request to the merge queue May 6, 2025

Merged via the queue into flutter:master with commit dfd0a3c May 6, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025

engine-flutter-autoroll mentioned this pull request May 6, 2025

Roll Flutter from cfb887cd5f41 to a3a41226e5af (259 revisions) flutter/packages#9214

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

e5a20be

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 6, 2025

Roll Flutter from cfb887cd5f41 to a3a41226e5af (259 revisions) flutter/packages#9216

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

2724239

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 6, 2025

Roll Flutter from cfb887cd5f41 to 862ce5a986f2 (260 revisions) flutter/packages#9217

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

c8e1199

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 6, 2025

Roll Flutter from cfb887cd5f41 to 397d3e118554 (261 revisions) flutter/packages#9218

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

4b5c2d9

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to 3a71fefdcaf1 (278 revisions) flutter/packages#9220

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

902e4b2

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to a3e9379a87ea (279 revisions) flutter/packages#9221

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

7b8f998

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to 708c0eb18555 (280 revisions) flutter/packages#9222

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

7a9ad4e

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/packages#9223

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

773a57d

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to f9fb8906c7fb (282 revisions) flutter/packages#9224

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

d25126e

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to b3f6925fda4f (283 revisions) flutter/packages#9225

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

9df5b55

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to 9d8e5e0b2f0d (284 revisions) flutter/packages#9226

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

558c534

…ed through the (flutter/flutter#166964)

StanleyCocos deleted the feature/radio_list_tile branch May 8, 2025 01:45

Piinks mentioned this pull request May 9, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

45c57f0

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

dc039d1

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

c87271a

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

961dccc

…ed through the (flutter/flutter#166964)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

dfd0a3c feat(RadioListTile):ensure that 'isThreeLine' can be configur…

0b89a0e

…ed through the (flutter/flutter#166964)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(RadioListTile):ensure that 'isThreeLine' can be configured through the#166964

feat(RadioListTile):ensure that 'isThreeLine' can be configured through the#166964
auto-submit[bot] merged 4 commits intoflutter:masterfrom
StanleyCocos:feature/radio_list_tile

StanleyCocos commented Apr 11, 2025 •

edited

Loading

Uh oh!

dkwingsmt left a comment

Uh oh!

justinmc left a comment

Uh oh!

justinmc Apr 24, 2025

Uh oh!

StanleyCocos Apr 25, 2025

Uh oh!

justinmc Apr 24, 2025

Uh oh!

StanleyCocos Apr 25, 2025

Uh oh!

StanleyCocos commented Apr 28, 2025

Uh oh!

StanleyCocos commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

StanleyCocos commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos commented Apr 28, 2025

Uh oh!

StanleyCocos commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StanleyCocos commented Apr 11, 2025 •

edited

Loading