Improve documentation for KeyedSubtree constructor by dogaozyagci · Pull Request #167198 · flutter/flutter

dogaozyagci · 2025-04-15T15:52:00Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2025-04-15T15:52:03Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

dogaozyagci · 2025-04-15T15:53:03Z

Description

Improved the documentation for the KeyedSubtree constructor to clarify its purpose and usage.

Checklist

Documentation updated for clarity.
All changes are non-functional.
Follows Flutter documentation style guidelines.

justinmc

LGTM 👍

But it looks like you accidentally also included this docs change in your other PR! #167200

justinmc · 2025-04-22T22:16:21Z

Looks like Linux customer_testing is also failing here. The error seems unrelated, something about docs charts from devtools. I treid rerunning. If that doesn't work, can you rebase your PR with master and see if that has an effect? Thanks.

Piinks

LGTM

…lutter#167198)

flutter/flutter@336a7ec...0b9f928 2025-05-14 [email protected] Fix Linux Impeller support broken by incorrect deletion of stencil buffer. (flutter/flutter#168668) 2025-05-14 [email protected] Roll Fuchsia Linux SDK from 6J81agNhuK4q255Jj... to fSvuEJgRmHxnewRJr... (flutter/flutter#168794) 2025-05-14 [email protected] Run `{Platform} flutter_packaging` builders on release candidates. (flutter/flutter#168762) 2025-05-14 [email protected] Remove `docs_deploy_beta`, fix `docs_publish`, add comments. (flutter/flutter#168754) 2025-05-14 [email protected] Add `titleAlignment` to `CheckboxListTile` and `RadioListTile` (flutter/flutter#168666) 2025-05-14 [email protected] Remove deprecated todo about caching (flutter/flutter#168534) 2025-05-13 [email protected] Replace hardcoded host and app level build.gradle paths with `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949) 2025-05-13 [email protected] Improve documentation for KeyedSubtree constructor (flutter/flutter#167198) 2025-05-13 [email protected] Wire up the system text scaler from `PlatformDispatcher` (flutter/flutter#159999) 2025-05-13 [email protected] Roll Dart SDK from 645d04a7a964 to b3520981e0f0 (3 revisions) (flutter/flutter#168721) 2025-05-13 [email protected] [a11y] Semanctis flag refactor step 3: framework part (flutter/flutter#167771) 2025-05-13 [email protected] Remove/replace the `team` label with `c: contributor-productivity`. (flutter/flutter#168702) 2025-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions (#168510)" (flutter/flutter#168775) 2025-05-13 [email protected] Use live region in error text input decorator for Android (flutter/flutter#165531) 2025-05-13 [email protected] [tool] Fix deprecated API calls within tool (flutter/flutter#168200) 2025-05-13 [email protected] Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions (flutter/flutter#168510) 2025-05-13 [email protected] Fixes hero not shown when remove pages without animation (flutter/flutter#168617) 2025-05-13 [email protected] [iOS] Do not hide selection handles when platform hides system context menu (flutter/flutter#168678) 2025-05-13 [email protected] Updated execution path to silently include --start-paused and updated tests (flutter/flutter#168400) 2025-05-13 [email protected] Roll Packages from 6a28ad9 to 2e166de (2 revisions) (flutter/flutter#168736) 2025-05-13 [email protected] [web] Fix multiline input selection in Chrome. (flutter/flutter#168217) 2025-05-13 [email protected] Call xcode_backend.dart from macos_assemble.sh (flutter/flutter#168108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#167198)

Improve documentation for KeyedSubtree constructor

fc69240

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 15, 2025

justinmc approved these changes Apr 22, 2025

View reviewed changes

Piinks mentioned this pull request Apr 30, 2025

Clarify deprecation notice for jumpToWithoutSettling in scroll_position.dart #167200

Merged

3 tasks

Merge branch 'master' into improve-keyedsubtree-doc

fe46f32

Piinks approved these changes May 13, 2025

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2025

auto-submit bot added this pull request to the merge queue May 13, 2025

Merged via the queue into flutter:master with commit 5a48ed0 May 14, 2025
75 of 76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2025

5a48ed0 Improve documentation for KeyedSubtree constructor (flutter/f…

be66892

…lutter#167198)

engine-flutter-autoroll mentioned this pull request May 14, 2025

Roll Flutter from 336a7ecf7b40 to 0b9f9288caf3 (22 revisions) flutter/packages#9251

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

5a48ed0 Improve documentation for KeyedSubtree constructor (flutter/f…

b8940ff

…lutter#167198)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

5a48ed0 Improve documentation for KeyedSubtree constructor (flutter/f…

18458d7

…lutter#167198)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

5a48ed0 Improve documentation for KeyedSubtree constructor (flutter/f…

b1698bb

…lutter#167198)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

5a48ed0 Improve documentation for KeyedSubtree constructor (flutter/f…

a524a41

…lutter#167198)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

5a48ed0 Improve documentation for KeyedSubtree constructor (flutter/f…

452db90

…lutter#167198)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve documentation for KeyedSubtree constructor#167198

Improve documentation for KeyedSubtree constructor#167198
auto-submit[bot] merged 2 commits intoflutter:masterfrom
dogaozyagci:improve-keyedsubtree-doc

dogaozyagci commented Apr 15, 2025 •

edited

Loading

Uh oh!

google-cla bot commented Apr 15, 2025

Uh oh!

dogaozyagci commented Apr 15, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc commented Apr 22, 2025

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dogaozyagci commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Apr 15, 2025

Uh oh!

dogaozyagci commented Apr 15, 2025

Description

Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Apr 22, 2025

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dogaozyagci commented Apr 15, 2025 •

edited

Loading