Skip to content

Remove Robolectric.setupActivity from engine junit tests#167607

Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom
mboetger:setupActivity-133151
Apr 24, 2025
Merged

Remove Robolectric.setupActivity from engine junit tests#167607
auto-submit[bot] merged 4 commits intoflutter:masterfrom
mboetger:setupActivity-133151

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Apr 22, 2025

Remove the deprecated Robolectric.setupActivity from the engine junit tests. This replaces it with the ActivityScenario.

Activity Scenario documentation
https://developer.android.com/reference/androidx/test/core/app/ActivityScenario
Extension function that sets up and shuts down an activity before and after each test.
https://developer.android.com/reference/androidx/test/ext/junit/rules/ActivityScenarioRule

Fixes #133151

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@mboetger mboetger requested review from gmackall and reidbaker April 22, 2025 23:27
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Apr 22, 2025
@mboetger mboetger force-pushed the setupActivity-133151 branch from ccb1ded to c87cea7 Compare April 22, 2025 23:31
@mboetger mboetger changed the base branch from main to master April 22, 2025 23:34
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 23, 2025

autosubmit label was removed for flutter/flutter/167607, because - The status or check suite Linux android_java17_dependency_smoke_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

gmackall
gmackall approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 23, 2025

autosubmit label was removed for flutter/flutter/167607, because - The status or check suite Linux gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 24, 2025
Merged via the queue into flutter:master with commit 3438da3 Apr 24, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
f8093c5 
…tter/flutter#167607)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
992c6c5 
…tter/flutter#167607)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
a65ad18 
…tter/flutter#167607)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
2b1f797 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
4792bb6 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
43edefa 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
100fced 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
1c9ba01 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
2b71eb4 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
bcd2be6 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
a0b584b 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
3ef3315 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
e62163c 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
dcfe3b9 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
fb6db01 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
e6d1423 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
7ae3af5 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
b3b7fc5 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
29203a0 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
7fcdd73 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
5331a5b 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
95cb79b 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
0694cb8 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
f6974d8 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
c6a2d75 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
9381efd 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
5611b6d 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
d2cc47d 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
4eb1108 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
f24e2ac 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
9362f33 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
efcb945 
…tter/flutter#167607)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
3438da3 Remove Robolectric.setupActivity from engine junit tests (flu…
e7f3d29 
…tter/flutter#167607)
@AbdeMohlbi AbdeMohlbi mentioned this pull request Nov 15, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Engine java unit tests should migrate from Robolectric.setupActivity to activity scenario

2 participants

@mboetger @gmackall