Skip to content

Update Tree-hygiene.md#167699

Merged
matanlurey merged 1 commit intomasterfrom
matanlurey-patch-5
Apr 24, 2025
Merged

Update Tree-hygiene.md#167699
matanlurey merged 1 commit intomasterfrom
matanlurey-patch-5

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Apr 24, 2025

Closes #167688.

Feel free to suggest other minor changes, or we can make more changes after, either/or.

@matanlurey matanlurey requested a review from Piinks April 24, 2025 02:45
@github-actions github-actions bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Apr 24, 2025
@yakagami
Copy link
Contributor

yakagami commented Apr 24, 2025

As the opener of #167688 this LGTM

Piinks
Piinks approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/contributing/Tree-hygiene.md

### Squashing commits

When you squash commits, by default, GitHub will concatenate all your commit messages to form a unified commit message. This often yields an overly verbose commit message with many unhelpful entries (e.g. "fix typo"). Please double-check (and hand-edit if necessary) your commit message before merging such that the message contains a helpful description of the overall change.
Copy link
Contributor

@Piinks Piinks Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah this is funny, I thought the PR description ends up being the commit message.

@matanlurey matanlurey added this pull request to the merge queue Apr 24, 2025
Merged via the queue into master with commit 974bd72 Apr 24, 2025
43 checks passed
@matanlurey matanlurey deleted the matanlurey-patch-5 branch April 24, 2025 17:24
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
8227a97
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
da6c7fb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
4845706
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
ac84a12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
9d8b95b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
3984573
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
bbbe43e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
0cc1dd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
9c8c8a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
fcecaf7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
84c7b0c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
2a89bcf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
1e4fed5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
b0a4d5b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
faa64b9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
acc7aa4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
d06174e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
ef83dc2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
2f80f23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
5975f91
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
811696c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
78a6982
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
7b08838
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
3173de3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
600ff6c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
cdac8e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
f2d469c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
27a6bed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
9ff268d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
b5c77e5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
85d22e8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
094e53f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
8a4b5e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
9e259c8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
894998d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
c1edcf1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
c6e9075
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
0b51d86
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
974bd72 Update Tree-hygiene.md (flutter/flutter#167699)
de80593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs] Consider updating "squahing commits" section in Tree-hygiene.md

3 participants

@matanlurey @yakagami @Piinks