[Android 16] Updating Engine to Use Java 21#167776
Closed
jesswrd wants to merge 5 commits intoflutter:masterfrom
Closed
[Android 16] Updating Engine to Use Java 21#167776jesswrd wants to merge 5 commits intoflutter:masterfrom
jesswrd wants to merge 5 commits intoflutter:masterfrom
Conversation
…instead of mock to test.
11 tasks
25 tasks
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 26, 2025
Bumping AVD, SDK we test against to ensure Flutter works on Android 16. Also added potentially missing `android_virtual_device` dependency. This aligns with what has been and/or will be done in framework flutter/flutter#169121 and engine flutter/flutter#169124, flutter/flutter#167776. Partially Addresses flutter/flutter#163071 Fixes flutter/flutter#137083 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Bumping AVD, SDK we test against to ensure Flutter works on Android 16. Also added potentially missing `android_virtual_device` dependency. This aligns with what has been and/or will be done in framework flutter/flutter#169121 and engine flutter/flutter#169124, flutter/flutter#167776. Partially Addresses flutter/flutter#163071 Fixes flutter/flutter#137083 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Contributor
|
Hey @jesswrd, greetings from stale PR triage! 👋 Is this one still on your radar? |
Contributor
Author
nope closing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping the engine to use Java 21.
Some Java 21 changes that affect our tests:
mockto fake theByteBufferclass (mockito issue here). I replaced the usage with a captor instead.AccessiblityBridgeTest.java, which uses chinese characters.To reproduce the error in AccessiblityBridgeTest.java locally, follow these steps:
et build -c android_debug_unoptgclient sync -Dfrom rootengine/src/flutter/third_party/java/openjdk/openjdk.cipd.yamlto make sure JDK 21 has been properly generated. If you see "OpenJDK 21," it has been properly generated.engine/src/flutterand runtesting/run_tests.py --android-variant=android_debug_unopt --type=java --java-filter=io.flutter.view.AccessibilityBridgeTestPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.