Add option to hide trailing icon in DropdownMenu by mohamedamara · Pull Request #167782 · flutter/flutter

mohamedamara · 2025-04-24T22:51:47Z

This PR adds support for hiding the trailing icon in DropdownMenu widget. Currently, there's no built-in option to remove it.

The change is non-breaking, as the trailing icon remains visible by default unless showTrailingIcon is explicitly set to false. The showTrailingIcon parameter follows a similar pattern to its use in the ExpansionTile widget.

Fixes #164908

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

QuncCccccc

Thank for your contribution! Overall this looks good! Just left a few nits and then I'll look for a second reviewer:)

packages/flutter/lib/src/material/dropdown_menu.dart

QuncCccccc · 2025-05-07T16:58:13Z

packages/flutter/lib/src/material/dropdown_menu.dart


+  /// Specifies if the [DropdownMenu] should show a [trailingIcon].
+  ///
+  /// Defaults to true.


nit: we can move this line to the last line for consistency.

QuncCccccc · 2025-05-07T17:01:14Z

packages/flutter/test/material/dropdown_menu_test.dart

+      final ThemeData themeData = ThemeData();
+      await tester.pumpWidget(
+        MaterialApp(
+          theme: themeData,


nit: we can remove this line and line 4265 for simplicity:)

QuncCccccc · 2025-05-07T17:01:49Z

packages/flutter/test/material/dropdown_menu_test.dart

+      final ThemeData themeData = ThemeData();
+      await tester.pumpWidget(
+        MaterialApp(
+          theme: themeData,


nit: seems themeData is not used anywhere, so we can remove this line and line 4243

QuncCccccc

LGTM. Thanks for your contribution:)

MitchellGoodwin

LGTM! Thank you for the PR!

QuncCccccc · 2025-05-07T23:25:45Z

Not sure why Google testing hasn't been triggered. But this change looks safe to roll into g3.

…tter#167782)

flutter/flutter@b0f5c8c...02d8c1a 2025-05-08 [email protected] iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517) 2025-05-08 [email protected] Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548) 2025-05-08 [email protected] Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345) 2025-05-08 [email protected] Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526) 2025-05-08 [email protected] Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525) 2025-05-08 [email protected] Make MergeSemantics be able to merge customAction (flutter/flutter#168414) 2025-05-08 [email protected] Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514) 2025-05-08 [email protected] Roll pub packages (flutter/flutter#168509) 2025-05-07 [email protected] Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114) 2025-05-07 [email protected] Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782) 2025-05-07 [email protected] Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505) 2025-05-07 [email protected] [web] drop more use of deprecated JS functions (flutter/flutter#166157) 2025-05-07 [email protected] docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191) 2025-05-07 [email protected] Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489) 2025-05-07 [email protected] Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433) 2025-05-07 [email protected] Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479) 2025-05-07 [email protected] Fix stencil buffer leak (flutter/flutter#168448) 2025-05-07 [email protected] Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447) 2025-05-07 [email protected] Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#167782)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 24, 2025

mohamedamara force-pushed the fix_164908_add_option_to_hide_trailing_icon branch 6 times, most recently from 75d4a08 to 09f3e35 Compare April 26, 2025 20:08

dkwingsmt requested a review from QuncCccccc April 30, 2025 18:23

mohamedamara force-pushed the fix_164908_add_option_to_hide_trailing_icon branch from 09f3e35 to fbbf744 Compare May 1, 2025 18:34

QuncCccccc reviewed May 7, 2025

View reviewed changes

mohamedamara added 7 commits May 7, 2025 22:32

add option to hide trailing icon in DropdownMenu

2628fc1

remove trailing spaces

50e01ef

change formatting

7a3af25

remove trailing space from dropdown_menu_test file

0c2cab4

change doc comment

17fd33a

reorder doc comment

a776c78

remove unused themeData from dropdown_menu_test file

c4a81d1

mohamedamara force-pushed the fix_164908_add_option_to_hide_trailing_icon branch from fbbf744 to c4a81d1 Compare May 7, 2025 21:32

Update packages/flutter/lib/src/material/dropdown_menu.dart

4596912

QuncCccccc approved these changes May 7, 2025

View reviewed changes

MitchellGoodwin approved these changes May 7, 2025

View reviewed changes

Merge branch 'master' into fix_164908_add_option_to_hide_trailing_icon

ebb6def

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025

auto-submit bot added this pull request to the merge queue May 7, 2025

Merged via the queue into flutter:master with commit 930d215 May 8, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2025

engine-flutter-autoroll mentioned this pull request May 8, 2025

Roll Flutter from b0f5c8ce03e2 to 76747c0ecef6 (17 revisions) flutter/packages#9228

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

ff20528

…tter#167782)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

9ba2993

…tter#167782)

engine-flutter-autoroll mentioned this pull request May 8, 2025

Roll Flutter from b0f5c8ce03e2 to 041bbeb88237 (18 revisions) flutter/packages#9229

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

67ddd11

…tter#167782)

engine-flutter-autoroll mentioned this pull request May 8, 2025

Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) flutter/packages#9230

Merged

Piinks mentioned this pull request May 9, 2025

Flutter Notable Commits - 2025 #161460

Closed

mohamedamara deleted the fix_164908_add_option_to_hide_trailing_icon branch May 11, 2025 17:51

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

9e84458

…tter#167782)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

06977c1

…tter#167782)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

ec5809d

…tter#167782)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

23f1573

…tter#167782)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

930d215 Add option to hide trailing icon in DropdownMenu (flutter/flu…

81757b5

…tter#167782)

bleroux mentioned this pull request Oct 16, 2025

Add DropdownMenu.decorationBuilder #176264

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to hide trailing icon in DropdownMenu#167782

Add option to hide trailing icon in DropdownMenu#167782
auto-submit[bot] merged 9 commits intoflutter:masterfrom
mohamedamara:fix_164908_add_option_to_hide_trailing_icon

mohamedamara commented Apr 24, 2025

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

QuncCccccc May 7, 2025

Uh oh!

QuncCccccc May 7, 2025

Uh oh!

QuncCccccc May 7, 2025

Uh oh!

QuncCccccc left a comment

Uh oh!

MitchellGoodwin left a comment

Uh oh!

QuncCccccc commented May 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mohamedamara commented Apr 24, 2025

Pre-launch Checklist

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc May 7, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc May 7, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc May 7, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented May 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants