Add height and width aspects to MediaQuery. by ksokolovskyi · Pull Request #167829 · flutter/flutter

ksokolovskyi · 2025-04-25T17:45:50Z

Description

Adds widthOf, maybeWidthOf, heightOf, maybeHeightOf functions to MediaQuery
Adds tests for newly added functions

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

LGTM 👍 . I guess it's not uncommon to depend on only one of width or height, and this will improve performance in those cases. Thanks for filing this.

justinmc · 2025-04-29T22:48:41Z

@rkishan516 Maybe you want to review this one since it's related to InheritedModel and your #165289?

rkishan516 · 2025-04-30T00:26:41Z

@rkishan516 Maybe you want to review this one since it's related to InheritedModel and your #165289?

Sure, I can.

rkishan516 · 2025-04-30T00:39:49Z

LGTM. But I was thinking, after selector pattern this will be upto user, what does he wants.

For example :

// Rebuilds when size changes
final size = MediaQuery.select(context,(data) => data.size);

// Only rebuilds when width crosses the 400px threshold
final isMobile = MediaQuery.select(context, (data) => data.size.width < 400);

So, If we add these aspects, they might be deprecated soon.

ksokolovskyi · 2025-04-30T07:14:26Z

Hi @justinmc @rkishan516, thanks a lot for the review!

LGTM. But I was thinking, after selector pattern this will be upto user, what does he wants.

For example :
// Rebuilds when size changes
final size = MediaQuery.select(context,(data) => data.size);

// Only rebuilds when width crosses the 400px threshold
final isMobile = MediaQuery.select(context, (data) => data.size.width < 400);
So, If we add these aspects, they might be deprecated soon.

Honestly, I am not sure that any of the MediaQuery static methods will be deprecated after the introduction of the select. Are there any discussions regarding this?

For me, the usage of the specific method to get the single value is shorter and more convenient:

MediaQuery.heightOf(context);
MediaQuery.select(context, (data) => data.size.height);

rkishan516 · 2025-04-30T07:24:55Z

Honestly, I am not sure that any of the MediaQuery static methods will be deprecated after the introduction of the select. Are there any discussions regarding this?

Yaa, we will have much more clarity once we land one of InheritedModel to selector pattern.
I think adding these methods doesn't do any harm.

ksokolovskyi · 2025-05-01T19:53:13Z

@justinmc, do we still need a second approval on this PR?

gnprice

This LGTM. Thanks @ksokolovskyi!

justinmc · 2025-05-06T19:34:33Z

Let's go ahead and merge this while we figure out #165289.

Closes flutter#167828 ### Description - Adds `widthOf`, `maybeWidthOf`, `heightOf`, `maybeHeightOf` functions to `MediaQuery` - Adds tests for newly added functions ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…167829)

Roll Flutter from cfb887c to b0f5c8c (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619) 2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...

…167829)

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 25, 2025

Add height and width aspects to MediaQuery.

7983e9a

ksokolovskyi force-pushed the add-height-and-width-aspect-to-media-query branch from ec124be to 7983e9a Compare April 27, 2025 07:33

Fix test on web.

b61f9a0

justinmc approved these changes Apr 29, 2025

View reviewed changes

justinmc mentioned this pull request Apr 29, 2025

Feat: Migrate Theme to InheritedModel #165289

Closed

9 tasks

gnprice approved these changes May 1, 2025

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025

auto-submit bot added this pull request to the merge queue May 6, 2025

Merged via the queue into flutter:master with commit c781b31 May 6, 2025
75 of 76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025

ksokolovskyi mentioned this pull request May 7, 2025

Replace MediaQuery.sizeOf with heightOf and widthOf. #168478

Closed

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to 3a71fefdcaf1 (278 revisions) flutter/packages#9220

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

edf3cba

…167829)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to a3e9379a87ea (279 revisions) flutter/packages#9221

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

af77a42

…167829)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to 708c0eb18555 (280 revisions) flutter/packages#9222

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

f28b694

…167829)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/packages#9223

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

674c7fc

…167829)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to f9fb8906c7fb (282 revisions) flutter/packages#9224

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

4aab6ad

…167829)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to b3f6925fda4f (283 revisions) flutter/packages#9225

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

b96bc78

…167829)

engine-flutter-autoroll mentioned this pull request May 7, 2025

Roll Flutter from cfb887cd5f41 to 9d8e5e0b2f0d (284 revisions) flutter/packages#9226

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

387ad36

…167829)

Piinks mentioned this pull request May 9, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

24a9b5a

…167829)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

e64d46d

…167829)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

e128b20

…167829)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

72dd78a

…167829)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

c781b31 Add height and width aspects to MediaQuery. (flutter/flutter#…

d88dc11

…167829)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add height and width aspects to MediaQuery.#167829

Add height and width aspects to MediaQuery.#167829
auto-submit[bot] merged 2 commits intoflutter:masterfrom
ksokolovskyi:add-height-and-width-aspect-to-media-query

ksokolovskyi commented Apr 25, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc commented Apr 29, 2025 •

edited

Loading

Uh oh!

rkishan516 commented Apr 30, 2025

Uh oh!

rkishan516 commented Apr 30, 2025 •

edited

Loading

Uh oh!

ksokolovskyi commented Apr 30, 2025

Uh oh!

rkishan516 commented Apr 30, 2025

Uh oh!

ksokolovskyi commented May 1, 2025

Uh oh!

gnprice left a comment

Uh oh!

justinmc commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ksokolovskyi commented Apr 25, 2025

Description

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rkishan516 commented Apr 30, 2025

Uh oh!

rkishan516 commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksokolovskyi commented Apr 30, 2025

Uh oh!

rkishan516 commented Apr 30, 2025

Uh oh!

ksokolovskyi commented May 1, 2025

Uh oh!

gnprice left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justinmc commented Apr 29, 2025 •

edited

Loading

rkishan516 commented Apr 30, 2025 •

edited

Loading