Skip to content

Relands "backfill custom painter semantics properties (#166375)"#168113

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
chunhtai:reland-backfill
May 1, 2025
Merged

Relands "backfill custom painter semantics properties (#166375)"#168113
auto-submit[bot] merged 2 commits intoflutter:masterfrom
chunhtai:reland-backfill

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 30, 2025

This reverts commit 80d0409.

previous pr was merge with older branch which doesn't migrate new tests added later

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from hannah-hyj April 30, 2025 23:09
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository labels Apr 30, 2025
hannah-hyj
hannah-hyj approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 1, 2025
Merged via the queue into flutter:master with commit b982d42 May 1, 2025
75 of 76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
09a00f7 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
61fb75a 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
7f4a59a 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
7f5751b 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
9525ffd 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
1677537 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
739e05a 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
77832ca 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
932f1f5 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
f1a4cf5 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
a11edaf 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
7952720 
…5)" (flutter/flutter#168113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
09cf5e2 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
754f9b9 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
f6ed4c8 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
7675814 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
2837d8f 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
30f02a9 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
6d5421a 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
580e014 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
ea0ebab 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
291ec4f 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
d362301 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
7bc3101 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
5ab0531 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
853bc3c 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
86b3232 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
8707554 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
861c2f1 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
e185c11 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
f705bba 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
b7c23b7 
…5)" (flutter/flutter#168113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
b982d42 Relands "backfill custom painter semantics properties (#16637…
451b9cb 
…5)" (flutter/flutter#168113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunhtai @hannah-hyj