Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion by MitchellGoodwin · Pull Request #168182 · flutter/flutter

MitchellGoodwin · 2025-05-01T23:11:17Z

#164680 caused a regression where the systemUIStyle would not be set correctly if the previous page has a navbar.

Screen.Recording.2025-05-01.at.4.00.48.PM.mov

This happens because the RenderView is constantly watching for AnnotatedRegions at the top of the bottom of the screen to set the UI style. So the sheet when initialized would set the style, but during the transition the previous pages navbar is still at the top of the screen, so the RenderView immediately sets the style back to where it was.

This PR fixes that by adding an AnnotatedRegion behind the previous page through the delegatedTransition with the style set correctly for the sheet. That way when the previous page drops low enough, the systemUI switches over.

Screen.Recording.2025-05-01.at.3.57.39.PM.mov

The RenderView is watching for right around the midpoint of the systemUI so it switches back and forth at a good point when the transition is manually dragged back and forth.

Screen.Recording.2025-05-01.at.4.02.24.PM.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

That's pretty clever. I don't see why not. Maybe someone has stronger opinions on AnnotatedRegion and nav bars than me, but to me it seems like a pretty canonical use of AnnotatedRegion.

If not this, then we'd have to do something like have the previous page know that it's in a CupertinoBottomSheet and modify its own AnnotatedRegion? Or did you have any other ideas?

Thank you for the very clear PR description by the way 👍

Piinks · 2025-05-05T20:25:01Z

packages/flutter/lib/src/cupertino/sheet.dart

+            statusBarBrightness: Brightness.dark,
+            statusBarIconBrightness: Brightness.light,


Do we know this will always be the right brightness? Even in dark mode? It looks like where we do something similar in AppBar, we resolve the overlay style based on potential theme settings and color choices.

Yes, the background is always black in both light and dark mode, since it's the background "behind" the app on the device.

dkwingsmt · 2025-05-05T23:49:34Z

A great change, since AnnotatedRegion seems to have always been the preferred way over explicit setSystemUIOverlayStyle calls :) (link)

dkwingsmt

LGTM

…edRegion (flutter/flutter#168182)

flutter/flutter@0b9f928...9a78af5 2025-05-15 [email protected] Manual pub package roll (flutter/flutter#168916) 2025-05-15 [email protected] Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 [email protected] Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 [email protected] Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 [email protected] Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 [email protected] Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 [email protected] Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 [email protected] Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 [email protected] [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 [email protected] iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 [email protected] Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 [email protected] CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 [email protected] [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 [email protected] Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 [email protected] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 [email protected] Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 [email protected] Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 [email protected] Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 [email protected] Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 [email protected] Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 [email protected] Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 [email protected] Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 [email protected] macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 [email protected] Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…edRegion (flutter/flutter#168182)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels May 1, 2025

justinmc reviewed May 1, 2025

View reviewed changes

Piinks reviewed May 5, 2025

View reviewed changes

MitchellGoodwin added 2 commits May 12, 2025 16:39

Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion

b8be30c

Adjust test

fb093df

MitchellGoodwin force-pushed the sheet-system-ui branch from 171a01c to fb093df Compare May 12, 2025 23:39

MitchellGoodwin marked this pull request as ready for review May 12, 2025 23:39

Move default systemUI check down, add appbar

186ec99

MitchellGoodwin requested a review from dkwingsmt May 13, 2025 21:17

dkwingsmt approved these changes May 14, 2025

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025

auto-submit bot added this pull request to the merge queue May 14, 2025

Merged via the queue into flutter:master with commit 0cf1d34 May 14, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

52ccbfd

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 1d8078552d99 (21 revisions) flutter/packages#9253

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

f3d97d1

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to d69edc303b49 (22 revisions) flutter/packages#9255

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

f57d051

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to a164f6538603 (23 revisions) flutter/packages#9256

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

757e24e

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 94c661082cc3 (24 revisions) flutter/packages#9257

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

3d6d962

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9214ed12dbae (25 revisions) flutter/packages#9258

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

dc8fb0d

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9a78af5eb067 (26 revisions) flutter/packages#9259

Merged

Piinks mentioned this pull request May 16, 2025

Flutter Notable Commits - 2025 #161460

Closed

MitchellGoodwin mentioned this pull request May 27, 2025

Status bar in not visible when CupertinoSheetRoute is open #169390

Closed

MitchellGoodwin mentioned this pull request Jul 24, 2025

Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar #164680

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

ec52cbe

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

88e2788

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

5fc8d50

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

0a5f845

…edRegion (flutter/flutter#168182)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

0cf1d34 Make Cupertino sheet set the systemUIStyle through an Annotat…

652457a

…edRegion (flutter/flutter#168182)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion#168182

Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion#168182
auto-submit[bot] merged 3 commits intoflutter:masterfrom
MitchellGoodwin:sheet-system-ui

MitchellGoodwin commented May 1, 2025

Uh oh!

justinmc left a comment •

edited

Loading

Uh oh!

Piinks May 5, 2025

Uh oh!

MitchellGoodwin May 5, 2025

Uh oh!

dkwingsmt commented May 5, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		statusBarBrightness: Brightness.dark,
		statusBarIconBrightness: Brightness.light,

Conversation

MitchellGoodwin commented May 1, 2025

Pre-launch Checklist

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks May 5, 2025

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin May 5, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented May 5, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justinmc left a comment •

edited

Loading