added padding of 4.0 to dayWidget in calender date picker to match material design#168284
added padding of 4.0 to dayWidget in calender date picker to match material design#168284Aryan-Sood wants to merge 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
As original reporter of the issue, it looks like the circle got smaller, which isn't correct I believe. It was (around) 40px wide/high, and it looks smaller after the change. The idea was users had more tappable area to click the correct day, looks from the screenshot this does not fix that. Disclaimer: I did not check fully your fix with the specs, this is purely based on the screenshots from spec + ones you provided |
|
Thanks for your contribution! Since I haven't seen a reply, I'm going to reluctantly close this pull request for now, but if you get time to address the comments, we'd be more than happy to take a look at a new patch. If you do send a new patch, it would be very useful to reference this one in the description in order to help reviewers see the previous context. |


Added a padding of 4.0 to dayWidget used in calendar date picker to match the material3 design guidelines.
This PR solves the following issue -> #167269
Pre-launch Checklist
///).Before:

After:
