Fix the "Missing ExternalProject for :" error by rekire · Pull Request #168403 · flutter/flutter

rekire · 2025-05-06T19:01:03Z

Fix the "Missing ExternalProject for :" error

This fixes #168296

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bkonyi

Thanks for the PR! Just a couple of comments.

packages/flutter_tools/test/general.shard/base/file_system_test.dart

packages/flutter_tools/lib/src/base/file_system.dart

rekire · 2025-05-27T20:29:12Z

Thank you @bkonyi for your review. I applied your suggestions.

rekire · 2025-05-28T21:05:23Z

@reidbaker I reformatted my code, but this seems this break the Google Testing. Could you be so kind to tell me what's going on at Borg?

jmagman · 2025-05-28T21:30:39Z

@reidbaker I reformatted my code, but this seems this break the Google Testing. Could you be so kind to tell me what's going on at Borg?

Apologies, we're experiencing infrastructure issues. I marked it manually as passing.

rekire · 2025-05-29T05:09:35Z

@jmagman thank you for fixing that

@reidbaker @bkonyi is there anything else I should do before this can get merged?

reidbaker · 2025-05-29T15:10:48Z

Just @bkonyi to approve and add autosubmit.

bkonyi · 2025-05-29T15:21:10Z

packages/flutter_tools/lib/src/base/file_system.dart

+    if (_platform.isWindows) {
+      path = path
+          .replaceAll(r'\', r'\\')
+          .split(';')


Why are we splitting on ;? This API is only mean to handle individual paths, not the contents of the PATH variable.

bkonyi · 2025-05-29T15:21:41Z

packages/flutter_tools/test/general.shard/base/file_system_test.dart

      expect(fsUtils.escapePath('C:/foo/bar/cool.dart'), 'C:/foo/bar/cool.dart');
+      expect(fsUtils.escapePath('c:/foo/bar/cool.dart'), 'C:/foo/bar/cool.dart');
+      expect(fsUtils.escapePath('x:/foo/bar/cool.dart'), 'X:/foo/bar/cool.dart');
+      expect(fsUtils.escapePath('a:/foo;b:/bar'), 'A:/foo;B:/bar');


These last two use cases shouldn't be supported.

I'm sorry for this missunderstanding

No worries I also missed that. Thanks for the contributions. When you fix @bkonyi's comments we can get this landed.

Should be fine now I guess. Let's wait for bkonyi and the CI.

Yeah, not a problem!

packages/flutter_tools/test/general.shard/base/file_system_test.dart

…r#168403)

rekire added 2 commits May 6, 2025 20:49

Fix the "Missing ExternalProject for :" error

99aad29

Extend the test

37cfee5

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 6, 2025

rekire added 2 commits May 6, 2025 21:13

Add range check and detect drive letters

1de184b

Add missing type annotation

0156442

rekire mentioned this pull request May 7, 2025

Draft: Extend template to resolve dart and kotlin #168490

Closed

9 tasks

bkonyi requested review from a team and bkonyi May 26, 2025 15:58

bkonyi reviewed May 26, 2025

View reviewed changes

packages/flutter_tools/test/general.shard/base/file_system_test.dart Show resolved Hide resolved

packages/flutter_tools/lib/src/base/file_system.dart Show resolved Hide resolved

rekire added 2 commits May 27, 2025 22:08

Simplify code as suggested

ca778be

Extend escapePath to process multiple path too

ee671f5

rekire requested a review from bkonyi May 27, 2025 20:28

reidbaker approved these changes May 28, 2025

View reviewed changes

Reformat code

b412d53

bkonyi requested changes May 29, 2025

View reviewed changes

Undo multiple path handling and extend test

eb416ab

reidbaker approved these changes May 29, 2025

View reviewed changes

bkonyi approved these changes May 29, 2025

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

auto-submit bot added this pull request to the merge queue May 29, 2025

Merged via the queue into flutter:master with commit ae11f77 May 29, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to ae11f77f20ff (25 revisions) flutter/packages#9340

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

53d8627

…r#168403)

engine-flutter-autoroll mentioned this pull request Jun 2, 2025

Roll Flutter from 0e536eb9fe4b to ead0a01bb970 (69 revisions) flutter/packages#9357

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

9be1f3f

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

fde39f1

…r#168403)

engine-flutter-autoroll mentioned this pull request Jun 2, 2025

Roll Flutter from 0e536eb9fe4b to ff2184fc8ab2 (70 revisions) flutter/packages#9358

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

5b462e4

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

868dd8f

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

f5b66d9

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

86afb00

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

9831130

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

9178213

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

f7ac40c

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

6150122

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

a5ebfb7

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

148cd9c

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

8237497

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

28f9816

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

80665c1

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

8fff9b7

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

651a486

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

40b2387

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

0a046da

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

bd8a0c4

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

3441a29

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

feb422c

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

7824819

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

191059b

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

25809f2

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

fab9fcd

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

8f99f68

…r#168403)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

ae11f77 Fix the "Missing ExternalProject for :" error (flutter/flutte…

6e20cf6

…r#168403)

Conversation

rekire commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rekire commented May 27, 2025

Uh oh!

rekire commented May 28, 2025

Uh oh!

jmagman commented May 28, 2025

Uh oh!

rekire commented May 29, 2025

Uh oh!

reidbaker commented May 29, 2025

Uh oh!

bkonyi May 29, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi May 29, 2025

Choose a reason for hiding this comment

Uh oh!

rekire May 29, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker May 29, 2025

Choose a reason for hiding this comment

Uh oh!

rekire May 29, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rekire commented May 6, 2025 •

edited

Loading