Draft: Extend template to resolve dart and kotlin#168490
Closed
rekire wants to merge 90 commits intoflutter:masterfrom
Closed
Draft: Extend template to resolve dart and kotlin#168490rekire wants to merge 90 commits intoflutter:masterfrom
rekire wants to merge 90 commits intoflutter:masterfrom
Conversation
…to_resolve_dart_and_kotlin # Conflicts: # packages/flutter_tools/lib/src/base/file_system.dart
github-actions
bot
added
platform-android
…_template_to_resolve_dart_and_kotlin_v2 # Conflicts: # packages/flutter_tools/lib/src/project.dart
9 tasks
Contributor
|
Hey @rekire is this change still on your radar? It looks like there are some failing checks, and some conflicts to resolve. |
Contributor
Author
|
@Piinks yes I have that in mind, it was just the last time that I run out of ideas (of cause the merge conflicts are clear). Might be the break was now long enough to get this resolved after a longer break. |
…resolve_dart_and_kotlin_v2 # Conflicts: # packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt
…_template_to_resolve_dart_and_kotlin_v2 # Conflicts: # packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt
…_template_to_resolve_dart_and_kotlin_v2
…_template_to_resolve_dart_and_kotlin_v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to change the templates to make use of #167332 by default. I want to check for now the failing tests (I cannot run some tests local)
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.