Removes elevation and thickness from semantics by chunhtai · Pull Request #168703 · flutter/flutter

chunhtai · 2025-05-12T22:48:20Z

They were added to accommodate fuchsia's 3d rendering of screen reader, which was never implemented. There are also no usage across embedder given we have send children in hittest order as well.

fixes #166092

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2025-05-13T20:24:26Z

engine/src/flutter/shell/platform/fuchsia/flutter/accessibility_bridge.cc

  fuchsia::ui::gfx::BoundingBox box;
  box.min.x = node.rect.fLeft;
  box.min.y = node.rect.fTop;
-  box.min.z = static_cast<float>(node.elevation);


z index is not used anywhere in fuchsia screen reader. It is also a bit hard for me to imagine how they can be used.

Hi @zijiehe-google-com , I saw you had made changes to fuchsia embedder, can you help me find a reviewer that can review the fuchsia change?

Hey, I think @jrwang would be the best person to review the change.

zijiehe-google-com · 2025-05-13T22:47:30Z

lgtm, fuchsia builders are running fine.

jrwang

LGTM

hannah-hyj

LGTM

#12010) _Description of what this PR is changing or adding, and why: breaking change _Issues fixed by this PR (if any): flutter/flutter#168703 _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [ ] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

auto-submit · 2025-05-15T18:23:06Z

autosubmit label was removed for flutter/flutter/168703, because - The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-05-15T19:15:19Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168703 at sha 5680450

flutter-dashboard · 2025-05-15T21:33:21Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168703 at sha 4cd7392

chunhtai · 2025-05-16T17:08:37Z

google test seems to not pick up the engine change, need to manually test the pr

same as #168703, but previous pr seems bugged github ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

chunhtai mentioned this pull request May 13, 2025

Add breaking change doc for removing semantics elevation and thickness flutter/website#12010

Merged

4 tasks

github-actions bot added platform-fuchsia Fuchsia code specifically platform-windows Building on or for Windows specifically a: desktop Running on desktop labels May 13, 2025

chunhtai commented May 13, 2025

View reviewed changes

zijiehe-google-com approved these changes May 13, 2025

View reviewed changes

chunhtai requested a review from jrwang May 14, 2025 16:53

chunhtai force-pushed the issues/166092 branch from 43db5c8 to a54e1d6 Compare May 14, 2025 19:24

github-actions bot removed the a: animation Animation APIs label May 14, 2025

chunhtai requested a review from hannah-hyj May 14, 2025 22:08

jrwang approved these changes May 15, 2025

View reviewed changes

hannah-hyj approved these changes May 15, 2025

View reviewed changes

chunhtai force-pushed the issues/166092 branch from 0c218cf to 5680450 Compare May 15, 2025 16:56

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label May 15, 2025

chunhtai force-pushed the issues/166092 branch from 5680450 to 4cd7392 Compare May 15, 2025 20:10

chunhtai force-pushed the issues/166092 branch from e8a00bd to a255891 Compare May 16, 2025 20:57

chunhtai added 2 commits May 19, 2025 15:10

Removes elevation and thickness from semantics

0dce8a4

fix test

b35c177

chunhtai force-pushed the issues/166092 branch from a255891 to b35c177 Compare May 19, 2025 22:10

chunhtai mentioned this pull request May 23, 2025

Removes elevation and thickness from semantics r2 #169382

Merged

9 tasks

chunhtai closed this May 23, 2025

chunhtai force-pushed the issues/166092 branch 2 times, most recently from a112853 to f13c3e2 Compare May 23, 2025 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes elevation and thickness from semantics#168703

Removes elevation and thickness from semantics#168703
chunhtai wants to merge 2 commits intoflutter:masterfrom
chunhtai:issues/166092

chunhtai commented May 12, 2025 •

edited

Loading

Uh oh!

chunhtai May 13, 2025

Uh oh!

chunhtai May 13, 2025

Uh oh!

zijiehe-google-com May 13, 2025

Uh oh!

zijiehe-google-com commented May 13, 2025

Uh oh!

jrwang left a comment

Uh oh!

hannah-hyj left a comment

Uh oh!

auto-submit bot commented May 15, 2025

Uh oh!

flutter-dashboard bot commented May 15, 2025

Uh oh!

flutter-dashboard bot commented May 15, 2025

Uh oh!

chunhtai commented May 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chunhtai commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai May 13, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai May 13, 2025

Choose a reason for hiding this comment

Uh oh!

zijiehe-google-com May 13, 2025

Choose a reason for hiding this comment

Uh oh!

zijiehe-google-com commented May 13, 2025

Uh oh!

jrwang left a comment

Choose a reason for hiding this comment

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 15, 2025

Uh oh!

flutter-dashboard bot commented May 15, 2025

Uh oh!

flutter-dashboard bot commented May 15, 2025

Uh oh!

chunhtai commented May 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chunhtai commented May 12, 2025 •

edited

Loading