Add a new CI build for iOS DDM-enabled artifacts by jacobsimionato · Pull Request #168717 · flutter/flutter

jacobsimionato · 2025-05-13T04:15:34Z

This adds a new flavor of mac_ios_engine, which enables a build flag. This is not part of the merge-queue since it's intended for experimental and internal use at the moment.

Tested locally via et build --config ci/mac_ios_engine_ddm

This follows @sigmundch 's #162855 which achieves the same result for Android.

I branched mac_ios_engine_ddm.json and removed:

x86 builds, seeing as I think we're all testing locally with arm64 macs now, and forge supports them as well (with a flag to force use of arm64).
All "extension safe" builds seeing as we aren't targeting watches at this point.
All "profile" flavor builds

jiahaog · 2025-05-13T06:20:27Z

engine/src/flutter/ci/builders/mac_ios_engine_ddm.json

+        "--xcode-symlinks",
+        "--gn-args=dart_dynamic_modules=true"
+      ],
+      "name": "ci/ios_releas_ddm",


sigmundch

Thanks Jacob! Adding @matanlurey as a reviewer too, to make sure we are not missing any important details.

sigmundch · 2025-05-13T18:49:16Z

engine/src/flutter/.ci.yaml

+    timeout: 240
+    properties:
+      add_recipes_cq: "true"
+      release_build: "false"


remove this line, apparently the only way to make it false is to not include the line (see 11c3067)

+1. I actually fixed this bug, but there is no reason to include it.

sigmundch · 2025-05-13T18:51:35Z

engine/src/flutter/ci/builders/mac_ios_engine_ddm.json

+      },
+      "gn": [
+        "--target-dir",
+        "ci/ios_profile_ddm",


Consider removing the profile variants. For android we completely skipped them to reduce costs (since we didn't expect to use them for a while.)

+1. Please only build what you need.

sigmundch · 2025-05-13T18:54:30Z

engine/src/flutter/ci/builders/mac_ios_engine_ddm.json

+      },
+      "gn": [
+        "--target-dir",
+        "ci/ios_debug_sim_arm64_ddm",


interesting, in android I don't recall that we needed separate targets for the emulator - I assume there we can use the same debug builds for both?

Bummer we can't just reuse the regular debug builds here :(.

I assume then we need both? Or can it be enough to only pick one or the other?

iOS simulators and iOS devices are different engine builds (they work differently).

Sounds like we still need this here, so I'll keep it for now.

sigmundch · 2025-05-13T18:58:15Z

engine/src/flutter/.ci.yaml

+    properties:
+      add_recipes_cq: "true"
+      release_build: "false"
+      backfill: "false"


I believe now backfill is no longer a property, but a boolean that can be specified next to the properties section:

properties: add_recipes_cq: "true" backfill: false # Note: no quotes

(changed happened in 5da19cc)

sigmundch · 2025-05-13T19:00:44Z

engine/src/flutter/.ci.yaml


+  - name: Mac mac_ios_engine_ddm
+    recipe: engine_v2/engine_v2
+    timeout: 240


when adding android, we were asked to also write bringup: true to ensure it was scheduled in the staging bots, but I'm not sure if that applies here.

@matanlurey would know :)

If this is a new build, you will have to add bringup: true.

And yes, let's initially keep it as a bringup build.

matanlurey · 2025-05-13T19:31:33Z

engine/src/flutter/.ci.yaml


+  - name: Mac mac_ios_engine_ddm
+    recipe: engine_v2/engine_v2
+    timeout: 240


If this is a new build, you will have to add bringup: true.

And yes, let's initially keep it as a bringup build.

matanlurey · 2025-05-13T19:31:48Z

engine/src/flutter/.ci.yaml

+    timeout: 240
+    properties:
+      add_recipes_cq: "true"
+      release_build: "false"


+1. I actually fixed this bug, but there is no reason to include it.

matanlurey · 2025-05-13T19:31:52Z

engine/src/flutter/.ci.yaml

+    properties:
+      add_recipes_cq: "true"
+      release_build: "false"
+      backfill: "false"


engine/src/flutter/.ci.yaml

matanlurey · 2025-05-13T19:33:24Z

engine/src/flutter/ci/builders/mac_ios_engine_ddm.json

+      },
+      "gn": [
+        "--target-dir",
+        "ci/ios_debug_sim_arm64_ddm",


iOS simulators and iOS devices are different engine builds (they work differently).

matanlurey · 2025-05-13T19:33:37Z

engine/src/flutter/ci/builders/mac_ios_engine_ddm.json

+      },
+      "gn": [
+        "--target-dir",
+        "ci/ios_profile_ddm",


+1. Please only build what you need.

matanlurey · 2025-05-14T15:12:43Z

engine/src/flutter/.ci.yaml

+    enabled_branches:
+      # Don't run this on release branches
+      - master
+    backfill: "false"


This is backfill: false. Sorry only properties are strictly string properties for ... reasons?

zanderso · 2025-05-15T14:21:38Z

engine/src/flutter/ci/builders/mac_ios_engine_ddm.json

+          "--simulator-arm64-out-dir",
+          "out/ci/ios_debug_sim_arm64_ddm"
+        ],
+        "script": "flutter/sky/tools/create_ios_framework.py",


This is failing on CI because this script is looking for the extension_safe variants, but they aren't being built. I think this script probably needs a command line flag to tell it that the extension_safe variants aren't going to be there:

flutter/engine/src/flutter/sky/tools/create_ios_framework.py

Line 181 in 1d80785

'extension_safe/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',

.

cc @cbracken

…tter#168717)

flutter/flutter@0b9f928...9a78af5 2025-05-15 [email protected] Manual pub package roll (flutter/flutter#168916) 2025-05-15 [email protected] Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 [email protected] Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 [email protected] Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 [email protected] Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 [email protected] Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 [email protected] Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 [email protected] Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 [email protected] [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 [email protected] iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 [email protected] Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 [email protected] CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 [email protected] [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 [email protected] Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 [email protected] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 [email protected] Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 [email protected] Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 [email protected] Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 [email protected] Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 [email protected] Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 [email protected] Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 [email protected] Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 [email protected] macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 [email protected] Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Similar to #168233, but this time for iOS Follow-up to #168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.

Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.

…tter#168717)

Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.

Work towards [b/452833651](b/452833651). This adds a new flavor of linux_host_engine, which enables the DDM build flag with the goal of building a flutter_tester binary that supports loading DDMs in tests. Tested locally via `et build --config ci/host_debug_ddm`. This roughly follows #168717, which added a similar DDM-enabled build for iOS. I've branched this off the `linux_host_engine.json`, added the build flag for DDM support, and removed things we don't need.

Similar to flutter#168233, but this time for iOS Follow-up to flutter#168717 As we start to work more seriously with ddm we'd like to have these builds always available instead of on demand only.

) Work towards [b/452833651](b/452833651). This adds a new flavor of linux_host_engine, which enables the DDM build flag with the goal of building a flutter_tester binary that supports loading DDMs in tests. Tested locally via `et build --config ci/host_debug_ddm`. This roughly follows flutter#168717, which added a similar DDM-enabled build for iOS. I've branched this off the `linux_host_engine.json`, added the build flag for DDM support, and removed things we don't need.

github-actions bot added the engine flutter/engine related. See also e: labels. label May 13, 2025

jacobsimionato requested review from jiahaog and sigmundch May 13, 2025 06:14

jiahaog reviewed May 13, 2025

View reviewed changes

sigmundch reviewed May 13, 2025

View reviewed changes

sigmundch requested a review from matanlurey May 13, 2025 19:02

matanlurey requested changes May 13, 2025

View reviewed changes

matanlurey approved these changes May 14, 2025

View reviewed changes

matanlurey reviewed May 14, 2025

View reviewed changes

jacobsimionato added 6 commits May 15, 2025 06:57

Add a new CI build for iOS DDM-enabled artifacts

b597cab

Remove unnecessary extension-related builds

8997ca7

Add ddm suffix to the names of build artifacts

a5ce44a

Fix issues with .ci.yaml config and remove profile iOS DDM build

6fd8e86

Fix folder references in archives

fd8becc

Update backfill to be boolean rather than string

bf24825

jacobsimionato force-pushed the ios_ddm_build branch from 370c714 to bf24825 Compare May 14, 2025 21:27

jacobsimionato enabled auto-merge May 14, 2025 21:27

Merge branch 'master' into ios_ddm_build

643e2a4

jacobsimionato added this pull request to the merge queue May 15, 2025

Merged via the queue into flutter:master with commit 8556b25 May 15, 2025
178 of 180 checks passed

jacobsimionato deleted the ios_ddm_build branch May 15, 2025 02:06

zanderso reviewed May 15, 2025

View reviewed changes

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 1d8078552d99 (21 revisions) flutter/packages#9253

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

d8847d1

…tter#168717)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

134bb3e

…tter#168717)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to d69edc303b49 (22 revisions) flutter/packages#9255

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

79b8009

…tter#168717)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to a164f6538603 (23 revisions) flutter/packages#9256

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

2936fe9

…tter#168717)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 94c661082cc3 (24 revisions) flutter/packages#9257

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

9541275

…tter#168717)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9214ed12dbae (25 revisions) flutter/packages#9258

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

7ea138b

…tter#168717)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9a78af5eb067 (26 revisions) flutter/packages#9259

Merged

goderbauer mentioned this pull request Aug 1, 2025

[dync_modules] enable iOS ddm build in the merge queue #173094

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

ea518f3

…tter#168717)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

a15eb54

…tter#168717)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

5f3e901

…tter#168717)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

a2b072b

…tter#168717)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

8556b25 Add a new CI build for iOS DDM-enabled artifacts (flutter/flu…

4cbedf5

…tter#168717)

goderbauer mentioned this pull request Oct 20, 2025

Adds a new CI build for Linux host DDM-enabled artifacts #177252

Merged

Conversation

jacobsimionato commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sigmundch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jacobsimionato commented May 13, 2025 •

edited

Loading