[hcpp/hc] Fix talkback for HC and HCPP Android platform views by gmackall · Pull Request #168939 · flutter/flutter

gmackall · 2025-05-15T20:41:21Z

See the description here: #113626 (comment)

Also, I think we can probably improve the behavior here to respect what the original view's accessibility importance was, by storing what we are overwriting at creation time, and then using that later when we undo what we do at creation time. As is it seems like there would be no way for a developer to actually set their view to be not important for accessibility, we are basically forcing them in to auto. Can look into that in a follow up.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall · 2025-05-15T20:44:11Z

@jonahwilliams I still need to figure out how to test this, but does the approach look reasonable (specifically putting a controller in front of the controllers).

I can name it something else if desired, but also I expect something like this is destined to exist regardless to support the unified PV constructor Reid is working on, which will need to then delegate creation to either PVC1 or 2 depending.

jonahwilliams

Seems like a reasonable approach. Though please name it something besides ControllerController :)

jonahwilliams · 2025-05-16T00:08:29Z

Its more of a delegate perhaps :)

gmackall · 2025-05-16T18:25:16Z

Its more of a delegate perhaps :)

Renamed to PlatformViewsControllerDelegator 😢

jonahwilliams

LGTM

chunhtai

LGTM

…flutter/flutter#168939)

Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181) 2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

…flutter/flutter#168939)

…180539) Fixes #180381 #179922 which track a regression from #168939 Wraps in a null check, and if the embeddedView is null we fall back to adding the semantics node we are looking at in the loop as a child. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>

…lutter#180539) Fixes flutter#180381 flutter#179922 which track a regression from flutter#168939 Wraps in a null check, and if the embeddedView is null we fall back to adding the semantics node we are looking at in the loop as a child. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>

Gray Mackall added 13 commits May 8, 2025 11:26

wip, uncommit this

26f8ddc

format the wip

f0e77d8

wild wip

a801222

format

720c130

wip

b5067be

format

1a58297

stop doing broken vd workaround

c420107

format

e0353b2

clean up, working state

fd2e014

more clean up

f6f31d8

do format

a630dcf

make PVCC plural correctly

38fd2c7

make it auto

57d058d

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels May 15, 2025

This comment was marked as outdated.

Sign in to view

Merge branch 'master' into talkback_hcpp

cb33673

jonahwilliams reviewed May 16, 2025

View reviewed changes

format, test

cf0950c

gmackall marked this pull request as ready for review May 16, 2025 18:24

gmackall requested review from a team, chunhtai and jonahwilliams May 16, 2025 18:25

jonahwilliams approved these changes May 16, 2025

View reviewed changes

chunhtai approved these changes May 16, 2025

View reviewed changes

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

2267339

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to 80f5de5da95d (38 revisions) flutter/packages#9292

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

ff717c4

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 20, 2025

Roll Flutter from 9a78af5eb067 to c04cd2b18ebf (46 revisions) flutter/packages#9294

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

79e57d1

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 20, 2025

Roll Flutter from 9a78af5eb067 to c04cd2b18ebf (46 revisions) flutter/packages#9296

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

eb6bca8

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 61fe9b6b67c0 (55 revisions) flutter/packages#9299

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

ac97005

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to dd671fae53d3 (56 revisions) flutter/packages#9301

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

52eb652

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 534b250a562c (58 revisions) flutter/packages#9303

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

7c66c13

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to f7354da75b27 (59 revisions) flutter/packages#9304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

41b9254

…flutter/flutter#168939)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/packages#9305

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

a6f810d

…flutter/flutter#168939)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

742908d

…flutter/flutter#168939)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

17146f3

…flutter/flutter#168939)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

f3ce8a5

…flutter/flutter#168939)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

af36ea6

…flutter/flutter#168939)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

8463d5e [hcpp/hc] Fix talkback for HC and HCPP Android platform views (…

dccf8da

…flutter/flutter#168939)

gmackall mentioned this pull request Sep 17, 2025

[hcpp] Manual accessibility testing of non-trivial application. #164216

Closed

gmackall mentioned this pull request Jan 5, 2026

Add a null check for embedded view being added to accessibility tree #180539

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hcpp/hc] Fix talkback for HC and HCPP Android platform views#168939

[hcpp/hc] Fix talkback for HC and HCPP Android platform views#168939
auto-submit[bot] merged 16 commits intoflutter:masterfrom
gmackall:talkback_hcpp

gmackall commented May 15, 2025 •

edited

Loading

Uh oh!

gmackall commented May 15, 2025

Uh oh!

This comment was marked as outdated.

jonahwilliams left a comment

Uh oh!

jonahwilliams commented May 16, 2025

Uh oh!

gmackall commented May 16, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

chunhtai left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gmackall commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall commented May 15, 2025

Uh oh!

This comment was marked as outdated.

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented May 16, 2025

Uh oh!

gmackall commented May 16, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gmackall commented May 15, 2025 •

edited

Loading