Switch to Linux orchestrators for Windows releasers. by matanlurey · Pull Request #168941 · flutter/flutter

matanlurey · 2025-05-15T20:49:09Z

/cc @reidbaker as release engineer

/cc @zanderso (we talked about this offline)

engine/src/flutter/.ci.yaml

jtmcdole

what am I, the LGTM mill?

matanlurey · 2025-05-15T20:54:38Z

Blocked waiting for https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20ci_yaml%20flutter%20roller/19124/overview.

reidbaker · 2025-05-15T21:14:17Z

engine/src/flutter/.ci.yaml

      - cpu=x86

  - name: Linux windows_android_aot_engine
-    recipe: engine_v2/engine_v2


Are you deleting everything but the name because of the weird merged namespaces in ci.yaml we have with release builders?

NO, something else is happening here. Dont waste your time getting me up to speed.

auto-submit · 2025-05-15T21:33:28Z

autosubmit label was removed for flutter/flutter/168941, because - The status or check suite Windows module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Windows module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_9_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_8_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_5_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_4_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_1_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-05-15T22:04:43Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: a79bc2c.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID ECBE:206D1F:1B8C2EA:3723636:682664FB.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:246:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1228:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1289:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1100:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompletion (package:cocoon_service/src/service/scheduler.dart:1033:9)
<asynchronous suspension>
#9      Scheduler.processCheckRun (package:cocoon_service/src/service/scheduler.dart:1373:9)
<asynchronous suspension>
#10     GithubWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/webhook_subscription.dart:115:24)
<asynchronous suspension>
#11     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#12     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#13     createServer.<anonymous closure> (package:cocoon_service/server.dart:324:7)
<asynchronous suspension>

matanlurey · 2025-05-15T23:56:54Z

Let's hold this PR until after the I/O stable

matanlurey · 2025-05-20T18:21:47Z

I will wait until I come back from vacation to do this.

matanlurey · 2025-05-30T16:44:20Z

@eyebrowsoffire Can you sign off (approve)? When I merge this, it will need to be CPd into beta/stable immediately.

eyebrowsoffire

LGTM!

…/flutter#168941)

, flutter#168941)

In order to save resources on windows runners the orchestrator for windows_arm_host_engine is moved to Linux. See: #176385 (comment) Towards: #62597 Ref PR: #168941 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gaaclarke <[email protected]>

… Linux (#183574) In order to save resources on windows runners the orchestrator for windows_arm_host_engine is moved to Linux. See: #176385 (comment) The orchestrator seems to be successful on Linux (last column): https://flutter-dashboard.appspot.com/#/build?showMac=false&showiOS=false&showAndroid=false&showBringup=true&repo=flutter&branch=master <img width="571" height="634" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/3795023d-02a7-4e6e-8b19-57994e1e5e0b" /> Follows on: #181075 Towards: #62597 Ref PR: #168941 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Switch to Linux orchestrators for Windows releasers.

7f992f2

matanlurey requested a review from jtmcdole May 15, 2025 20:49

github-actions bot added the engine flutter/engine related. See also e: labels. label May 15, 2025

jtmcdole reviewed May 15, 2025

View reviewed changes

engine/src/flutter/.ci.yaml Outdated Show resolved Hide resolved

++

281c7fc

jtmcdole approved these changes May 15, 2025

View reviewed changes

Trigger Build

c164b82

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025

reidbaker reviewed May 15, 2025

View reviewed changes

reidbaker approved these changes May 15, 2025

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025

++

a79bc2c

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025

Merge branch 'master' into use-linux-orchestrators

51005db

matanlurey removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025

matanlurey marked this pull request as draft May 15, 2025 23:57

matanlurey changed the title ~~Switch to Linux orchestrators for Windows releasers.~~ [TODO: After 3.32 Stable] Switch to Linux orchestrators for Windows releasers. May 15, 2025

matanlurey changed the title ~~[TODO: After 3.32 Stable] Switch to Linux orchestrators for Windows releasers.~~ Switch to Linux orchestrators for Windows releasers. May 30, 2025

matanlurey marked this pull request as ready for review May 30, 2025 00:10

matanlurey requested a review from eyebrowsoffire May 30, 2025 16:44

eyebrowsoffire approved these changes May 30, 2025

View reviewed changes

matanlurey added this pull request to the merge queue May 30, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

4cc3508

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

89820a3

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

b7a4dfb

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

a3a5236

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

7542bc1

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

35552f5

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

218f428

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

8a634da

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

1aaceb6

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

d028268

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

3c17fd0

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

ed7638a

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

3c33899

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

3e98b96

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

7e08306

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

942eb12

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

530118f

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

96bea80

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

3b5bbec

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

2979bb8

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

a7cbf0f

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

c2b2a2c

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

f6563f2

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

2ab3284

…/flutter#168941)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

088d1bd Switch to Linux orchestrators for Windows releasers. (flutter…

7f64c0d

…/flutter#168941)

Gustl22 added a commit to Gustl22/flutter that referenced this pull request Jan 16, 2026

ci: Run orchestrator for windows_arm_host_engine on Linux (flutter#62597

76eb0af

, flutter#168941)

Gustl22 mentioned this pull request Jan 16, 2026

ci: Run orchestrator for windows_arm_host_engine on Linux #181075

Merged

9 tasks

Gustl22 mentioned this pull request Mar 12, 2026

ci: Remove bringup from orchestrator for windows_arm_host_engine on Linux #183574

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to Linux orchestrators for Windows releasers.#168941

Switch to Linux orchestrators for Windows releasers.#168941
matanlurey merged 5 commits intoflutter:masterfrom
matanlurey:use-linux-orchestrators

matanlurey commented May 15, 2025

Uh oh!

Uh oh!

jtmcdole left a comment

Uh oh!

matanlurey commented May 15, 2025

Uh oh!

reidbaker May 15, 2025

Uh oh!

reidbaker May 15, 2025

Uh oh!

auto-submit bot commented May 15, 2025

Uh oh!

flutter-dashboard bot commented May 15, 2025

Uh oh!

matanlurey commented May 15, 2025

Uh oh!

matanlurey commented May 20, 2025

Uh oh!

matanlurey commented May 30, 2025

Uh oh!

eyebrowsoffire left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

matanlurey commented May 15, 2025

Uh oh!

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

matanlurey commented May 15, 2025

Uh oh!

reidbaker May 15, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker May 15, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 15, 2025

Uh oh!

flutter-dashboard bot commented May 15, 2025

Uh oh!

matanlurey commented May 15, 2025

Uh oh!

matanlurey commented May 20, 2025

Uh oh!

matanlurey commented May 30, 2025

Uh oh!

eyebrowsoffire left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants