Skip to content

Add back "Use live region in error text input decorator for Android #165531"#168992

Merged
auto-submit[bot] merged 34 commits intoflutter:masterfrom
ash2moon:feat/form-live-region
Jun 25, 2025
Merged

Add back "Use live region in error text input decorator for Android #165531"#168992
auto-submit[bot] merged 34 commits intoflutter:masterfrom
ash2moon:feat/form-live-region

Conversation

@ash2moon
Copy link
Contributor

@ash2moon ash2moon commented May 16, 2025

Partly of #165510

⤴️ Parent PR: #169685 (✅ Merged)
⤴️ Parent PR (refactor): #170618 (✅ Merged)

Re-lands #165531
The PR was originally reverted due to an issue with an internal Google test. I added a new test case under input_decorator_test.dart which does something similar to prevent the regression. All other code is the same as #165531.

The easiest way to review this would probably be to just check the diff after the first commit to see the changes I made. To check if the reland commit is the same, it might be best to just compare solely that commit against the original PR.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels May 16, 2025
@ash2moon ash2moon force-pushed the feat/form-live-region branch from 7f6df3d to 9bd8d56 Compare May 16, 2025 18:23
@ash2moon ash2moon force-pushed the feat/form-live-region branch from ec61f12 to cb5647c Compare May 18, 2025 03:52
@matanlurey matanlurey removed their request for review May 19, 2025 22:27
@ash2moon
Copy link
Contributor Author

ash2moon commented Jun 25, 2025

@chunhtai @Piinks @ash2moon Is this PR good to land?

We should be good. Was just waiting on more final look after the renaming refactor but I just double checked everything again.

@auto-submit auto-submit bot added this pull request to the merge queue Jun 25, 2025
Merged via the queue into flutter:master with commit c9537a5 Jun 25, 2025
70 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants