Feat: Add mouse cursor for CupertinoDialogAction by rkishan516 · Pull Request #169051 · flutter/flutter

rkishan516 · 2025-05-19T01:19:05Z

This PR updates the mouse pointer behavior for CupertinoDialogAction to display a pointer cursor when hovering over the action button. Currently, when hovering over CupertinoDialogAction buttons on desktop platforms, the default cursor is shown instead of changing to a pointer cursor, which doesn't provide proper visual feedback to users that the element is clickable.

Changes

Added mouse cursor property to CupertinoDialogAction to display SystemMouseCursors.click when hovering
Updated relevant tests to verify the cursor behavior

Technical Details

The implementation adds the appropriate cursor property to the CupertinoDialogAction widget, ensuring that when users hover over the action button on desktop platforms, the cursor changes to a pointer, indicating that the element is clickable.

Related Issues

fixes: #169037 (Mouse style doesn't change to pointer when hovering over CupertinoDialogAction on Desktop)
Part of: #58192 (Add mouse cursor support to the remaining widgets)

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

dkwingsmt · 2025-05-22T00:46:06Z

I'm confused because your PR isn't doing what your title says. This PR's code adds a mouseCursor property to the widget without changing the default behavior, which I can get behind with. However, I don't agree with the change proposed by #169037 (which your PR isn't actually doing).

Can you clarify?

rkishan516 · 2025-05-22T01:22:43Z

I'm confused because your PR isn't doing what your title says. This PR's code adds a mouseCursor property to the widget without changing the default behavior, which I can get behind with. However, I don't agree with the change proposed by #169037 (which your PR isn't actually doing).

Can you clarify?

Sorry, I started with #169037 and then found #58192 and ended up adding mouseCursor which actually is not default behaviour but on override behaviour. I will update title.

dkwingsmt

LGTM, thank you!

packages/flutter/test/cupertino/dialog_test.dart

chunhtai

LGTM

packages/flutter/lib/src/cupertino/dialog.dart

Co-authored-by: Tong Mu <[email protected]>

Co-authored-by: chunhtai <[email protected]>

…tter#169051)

Roll Flutter from 8303a96 to 85a9b4f (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716) 2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808) 2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750) 2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743) 2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...

This PR updates the mouse pointer behavior for CupertinoDialogAction to display a pointer cursor when hovering over the action button. Currently, when hovering over CupertinoDialogAction buttons on desktop platforms, the default cursor is shown instead of changing to a pointer cursor, which doesn't provide proper visual feedback to users that the element is clickable. ## Changes - Added mouse cursor property to CupertinoDialogAction to display SystemMouseCursors.click when hovering - Updated relevant tests to verify the cursor behavior ## Technical Details The implementation adds the appropriate cursor property to the CupertinoDialogAction widget, ensuring that when users hover over the action button on desktop platforms, the cursor changes to a pointer, indicating that the element is clickable. ## Related Issues fixes: flutter#169037 (Mouse style doesn't change to pointer when hovering over CupertinoDialogAction on Desktop) Part of: flutter#58192 (Add mouse cursor support to the remaining widgets) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <[email protected]> Co-authored-by: chunhtai <[email protected]>

Roll Flutter from 8303a96 to 85a9b4f (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716) 2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808) 2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750) 2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743) 2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...

…tter#169051)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels May 19, 2025

rkishan516 force-pushed the cupertino-dialog-action branch from 1f14f80 to 34d21bb Compare May 19, 2025 01:21

rkishan516 marked this pull request as ready for review May 19, 2025 01:22

dkwingsmt self-requested a review May 21, 2025 18:18

rkishan516 changed the title ~~Fix: Update mouse pointer behaviour for CupertinoDialogAction~~ Feat: Add mouse cursor for CupertinoDialogAction May 22, 2025

dkwingsmt approved these changes Jun 4, 2025

View reviewed changes

packages/flutter/test/cupertino/dialog_test.dart Outdated Show resolved Hide resolved

dkwingsmt reviewed Jun 4, 2025

View reviewed changes

packages/flutter/test/cupertino/dialog_test.dart Outdated Show resolved Hide resolved

chunhtai approved these changes Jun 4, 2025

View reviewed changes

packages/flutter/lib/src/cupertino/dialog.dart Outdated Show resolved Hide resolved

chunhtai reviewed Jun 4, 2025

View reviewed changes

packages/flutter/lib/src/cupertino/dialog.dart Show resolved Hide resolved

rkishan516 and others added 5 commits June 11, 2025 20:28

Fix: Update mouse pointer behaviour for CupertinoDialogAction

8903431

Update packages/flutter/test/cupertino/dialog_test.dart

db0129c

Co-authored-by: Tong Mu <[email protected]>

Update packages/flutter/test/cupertino/dialog_test.dart

57de707

Co-authored-by: Tong Mu <[email protected]>

Update packages/flutter/lib/src/cupertino/dialog.dart

aa41845

Co-authored-by: chunhtai <[email protected]>

Style: Update formatting

9df806f

rkishan516 force-pushed the cupertino-dialog-action branch from 64a55d0 to 9df806f Compare June 11, 2025 15:00

Merge branch 'master' into cupertino-dialog-action

ac67cdc

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025

auto-submit bot added this pull request to the merge queue Jun 18, 2025

Merged via the queue into flutter:master with commit 5ecde8a Jun 18, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025

engine-flutter-autoroll mentioned this pull request Jun 19, 2025

Roll Flutter from 8303a96a0a99 to 44c6e065d777 (90 revisions) flutter/packages#9455

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

d564cc7

…tter#169051)

engine-flutter-autoroll mentioned this pull request Jun 19, 2025

Roll Flutter from 8303a96a0a99 to 2d383ad32e5d (91 revisions) flutter/packages#9456

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

d463161

…tter#169051)

engine-flutter-autoroll mentioned this pull request Jun 19, 2025

Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) flutter/packages#9457

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

c2ea871

…tter#169051)

Piinks mentioned this pull request Jul 19, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

ecd5a1a

…tter#169051)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

0b09c1c

…tter#169051)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

601d55a

…tter#169051)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

ab09b3a

…tter#169051)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

5ecde8a Feat: Add mouse cursor for CupertinoDialogAction (flutter/flu…

cd6df98

…tter#169051)

rkishan516 deleted the cupertino-dialog-action branch February 20, 2026 03:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Add mouse cursor for CupertinoDialogAction#169051

Feat: Add mouse cursor for CupertinoDialogAction#169051
auto-submit[bot] merged 6 commits intoflutter:masterfrom
rkishan516:cupertino-dialog-action

rkishan516 commented May 19, 2025 •

edited

Loading

Uh oh!

dkwingsmt commented May 22, 2025 •

edited

Loading

Uh oh!

rkishan516 commented May 22, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rkishan516 commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Technical Details

Related Issues

Pre-launch Checklist

Uh oh!

dkwingsmt commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rkishan516 commented May 22, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rkishan516 commented May 19, 2025 •

edited

Loading

dkwingsmt commented May 22, 2025 •

edited

Loading