Set text direction in semantics along with Directionality#16907
Merged
yjbanov merged 2 commits intoflutter:masterfrom Apr 25, 2018
Merged
Set text direction in semantics along with Directionality#16907yjbanov merged 2 commits intoflutter:masterfrom
yjbanov merged 2 commits intoflutter:masterfrom
Conversation
goderbauer
reviewed
Apr 24, 2018
Member
There was a problem hiding this comment.
Can you verify that this does not create a SemanticsNode which may gain a11y focus on Android and iOS?
Contributor
Author
There was a problem hiding this comment.
Done. We do add an extra node, but it does not seem to be focusable (at least I wasn't able to locate it by exploring the UI).
yjbanov
force-pushed
the
semantics-text-direction
branch
from
9cf16b2 to
4191436
Compare
Contributor
Author
|
PTAL. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16835