[flutter_tool] Remove unused environment flags in JS compiler by kevmoo · Pull Request #169097 · flutter/flutter

kevmoo · 2025-05-19T21:06:33Z

Removes things left over from refactoring in 5a9fa1e

kevmoo · 2025-05-20T15:41:29Z

packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart

-            Target target,
-            Environment environment,
-          ) {
-            expect(environment.defines, <String, String>{


run is not called above, so this section is NEVER called. I put in a throw. It's a no-op.

Ah that makes sense 😊

kevmoo · 2025-05-20T15:42:13Z

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

    'Dart2JSTarget calls dart2js with expected args with csp',
    () => testbed.run(() async {
      environment.defines[kBuildMode] = 'profile';
-      environment.defines[JsCompilerConfig.kCspMode] = 'true';


I searched for any reference to this const and below. No references anywhere in code (except tests). Never read.

kevmoo · 2025-05-20T15:42:33Z

packages/flutter_tools/lib/src/web/compiler_config.dart

    required WebRendererMode renderer,
  }) : this(nativeNullAssertions: nativeNullAssertions, renderer: renderer);

-  /// Build environment flag for [dumpInfo].


These variables are only ever referenced in tests. Deleting.

mdebbar

auto-submit · 2025-05-20T16:05:41Z

autosubmit label was removed for flutter/flutter/169097, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter#169007) This PR introduces two new widgets: - `DisableWidgetInspectorScope`, which hides its children from the widget inspector - `EnableWidgetInspectorScope`, which makes its children available to the widget inspector These widgets are used to inform the `WidgetInspectorService`'s `InspectorSerializationDelegate` when it should be omitting `DiagnosticableNodes` from the response when building the root widget tree for the inspector. This functionality is meant to be used by developer tooling and packages that want to prevent unnecessary implementation details from polluting the inspector and possibly confusing end users. This change also includes some minor updates to the Widget Preview scaffolding template to hide the scaffold's implementation details and only show details for the previews defined by the user. Part of flutter#166423 **Widget Previewer Demo** <img width="1606" alt="image" src="proxy.php?url=https://github.com/user-attachments/assets/eb23160e-01c5-413f-b1d2-97985ced9ef9" /> [flutter_tool] Remove unused environment flags in JS compiler (flutter#169097) Removes things left over from refactoring in flutter@5a9fa1e Add documentation for experimental branches, update artifacts. (flutter#169109) I still need to get the Firebase short URL, but PTAL. [native assets] Roll dependencies (flutter#169073) Roll deps to the ones released today. Fix the issue with Tooltip (flutter#168546) Fixes flutter#168545. Fixes flutter#168445. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Roll pub packages (flutter#169181) This PR was generated by `flutter update-packages --force-upgrade`. Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter#169156) This flag has been enabled by default for quite some time in `master`, and in the current `stable`. This is the first of many PRs to get rid of the flag and the deprecated code it is guarding. Fix dart format for asset.dart Fix an issue about tool_tests_general

…flutter/flutter#169097)

Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181) 2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

…flutter/flutter#169097)

[flutter_tool] Remove unused environment flags in JS compiler

2b2928b

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 19, 2025

kevmoo requested a review from mdebbar May 19, 2025 21:06

kevmoo commented May 20, 2025

View reviewed changes

mdebbar approved these changes May 20, 2025

View reviewed changes

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2025

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2025

auto-submit bot added this pull request to the merge queue May 20, 2025

jtmcdole removed this pull request from the merge queue due to the queue being cleared May 20, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2025

jtmcdole added this pull request to the merge queue May 20, 2025

Merged via the queue into flutter:master with commit b3130ee May 21, 2025
143 checks passed

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 61fe9b6b67c0 (55 revisions) flutter/packages#9299

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

650c809

…flutter/flutter#169097)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to dd671fae53d3 (56 revisions) flutter/packages#9301

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

1040830

…flutter/flutter#169097)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 534b250a562c (58 revisions) flutter/packages#9303

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

aca949a

…flutter/flutter#169097)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to f7354da75b27 (59 revisions) flutter/packages#9304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

f768bec

…flutter/flutter#169097)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/packages#9305

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

2200192

…flutter/flutter#169097)

kevmoo deleted the js_compile_config_cleanup branch May 22, 2025 17:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

4158689

…flutter/flutter#169097)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

285f2ad

…flutter/flutter#169097)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

72f86e0

…flutter/flutter#169097)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

365e8f0

…flutter/flutter#169097)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

b3130ee [flutter_tool] Remove unused environment flags in JS compiler (…

04256f3

…flutter/flutter#169097)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tool] Remove unused environment flags in JS compiler#169097

[flutter_tool] Remove unused environment flags in JS compiler#169097
jtmcdole merged 1 commit intoflutter:masterfrom
kevmoo:js_compile_config_cleanup

kevmoo commented May 19, 2025 •

edited

Loading

Uh oh!

kevmoo May 20, 2025

Uh oh!

mdebbar May 20, 2025

Uh oh!

kevmoo May 20, 2025

Uh oh!

kevmoo May 20, 2025

Uh oh!

mdebbar left a comment

Uh oh!

auto-submit bot commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kevmoo commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevmoo May 20, 2025

Choose a reason for hiding this comment

Uh oh!

mdebbar May 20, 2025

Choose a reason for hiding this comment

Uh oh!

kevmoo May 20, 2025

Choose a reason for hiding this comment

Uh oh!

kevmoo May 20, 2025

Choose a reason for hiding this comment

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kevmoo commented May 19, 2025 •

edited

Loading