Add Translate to iOS selection context menu by LouiseHsu · Pull Request #169150 · flutter/flutter

LouiseHsu · 2025-05-20T18:09:43Z

This PR adds a "Translate" action to the ios selection context menu using this swiftui translate api announce during WWDC 2024.
Includes the ipad implementation as well.
This is the first swiftui api in the engine so fingers crossed I don't break everything. 👀 😨

Simulator.Screen.Recording.-.iPad.Air.11-inch.M3.-.2025-05-28.at.14.11.58.mp4

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-05-28.at.14.09.13.mp4

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

hellohuanlin · 2025-05-28T23:50:32Z

haven't reviewed PR but the video looks so nice! How did you get the popover size on iPad working?

justinmc

Super cool to see swift in the engine. Thanks for supporting both the system context menu and the Flutter context menu. The framework code looks great

I checked this branch out locally and did a bunch of QA on it. Everything was very close to native with a few nits:

While the translate menu is up, the selection and handles should be grey, but they remain blue on this branch.
- This is definitely beyond the scope of this PR. I don't think we currently have an easy way to do this.
While the translate menu is up, the context menu should not be shown, but it is on this branch when using the Flutter-rendered context menu.
- It works using SystemContextMenu.
- Could you close the context menu on the framework side when the Translate button is tapped?
The "Replace with Translation" button is missing on this branch.
- Any idea if it's possible to support this?

If you can confirm any of these but can't fix them in this PR, can you open an issue to track them? These are pretty minor; I think it's probably ok to ship this feature without fixes for any of them..

justinmc · 2025-05-29T18:40:20Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm

+    FlutterTextInputPlugin* _textInputPlugin = [self.engine textInputPlugin];
+    UITextRange* range = _textInputPlugin.textInputView.selectedTextRange;
+
+    // firstRectForRange cannot be used here as it's current implementation does


"it's" => "its"

justinmc · 2025-05-29T18:41:57Z

packages/flutter/lib/src/widgets/context_menu_button_item.dart

  ///  * [LiveTextInputStatusNotifier], where the status of Live Text can be listened to.
  liveTextInput,

+  /// A button that displays the translation screen for the current text selection


Period at the end.

justinmc · 2025-05-29T18:54:54Z

packages/flutter/lib/src/widgets/editable_text.dart

+  Future<void> translateForSelection(SelectionChangedCause cause) async {
+    assert(!widget.obscureText);


Should we handle the case where this is called on a non-iOS platform? It's possible to call this directly without checking translateEnabled. Or what will happen if Translate.invoke is called on non-iOS?

Looks like we don't handle it in lookUpSelection etc. but maybe we should.

justinmc · 2025-05-29T18:56:13Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm

+    CGRect transformedLastRect = [(FlutterTextInputView*)_textInputPlugin.textInputView
+        localRectFromFrameworkTransform:lastRect];
+
+    // In case of RTL Language, get the minimum x coordinate too


Period at the end.

justinmc · 2025-05-29T20:42:19Z

packages/flutter/lib/src/widgets/system_context_menu.dart

+  @override
+  String toString() {
+    return 'IOSSystemContextMenuItemTranslate(title: $title)';
+  }


I think I made a mistake by adding these toString methods, I should have mixed in Diagnosticable and overridden debugFillProperties instead. Can you do that here, and I will open an issue for converting the rest of them?

flutter-dashboard · 2025-05-30T20:29:16Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 504065d.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 95A4:3D02A0:326CF:62CBC:683A151B.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:245:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1233:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1294:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1105:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompletion (package:cocoon_service/src/service/scheduler.dart:1038:9)
<asynchronous suspension>
#9      Scheduler.processCheckRun (package:cocoon_service/src/service/scheduler.dart:1378:9)
<asynchronous suspension>
#10     GithubWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/webhook_subscription.dart:115:24)
<asynchronous suspension>
#11     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#12     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#13     createServer.<anonymous closure> (package:cocoon_service/server.dart:317:7)
<asynchronous suspension>

justinmc · 2025-06-05T21:31:07Z

I assume this is not ready for re-review yet but feel free to tag me whenever it is.

LouiseHsu · 2025-06-05T21:33:01Z

I assume this is not ready for re-review yet but feel free to tag me whenever it is.

Sorry, Im getting some accessibility tree failures that will take some time to dig into, but Im occupied with something else at the moment. 😿 Im gonna put this back into draft to get it off your queue

flutter-dashboard · 2025-06-05T21:33:36Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks · 2025-08-05T22:42:01Z

Greetings from stale PR triage! 👋
Do you still have plans for this PR @LouiseHsu?

Piinks · 2025-11-17T22:46:50Z

Greetings once more from stale RP triage! Should we close this? It has many conflicts now and has not been updated since the last visit to triage.

LouiseHsu · 2025-11-17T22:49:04Z

Greetings once more from stale RP triage! Should we close this? It has many conflicts now and has not been updated since the last visit to triage.

I will close it - Im planning on revisiting this next month but probably will open a new PR to avoid the 100000000 merge conflicts.

LouiseHsu added 4 commits May 14, 2025 14:17

swift ui is showing up

0439342

translation screen pops up

68c8903

push

30143ef

format

78ee08e

LouiseHsu and others added 10 commits May 20, 2025 16:47

lfg it works end to end

ec84de7

format

37689e6

test?

5326d38

framework tests

3897dca

Merge branch 'master' into translate-api

5f0976c

translations

41b4c21

format

fbfbb68

ipad implementation, formating, blah

7d18413

white space n stuff

d5240a8

FORMATTTT

7279078

LouiseHsu changed the title ~~Translate api~~ Add Translate to iOS selection context menu May 28, 2025

LouiseHsu marked this pull request as ready for review May 28, 2025 21:16

LouiseHsu requested a review from a team as a code owner May 28, 2025 21:16

LouiseHsu requested a review from justinmc May 28, 2025 21:16

widget translations

86fa732

justinmc reviewed May 29, 2025

View reviewed changes

justinmc mentioned this pull request May 29, 2025

IOSSystemContextMenuItem should use Diagnosticable instead of toString #169696

Closed

LouiseHsu and others added 3 commits May 29, 2025 16:08

Merge branch 'master' into translate-api

d4403d6

Merge branch 'master' into translate-api

992ab7c

fix some tests

504065d

github-actions bot added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label May 30, 2025

dkwingsmt requested a review from justinmc June 4, 2025 18:45

LouiseHsu marked this pull request as draft June 5, 2025 21:33

justinmc removed their request for review September 17, 2025 22:34

LouiseHsu closed this Nov 17, 2025

		Future<void> translateForSelection(SelectionChangedCause cause) async {
		assert(!widget.obscureText);

Conversation

LouiseHsu commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hellohuanlin commented May 28, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc May 29, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc May 29, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc May 29, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc May 29, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc May 29, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc May 29, 2025

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented May 30, 2025

Uh oh!

justinmc commented Jun 5, 2025

Uh oh!

LouiseHsu commented Jun 5, 2025

Uh oh!

flutter-dashboard bot commented Jun 5, 2025

Uh oh!

Piinks commented Aug 5, 2025

Uh oh!

Piinks commented Nov 17, 2025

Uh oh!

LouiseHsu commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LouiseHsu commented May 20, 2025 •

edited

Loading