[native assets] Graduate to preview by dcharkes · Pull Request #169194 · flutter/flutter

dcharkes · 2025-05-21T07:49:09Z

This PR enables native assets on the main and dev channel by default, and make native assets available on the beta channel.

This PR removes the flag from invocations.

The helper packages (package:hooks and package:code_assets) will stay 0.x for now, until the SDK constraint can be bumped to a beta release and we're happy with the Dart API.

Corresponding Dart CL: https://dart-review.googlesource.com/c/sdk/+/429920

Issue:

☂️ Build hooks & Code assets #129757

Project: Native Assets

goderbauer

LGTM

mkustermann

A few comments

a) Would it make sense to print a Note: You are using the dart build hooks feature which is currently in preview, .... notice in the flutter run/build/test commands if the build uses native assets?
b) I still see implementation code such as if (environment.defines[kNativeAssets] == false) { ... }, if (!buildNativeAssets) kNativeAssets: 'false', ... - does this need to be cleaned up now?

mkustermann

lgtm modulo comments

dcharkes · 2025-05-21T10:11:14Z

a) Would it make sense to print a Note: You are using the dart build hooks feature which is currently in preview, .... notice in the flutter run/build/test commands if the build uses native assets?

👍

b) I still see implementation code such as if (environment.defines[kNativeAssets] == false) { ... }, if (!buildNativeAssets) kNativeAssets: 'false', ... - does this need to be cleaned up now?

We're defaulting the flag to true in this PR, not removing it. Users can still do flutter config --no-enable-native-assets.

mkustermann · 2025-05-21T11:39:58Z

packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart

+    globals.logger.printTrace(
+      'Note: You are using the dart build hooks feature which is currently '
+      'in preview. Please see '
+      'https://github.com/flutter/flutter/issues/129757 for more details.',


Why not link to dart.dev landing page (which we probably want to keep long term to describe this feature) - it's not flutter specific.

auto-submit · 2025-05-21T15:23:48Z

autosubmit label was removed for flutter/flutter/169194, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Flutter from 9a78af5 to 33cdd8e (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181) 2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

[native assets] Graduate to preview

76fd278

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels May 21, 2025

dcharkes added 3 commits May 21, 2025 11:30

fix analysis

856437d

fix tests

0dccbce

fix test

598ebae

dcharkes requested review from goderbauer and mkustermann May 21, 2025 09:56

dcharkes marked this pull request as ready for review May 21, 2025 09:56

dcharkes requested review from a team and matanlurey as code owners May 21, 2025 09:56

goderbauer approved these changes May 21, 2025

View reviewed changes

mkustermann reviewed May 21, 2025

View reviewed changes

mkustermann approved these changes May 21, 2025

View reviewed changes

add a preview note if the build hooks outputted something

c97e524

mkustermann reviewed May 21, 2025

View reviewed changes

change link

5449acf

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

try reverting file that's failing to patch in g3 roll

f6c03a8

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

matanlurey approved these changes May 21, 2025

View reviewed changes

auto-submit bot added this pull request to the merge queue May 21, 2025

Merged via the queue into master with commit 534b250 May 21, 2025
155 checks passed

auto-submit bot deleted the native-assets-preview branch May 21, 2025 17:26

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 534b250a562c (58 revisions) flutter/packages#9303

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

aa590d0

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to f7354da75b27 (59 revisions) flutter/packages#9304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

791810b

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/packages#9305

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

279a4d4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

0872102

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

053a894

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

4af31a9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

0e90dd9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

534b250 [native assets] Graduate to preview (flutter/flutter#169194)

bbc2966

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[native assets] Graduate to preview#169194

[native assets] Graduate to preview#169194
auto-submit[bot] merged 7 commits intomasterfrom
native-assets-preview

dcharkes commented May 21, 2025 •

edited

Loading

Uh oh!

goderbauer left a comment

Uh oh!

mkustermann left a comment

Uh oh!

mkustermann left a comment

Uh oh!

dcharkes commented May 21, 2025

Uh oh!

mkustermann May 21, 2025 •

edited

Loading

Uh oh!

auto-submit bot commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dcharkes commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

mkustermann left a comment

Choose a reason for hiding this comment

Uh oh!

mkustermann left a comment

Choose a reason for hiding this comment

Uh oh!

dcharkes commented May 21, 2025

Uh oh!

mkustermann May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dcharkes commented May 21, 2025 •

edited

Loading

mkustermann May 21, 2025 •

edited

Loading