Skip to content

[Impeller] Directly tessellate arc operations#169402

Merged
jtmcdole merged 3 commits intoflutter:masterfrom
flar:impeller-direct-arc-tessellation
May 30, 2025
Merged

[Impeller] Directly tessellate arc operations#169402
jtmcdole merged 3 commits intoflutter:masterfrom
flar:impeller-direct-arc-tessellation

Conversation

@flar
Copy link
Contributor

@flar flar commented May 24, 2025

Currently arcs are rendered by creating/allocating a Path and using the path rendering code. We now directly tessellate most arcs (all filled arcs and any stroked arcs that avoid "use_center" and "round caps") using the most efficient mechanism to place the necessary vertices into the host buffers.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 24, 2025
@flar flar mentioned this pull request May 23, 2025
Closed
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 24, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169402 at sha 8f6ab19

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label May 24, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 30, 2025

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169402 at sha b5bb137

@flar
Copy link
Contributor Author

flar commented May 30, 2025

The goldens are now down to the usual curve edge variations with no mistakes that I could see. Ready for review.

@flar flar requested review from gaaclarke and jonahwilliams May 30, 2025 01:59
jonahwilliams
jonahwilliams approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 30, 2025
@jtmcdole jtmcdole removed this pull request from the merge queue due to a manual request May 30, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@jtmcdole
Copy link
Member

jtmcdole commented May 30, 2025

We're experiencing some issues with secondary github quota; this never started in the Queue - re-inserting it.

@jtmcdole jtmcdole added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 1709d3a May 30, 2025
181 of 182 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
0570a4b 
…r#169402)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
254a47b 
…r#169402)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
e28c201 
…r#169402)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
a5ae32d 
…r#169402)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
c0fa473 
…r#169402)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
b79ac21 
…r#169402)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
38e8756 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
c574553 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
c27cc69 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
ad4edc2 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
06a6177 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
a07d954 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
34659e6 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
037c098 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
c9e2289 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
2a3846d 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
d4a14cf 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
cde7462 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
c49671f 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
eed8ca4 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
d6b7d69 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
0e3e7fa 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
5b1fb41 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
6646b75 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
d2f72b7 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
2c297ca 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
bec4a80 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
fc4ed66 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
7721633 
…r#169402)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
1709d3a [Impeller] Directly tessellate arc operations (flutter/flutte…
b651301 
…r#169402)
@b-luk b-luk mentioned this pull request Nov 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flar @jtmcdole @jonahwilliams