Skip to content

Re-enable SelectableRegion web tests#169541

Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom
Renzo-Olivares:enable-selectionarea-web-test
May 29, 2025
Merged

Re-enable SelectableRegion web tests#169541
auto-submit[bot] merged 4 commits intoflutter:masterfrom
Renzo-Olivares:enable-selectionarea-web-test

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented May 27, 2025 •
edited
Loading

This change re-enables some SelectableRegion tests now that #125582 has been closed.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels May 27, 2025
@Renzo-Olivares Renzo-Olivares requested a review from chunhtai May 27, 2025 23:11
@Renzo-Olivares Renzo-Olivares force-pushed the enable-selectionarea-web-test branch from 8f90e85 to a9c302a Compare May 28, 2025 18:12
chunhtai
chunhtai approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 29, 2025
Merged via the queue into flutter:master with commit c6fe412 May 29, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
95cfaf7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
e368826
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
5fc9878
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
b4451de
This was referenced May 30, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
f7aad45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
1ae741a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
644919d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
0327909
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
96cc25d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
ec64fc8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
6ab2ca8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
84b4d4c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
3651784
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
f77ddf8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
a3004ff
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
79865f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
39fe098
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
96e1fce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
91db02f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
9a6ee6d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
86ebf7f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
a51f753
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
dda570a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
29bd21e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
702cd4d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
bf0cd57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
c0eb797
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
8ceeaa2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
a0901cf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
8423ba0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
4d7913d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
96157fe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
ec5099e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
f5d0c27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
53da3a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
378115b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c6fe412 Re-enable SelectableRegion web tests (flutter/flutter#169541)
7942209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @chunhtai