[Impeller] acquire the gpu sync switch when flush stored GPU tasks. by jonahwilliams · Pull Request #169596 · flutter/flutter

jonahwilliams · 2025-05-28T16:18:22Z

Potential fix for #166668

See:

https://github.com/flutter/flutter/blob/master/engine/src/flutter/impeller/renderer/backend/metal/context_mtl.mm#L429
flutter/engine/src/flutter/fml/synchronization/sync_switch.cc

Line 41 in 5d013c7

observer->OnSyncSwitchUpdate(value);

We don't hold the sync switch lock when we flush tasks. So if we start flushing then immediately go to the background, then we might execute while backgrounded.

gaaclarke

This approach is looking good to me.

gaaclarke · 2025-05-28T16:40:57Z

engine/src/flutter/impeller/renderer/backend/metal/context_mtl.mm

+            for (const auto& task : tasks_awaiting_gpu) {
+              task.task();
+            }


Do you think we should acquire the lock inside the loop? My concern is that if this takes too much time the OS might kill the process.

hmm, yeah that is a good point.

gaaclarke

lgtm!

…tasks. (flutter/flutter#169596)

zanderso · 2025-06-12T19:54:45Z

@jonahwilliams The internal customer is reporting that after this change, the images still briefly show up as pink before loading in correctly. Does that sound plausible?

jonahwilliams · 2025-06-12T21:10:57Z

We can do #169378 too.

the images still briefly show up as pink before loading in correctly. Does that sound plausible?

There is no automated retry built into this system, likely they have some business logic that is refreshing the images which covers up the images that were incorrectly decoded.

…lutter#169596) Potential fix for flutter#166668 See: * https://github.com/flutter/flutter/blob/master/engine/src/flutter/impeller/renderer/backend/metal/context_mtl.mm#L429 * https://github.com/flutter/flutter/blob/5d013c73baa70a8b3e1c541cb63e4c22654aa3cc/engine/src/flutter/fml/synchronization/sync_switch.cc#L41 We don't hold the sync switch lock when we flush tasks. So if we start flushing then immediately go to the background, then we might execute while backgrounded.

Includes: * #169596 * #169378 Fix image decode errors on iOS that could occur if a push notification triggered image decoding while the app is backgrounded.

Includes: * flutter/flutter#169596 * flutter/flutter#169378 Fix image decode errors on iOS that could occur if a push notification triggered image decoding while the app is backgrounded.

…tasks. (flutter/flutter#169596)

jonahwilliams added 2 commits May 28, 2025 09:01

[Impeller] hold sync switch while flushing tasks.

1c90f84

add testing.

529ecd9

jonahwilliams requested a review from gaaclarke May 28, 2025 16:18

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 28, 2025

gaaclarke reviewed May 28, 2025

View reviewed changes

jonahwilliams added 2 commits May 28, 2025 10:05

flush per task.

ce948ba

++

5a1483c

gaaclarke approved these changes May 28, 2025

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025

auto-submit bot added this pull request to the merge queue May 28, 2025

Merged via the queue into flutter:master with commit af3627a May 29, 2025
180 of 181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to 8b18dde77fa5 (16 revisions) flutter/packages#9335

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

0dde13c

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

9af0f19

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to fdc8c20d0d68 (19 revisions) flutter/packages#9336

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

1aabf60

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to f582fcbb0418 (20 revisions) flutter/packages#9337

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

5ab5dab

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to 2a821a70de86 (21 revisions) flutter/packages#9338

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

043565a

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to 0d349d78431a (22 revisions) flutter/packages#9339

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

40a03e2

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 29, 2025

Roll Flutter from 0e536eb9fe4b to ae11f77f20ff (25 revisions) flutter/packages#9340

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

1234b25

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 30, 2025

Roll Flutter from 0e536eb9fe4b to 8132e1828561 (46 revisions) flutter/packages#9343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

1db8329

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll mentioned this pull request May 30, 2025

Roll Flutter from 0e536eb9fe4b to 0b02682934ef (47 revisions) flutter/packages#9344

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

1191dfc

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

3dfb408

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

3b4ea7e

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

639068d

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

aed410d

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

514c022

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

00fec18

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

e96cce7

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

2d4efb9

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

8e45088

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

25d099f

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

63f09e6

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

6047f63

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

11ffb3a

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

f5a52e7

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

c3d7203

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

6381dce

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

4c04c1e

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

01146d7

…tasks. (flutter/flutter#169596)

jonahwilliams mentioned this pull request Jun 18, 2025

[CP] Fix pink images when returning from background on iOS #170846

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

0278717

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

e54aad0

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

7dc0cdb

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

7ca2b21

…tasks. (flutter/flutter#169596)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

af3627a [Impeller] acquire the gpu sync switch when flush stored GPU …

d27d1d3

…tasks. (flutter/flutter#169596)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Impeller] acquire the gpu sync switch when flush stored GPU tasks.#169596

[Impeller] acquire the gpu sync switch when flush stored GPU tasks.#169596
auto-submit[bot] merged 4 commits intoflutter:masterfrom
jonahwilliams:flush_correctly

jonahwilliams commented May 28, 2025

Uh oh!

gaaclarke left a comment

Uh oh!

gaaclarke May 28, 2025

Uh oh!

jonahwilliams May 28, 2025

Uh oh!

jonahwilliams May 28, 2025

Uh oh!

gaaclarke left a comment

Uh oh!

Uh oh!

zanderso commented Jun 12, 2025

Uh oh!

jonahwilliams commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jonahwilliams commented May 28, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke May 28, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams May 28, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams May 28, 2025

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zanderso commented Jun 12, 2025

Uh oh!

jonahwilliams commented Jun 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants