[Impeller] let drawImage nine use porter duff optimization. by jonahwilliams · Pull Request #169611 · flutter/flutter

jonahwilliams · 2025-05-28T19:01:22Z

Currently we apply a color filter nine times for the drawImageNine calls, which is very expensive. We can do the same porterduff optimization we did for flame for drawImage nine by allowing the porter duff shader to specify a strict src rect.

Before

After

gaaclarke

Looking good, just needs cleaned up documentation.

gaaclarke · 2025-05-29T15:35:04Z

engine/src/flutter/impeller/entity/shaders/blending/porter_duff_blend.frag

-  float16_t output_alpha;
-  float tmx;
-  float tmy;
+  vec4 ai_ao_tmx_tmy;


This needs a docstring.

gaaclarke · 2025-05-29T15:35:54Z

engine/src/flutter/impeller/entity/shaders/blending/porter_duff_blend.frag

+float tmx = frag_info.ai_ao_tmx_tmy.z;
+float tmy = frag_info.ai_ao_tmx_tmy.w;


No abbreviations: https://google.github.io/styleguide/cppguide.html#General_Naming_Rules

This isn't C++ :)

Oh I forgot, the glsl style guide says abbreviate everything. Nevermind, change everything else then.

(do you get the joke, I used an abbreviation to respond to you)

(also yes, I will change this :) )

Sorry, I was actually talking about the tmx, tmy variables. The packed one was unfortunate but I figured the docstring would help.

- float tmx = frag_info.ai_ao_tmx_tmy.z; - float tmy = frag_info.ai_ao_tmx_tmy.w; + vec2 tileMode = vec2(frag_info.ai_ao_tmx_tmy.z, frag_info.ai_ao_tmx_tmy.w);

engine/src/flutter/impeller/entity/shaders/blending/porter_duff_blend.frag

gaaclarke · 2025-05-29T15:39:45Z

engine/src/flutter/impeller/entity/contents/atlas_contents.h


  virtual bool ShouldInvertBlendMode() const { return true; }
+
+  virtual std::optional<Rect> GetStrictSrcRect() const { return std::nullopt; }


Docstring please, just add a "see also" that points to the definition of strict source rects.

gaaclarke · 2025-05-29T16:26:53Z

engine/src/flutter/impeller/entity/shaders/blending/porter_duff_blend.frag

+float tmx = frag_info.ai_ao_tmx_tmy.z;
+float tmy = frag_info.ai_ao_tmx_tmy.w;


Sorry, I was actually talking about the tmx, tmy variables. The packed one was unfortunate but I figured the docstring would help.

- float tmx = frag_info.ai_ao_tmx_tmy.z; - float tmy = frag_info.ai_ao_tmx_tmy.w; + vec2 tileMode = vec2(frag_info.ai_ao_tmx_tmy.z, frag_info.ai_ao_tmx_tmy.w);

gaaclarke · 2025-05-29T16:27:27Z

engine/src/flutter/impeller/entity/contents/atlas_contents.h


  virtual bool ShouldInvertBlendMode() const { return true; }
+
+  /// @brief the source rect of the draw if a strict source rect should


Suggested change

/// @brief the source rect of the draw if a strict source rect should

/// @brief The source rect of the draw if a strict source rect should

gaaclarke

LGTM modulo the tilemode abbreviation.

…lutter/flutter#169611)

[Impeller] let drawImage nine use porter duff optimization.

17555bb

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 28, 2025

jonahwilliams mentioned this pull request May 28, 2025

Performance drops on Android on simple widgets #169492

Closed

jonahwilliams added 2 commits May 28, 2025 12:33

actually use computed vec

dc84789

malioc diff.

3549d97

jonahwilliams marked this pull request as ready for review May 28, 2025 22:15

This comment was marked as off-topic.

Sign in to view

flutter-dashboard bot added the will affect goldens Changes to golden files label May 28, 2025

fix default value.

72c4a4e

jonahwilliams requested review from gaaclarke and jason-simmons May 29, 2025 15:23

gaaclarke reviewed May 29, 2025

View reviewed changes

aaron review.

1e0b5c5

jonahwilliams requested a review from gaaclarke May 29, 2025 16:18

gaaclarke reviewed May 29, 2025

View reviewed changes

gaaclarke approved these changes May 29, 2025

View reviewed changes

de-abbrev.

5518445

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

auto-submit bot added this pull request to the merge queue May 29, 2025

Merged via the queue into flutter:master with commit 7e99b7f May 29, 2025
181 of 182 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025

engine-flutter-autoroll mentioned this pull request May 30, 2025

Roll Flutter from 0e536eb9fe4b to 8132e1828561 (46 revisions) flutter/packages#9343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

704b414

…lutter/flutter#169611)

engine-flutter-autoroll mentioned this pull request May 30, 2025

Roll Flutter from 0e536eb9fe4b to 0b02682934ef (47 revisions) flutter/packages#9344

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

3aa166f

…lutter/flutter#169611)

engine-flutter-autoroll mentioned this pull request May 30, 2025

Roll Flutter from 0e536eb9fe4b to 088d1bd62a21 (48 revisions) flutter/packages#9345

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

44c8767

…lutter/flutter#169611)

engine-flutter-autoroll mentioned this pull request May 30, 2025

Roll Flutter from 0e536eb9fe4b to d8baa77b3846 (49 revisions) flutter/packages#9346

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

b822e76

…lutter/flutter#169611)

engine-flutter-autoroll mentioned this pull request Jun 2, 2025

Roll Flutter from 0e536eb9fe4b to ff2184fc8ab2 (70 revisions) flutter/packages#9358

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

51581bf

…lutter/flutter#169611)

engine-flutter-autoroll mentioned this pull request Jun 2, 2025

Roll Flutter from 0e536eb9fe4b to 269eaa45216d (71 revisions) flutter/packages#9359

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

3b7de1f

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

6397522

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

61bde70

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

67d786f

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

c654308

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

16c4680

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

e70d0de

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

ac56c70

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

c69aa89

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

1514beb

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

b0d031b

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

481dd5a

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

df14b35

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

9454c34

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

9420305

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

8e407ee

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

022fac5

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

48565e8

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

a9d383f

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

248cf9a

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

24b3ef0

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

c169de1

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

879f9d0

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

3182088

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

99d1ccb

…lutter/flutter#169611)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

7e99b7f [Impeller] let drawImage nine use porter duff optimization. (f…

4a2cde9

…lutter/flutter#169611)

		float tmx = frag_info.ai_ao_tmx_tmy.z;
		float tmy = frag_info.ai_ao_tmx_tmy.w;


		virtual bool ShouldInvertBlendMode() const { return true; }

		virtual std::optional<Rect> GetStrictSrcRect() const { return std::nullopt; }


		virtual bool ShouldInvertBlendMode() const { return true; }

		/// @brief the source rect of the draw if a strict source rect should

Conversation

jonahwilliams commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

This comment was marked as off-topic.

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jonahwilliams commented May 28, 2025 •

edited

Loading