[tests] Increase linux timeout and skip on others#169627
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom May 29, 2025
Merged
[tests] Increase linux timeout and skip on others#169627auto-submit[bot] merged 3 commits intoflutter:masterfrom
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
With this change the web.shard test suite runs all existing tests on all platforms with the version of the web debug builds that is the flutter tools default (does not support stateful hot reload). The linux bot configuration will also run some of the tests using the new web debug build (supports stateful hot reload). The timeout has been increased for this configuration to allow the additional tests to run to completion. The mac and windows configurations skip all tests for the new web debug builds. In the future the new build output will become the flutter tools default and the balance of where the tests tests are run will flip until the ability to opt out of the new build output is removed. This change is not ideal because we are still not fully testing all features with the two versions of the web debug builds that are available to users. If given the opportunity we should add additional bot configurations to run all the tests with the output that supports stateful hot reload. Fixes: flutter#169304
github-actions
bot
added
the
tool
mdebbar
reviewed
May 29, 2025
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| @TestOn('linux') // https://github.com/flutter/flutter/issues/169304 |
Contributor
There was a problem hiding this comment.
This file, and the ones below, have been running on all platforms for a while and not causing timeouts. Should we keep them that way if there's value in running them on different platforms?
Contributor
Author
There was a problem hiding this comment.
I would prefer to run more tests on all platforms but my understanding from the discussion on #169304 was that the timeouts were increased for the mac and windows configurations and they also have the least amount of resources available. To find a middle ground during this period where we have two separate modes to test I thought we could avoid running tests of the non-default settings on all platforms.
packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart
Show resolved
Hide resolved
nshahan
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
salemiranloye
pushed a commit
to salemiranloye/flutter
that referenced
this pull request
May 29, 2025
With this change the web.shard test suite runs all existing tests on all platforms with the version of the web debug builds that is the flutter tools default (does not support stateful hot reload). The linux bot configuration will also run some of the tests using the new web debug build (supports stateful hot reload). The timeout has been increased for this configuration to allow the additional tests to run to completion. The mac and windows configurations skip all tests for the new web debug builds. In the future the new build output will become the flutter tools default and the balance of where the tests tests are run will flip until the ability to opt out of the new build output is removed. This change is not ideal because we are still not fully testing all features with the two versions of the web debug builds that are available to users. If given the opportunity we should add additional bot configurations to run all the tests with the output that supports stateful hot reload. Fixes: flutter#169304 Issue: flutter#169634
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2025
This was referenced May 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change the web.shard test suite runs all existing tests on all platforms with the version of the web debug builds that is the flutter tools default (does not support stateful hot reload).
The linux bot configuration will also run some of the tests using the new web debug build (supports stateful hot reload). The timeout has been increased for this configuration to allow the additional tests to run to completion.
The mac and windows configurations skip all tests for the new web debug builds.
In the future the new build output will become the flutter tools default and the balance of where the tests tests are run will flip until the ability to opt out of the new build output is removed.
This change is not ideal because we are still not fully testing all features with the two versions of the web debug builds that are available to users. If given the opportunity we should add additional bot configurations to run all the tests with the output that supports stateful hot reload.
Fixes: #169304
Issue: #169634