Skip to content

feat: experimental tool tests workflow (attempt 2)#169768

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jtmcdole:updateToolsTestWorkflow
May 30, 2025
Merged

feat: experimental tool tests workflow (attempt 2)#169768
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jtmcdole:updateToolsTestWorkflow

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented May 30, 2025 •
edited
Loading

  • remote repo: set upstream and get tags (flutter tool reqs)
  • pull request to flutter: checkout the PR, not the merge commit
  • local runs: update utils.dart to safely call terminal width

Now act -W .github/workflows/tool-test-general.yml works locally on the command line.

Future improvements:

  • Offer another way to set the "version" rather than tags; this causes a longer checkout time.
  • Multi-proc the tests and use as many cores as possible?
  • Solve for packages downloading?

3.5 minutes isn't terrible.

@jtmcdole jtmcdole requested a review from matanlurey as a code owner May 30, 2025 16:59
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@jtmcdole jtmcdole requested a review from zanderso May 30, 2025 17:06
@jtmcdole jtmcdole changed the title fix: update experiment to work in different conditions fix: update tool workflow experiment for different conditions May 30, 2025
@zanderso
Copy link
Member

zanderso commented May 30, 2025

@jason-simmons is reverting #169706 as it's blocking the Dart rolls. @jtmcdole you are OOO today, so let's go with the revert and pick this up again on Monday =)

@jtmcdole
Copy link
Member Author

jtmcdole commented May 30, 2025 •
edited
Loading

@jason-simmons is reverting #169706 as it's blocking the Dart rolls. @jtmcdole you are OOO today, so let's go with the revert and pick this up again on Monday =)

Ah, this would have fixed it, but makes sense. I can just rebase after the revert and it should work on Monday

@auto-submit
Copy link
Contributor

auto-submit bot commented May 30, 2025

autosubmit label was removed for flutter/flutter/169768, because Pull request flutter/flutter/169768 is not in a mergeable state.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
jtmcdole added 2 commits May 30, 2025 13:53
@jtmcdole
feat: update experiment to work in different conditions
98ca270 
 - remote repo: set upstream and get tags (flutter tool reqs)
 - pull request to flutter: checkout the PR, not the merge commit
 - local runs: update utils.dart to safely call terminal width

Now `act -W .github/workflows/tool-test-general.yml` works locally on
the command line.
@jtmcdole
better task names for checkout paths
fd87ec7
@jtmcdole jtmcdole force-pushed the updateToolsTestWorkflow branch from 6d772ac to fd87ec7 Compare May 30, 2025 20:54
@jtmcdole
Copy link
Member Author

jtmcdole commented May 30, 2025

@zanderso - rebased after the revert - you can see the tests passes (hint to future self: always add the workflow to the paths: to see it working)

@jtmcdole jtmcdole changed the title fix: update tool workflow experiment for different conditions feat: experimental tool tests workflow (attempt 2) May 30, 2025
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 30, 2025
Merged via the queue into flutter:master with commit 1946081 May 30, 2025
150 of 151 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
d940d7d 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
78948af 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
15cc19e 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
47dd31f 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
ed0de6e 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
d8036ec 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
cd3b037 
…lutter#169768)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
a2015d2 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
45894cd 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
47867e8 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
6b21416 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
931353a 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
bc82c0f 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
167ea29 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
63f9047 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
42c5e6f 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
c5a6dbf 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
a77a791 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
43fd6ad 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
60fb1f1 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
c985104 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
b212ed6 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
42815d0 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
2df00ca 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
e937ef9 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
f921375 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
20c9340 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
9c17c82 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
8e83564 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
3aec70e 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
09f0ae8 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
d62a118 
…lutter#169768)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
1946081 feat: experimental tool tests workflow (attempt 2) (flutter/f…
8bc3839 
…lutter#169768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtmcdole @zanderso @matanlurey