Move android_obfuscate_test from devicelab into tools integration.shard by jmagman · Pull Request #169798 · flutter/flutter

jmagman · 2025-05-30T23:12:41Z

android_obfuscate_test is currently being schedule to run on a limited devicelab physical phone bot. However, it's only checking if --obfuscate works, not running anything on the device, so can move into the tools test integration shard.

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20android_obfuscate_test/7722/overview

The test only takes < 2 minutes, spinning up an entire build for it, especially on a devicelab bot, is wasteful.

Similar to #80161

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2025-05-30T23:13:25Z

packages/flutter_tools/test/integration.shard/android_obfuscate_test.dart

+}
+
+bool _containsSymbol(File outputArchive, String libappPath, String symbol) {
+  final Archive archive = ZipDecoder().decodeBytes(outputArchive.readAsBytesSync());


A better version of

flutter/packages/flutter_tools/test/host_cross_arch.shard/ios_content_validation_test.dart

Lines 278 to 298 in 11bf180

testWithoutContext('validate obfuscation', () {

// HelloPlugin class is present in project.

ProcessResult grepResult = processManager.runSync(<String>[

'grep',

'-r',

'HelloPlugin',

pluginRoot.path,

]);

// Matches exits 0.

expect(grepResult.exitCode, 0);

// Not present in binary.

grepResult = processManager.runSync(<String>[

'grep',

'HelloPlugin',

outputAppFrameworkBinary.path,

]);

// Does not match exits 1.

expect(grepResult.exitCode, 1);

});

});

Inspired by

flutter/packages/flutter_tools/test/integration.shard/deferred_components_test.dart

Lines 61 to 65 in 11bf180

final Archive archive = ZipDecoder().decodeBytes(outputFile.readAsBytesSync());

expect(archive.findFile('base/lib/arm64-v8a/libapp.so') != null, true);

expect(archive.findFile('base/lib/arm64-v8a/libflutter.so') != null, true);

expect(archive.findFile('component1/lib/arm64-v8a/libapp.so-2.part.so') != null, true);

jmagman · 2025-05-30T23:13:54Z

packages/flutter_tools/test/integration.shard/android_obfuscate_test.dart

+      'build',
+      'apk',
+      '--target-platform=android-arm',
+      '--obfuscate',


I confirmed both of these tests fail with --no-obfuscate passed instead.

jmagman · 2025-05-30T23:15:24Z

dev/devicelab/bin/tasks/android_obfuscate_test.dart


 Future<void> main() async {
+  // This test has moved to packages/flutter_tools/test/integration.shard/android_obfuscate_test.dart.
+  // TODO(jmagman): Remove this file once the infra repo no longer contains "Linux_pixel_7pro android_obfuscate_test".


I'm unsure if this extra step is necessary, or I can remove this file in the same PR.

jmagman · 2025-06-25T20:05:01Z

Moving this to a draft, @gmackall was working in here and I need to fix merge conflicts.

flutter-dashboard · 2025-06-25T20:05:22Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman · 2025-07-25T19:25:56Z

Was conflicted with #171165 adding stack traces to devicelab tests, which we won't need any more when it's moved to the integration test.

…tion.shard (flutter/flutter#169798)

Roll Flutter from c3279ca to 871849e (56 revisions) flutter/flutter@c3279ca...871849e 2025-08-01 [email protected] Roll Dart SDK from 6832e04cf2f9 to 6e1bb159c860 (8 revisions) (flutter/flutter#173119) 2025-08-01 [email protected] Add `--profile-startup` flag to `flutter run` (flutter/flutter#172990) 2025-08-01 [email protected] Add `side` to `RadioThemeData` (flutter/flutter#171945) 2025-08-01 [email protected] Update GCA instructions (flutter/flutter#173001) 2025-08-01 [email protected] [engine] Null aware elements clean-ups (flutter/flutter#173075) 2025-08-01 [email protected] Roll Packages from db6988d to f0645d8 (3 revisions) (flutter/flutter#173111) 2025-08-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch 3 (#173063)" (flutter/flutter#173113) 2025-08-01 [email protected] Update embedder API CODEOWNERS (flutter/flutter#173081) 2025-08-01 [email protected] Move android_obfuscate_test from devicelab into tools integration.shard (flutter/flutter#169798) 2025-08-01 [email protected] [A11y] RangeSlider should have 2 focus node (flutter/flutter#172729) 2025-07-31 [email protected] Upload the linux arm64 embedder to cloud buckets. (flutter/flutter#173068) 2025-07-31 [email protected] Reland licenses cpp switch 3 (flutter/flutter#173063) 2025-07-31 [email protected] [ Tool ] Mark IOOverrides subclasses as `final` (flutter/flutter#173078) 2025-07-31 [email protected] [macOS] Remove duplicate object initialization (flutter/flutter#171767) 2025-07-31 [email protected] Redistribute Android test owners (flutter/flutter#172886) 2025-07-31 [email protected] Avoid negatives in the styleguide.md (flutter/flutter#172917) 2025-07-31 [email protected] Roll Skia from 42e3bed42110 to 49e39cd3cf18 (7 revisions) (flutter/flutter#173069) 2025-07-31 [email protected] Fix the issue where calling showOnScreen on a sliver after a pinned child in SliverMainAxisGroup does not reveal it. (flutter/flutter#171339) 2025-07-31 [email protected] Improve assertion message in `EdgeInsetsDirectional.resolve` (flutter/flutter#172099) 2025-07-31 [email protected] licenses_cpp: Switched to lexically_relative for 2x speed boost. (flutter/flutter#173048) 2025-07-31 [email protected] Add dartvm to the dart_sdk_entitlement_config list. (flutter/flutter#173044) 2025-07-31 [email protected] [web] ClickDebouncer workaround for iOS Safari click behavior (flutter/flutter#172995) 2025-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch 2 (#172996)" (flutter/flutter#173059) 2025-07-31 [email protected] [web] Text editing test accepts both behaviors in Firefox (flutter/flutter#172767) 2025-07-31 [email protected] Reland licenses cpp switch 2 (flutter/flutter#172996) 2025-07-31 [email protected] Roll Packages from d914120 to db6988d (2 revisions) (flutter/flutter#173039) 2025-07-31 [email protected] Add a SliverList code sample (flutter/flutter#172986) 2025-07-31 [email protected] fix: adjust scrollable size assertion with tolerance (flutter/flutter#171426) 2025-07-31 [email protected] impeller: Shrink `Command` 40 bytes (flutter/flutter#173004) 2025-07-31 [email protected] [web] Remove outdated comment about HTML renderer (flutter/flutter#172877) 2025-07-31 [email protected] Roll Skia from ff4da49305c5 to 42e3bed42110 (1 revision) (flutter/flutter#173038) 2025-07-31 [email protected] Roll Skia from 7d468a4868cb to ff4da49305c5 (3 revisions) (flutter/flutter#173028) 2025-07-31 [email protected] Roll Skia from 951277895c86 to 7d468a4868cb (1 revision) (flutter/flutter#173027) 2025-07-31 [email protected] Manual roll of Dart from 14ea8d342149 to 6832e04cf2f9 (flutter/flutter#173015) 2025-07-31 [email protected] Roll Skia from 8bdf4cdcf4ed to 951277895c86 (2 revisions) (flutter/flutter#173022) 2025-07-31 [email protected] Roll Fuchsia Linux SDK from bQVQlLssTxxLjoDU0... to xo_bqOoFuBKFmgKxn... (flutter/flutter#173021) 2025-07-31 [email protected] feat: Add `cursorHeight` to `DropdownMenu` (flutter/flutter#172615) 2025-07-31 [email protected] Roll Skia from a3347cee2d73 to 8bdf4cdcf4ed (3 revisions) (flutter/flutter#173013) 2025-07-31 [email protected] [ Widget Preview ] Add `--web-server` support (flutter/flutter#172978) 2025-07-30 [email protected] Bump customer tests for zulip fix 2 (flutter/flutter#173003) 2025-07-30 [email protected] Migrate to null aware elements - Part 4 (flutter/flutter#172322) 2025-07-30 [email protected] Marks Linux linux_feature_flags_test to be unflaky (flutter/flutter#172629) 2025-07-30 [email protected] [ Widget Previews ] Add support for `MultiPreview`s (flutter/flutter#172852) 2025-07-30 [email protected] Made licenses_cpp simpatico with google licenses (flutter/flutter#172991) 2025-07-30 [email protected] Roll Skia from d579722d65c6 to a3347cee2d73 (6 revisions) (flutter/flutter#172989) 2025-07-30 [email protected] Migrate to null aware elements - Part 5 (flutter/flutter#172418) ...

…rd (flutter#169798) `android_obfuscate_test` is currently being schedule to run on a limited devicelab physical phone bot. However, it's only checking if `--obfuscate` works, not running anything on the device, so can move into the tools test integration shard. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20android_obfuscate_test/7722/overview The test only takes < 2 minutes, spinning up an entire build for it, especially on a devicelab bot, is wasteful. Similar to flutter#80161 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…tion.shard (flutter/flutter#169798)

…rd (flutter#169798) `android_obfuscate_test` is currently being schedule to run on a limited devicelab physical phone bot. However, it's only checking if `--obfuscate` works, not running anything on the device, so can move into the tools test integration shard. https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20android_obfuscate_test/7722/overview The test only takes < 2 minutes, spinning up an entire build for it, especially on a devicelab bot, is wasteful. Similar to flutter#80161 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 30, 2025

jmagman commented May 30, 2025

View reviewed changes

jmagman force-pushed the obfuscate-test branch from 422ea99 to c270cac Compare June 6, 2025 17:13

jmagman marked this pull request as ready for review June 13, 2025 16:55

jmagman requested a review from matanlurey as a code owner June 13, 2025 16:55

jmagman requested a review from a team June 13, 2025 16:55

matanlurey approved these changes Jun 16, 2025

View reviewed changes

matanlurey mentioned this pull request Jun 16, 2025

Re-evaluate on-device Android native_assets tests #170682

Closed

jmagman added the platform-android Android applications specifically label Jun 17, 2025

ash2moon self-assigned this Jun 24, 2025

jmagman unassigned ash2moon Jun 25, 2025

jmagman requested review from ash2moon and removed request for ash2moon June 25, 2025 19:38

jmagman marked this pull request as draft June 25, 2025 20:04

reidbaker approved these changes Jul 10, 2025

View reviewed changes

jmagman force-pushed the obfuscate-test branch from c270cac to 3bc5172 Compare July 25, 2025 19:26

github-actions bot added team-android Owned by Android platform team and removed platform-android Android applications specifically labels Jul 25, 2025

reidbaker approved these changes Jul 25, 2025

View reviewed changes

jmagman added 2 commits July 28, 2025 16:18

Move android_obfuscate_test from devicelab into tools integration.shard

1b79de2

Lint

668fd37

jmagman force-pushed the obfuscate-test branch from 827a0e3 to 668fd37 Compare July 28, 2025 23:18

jmagman marked this pull request as ready for review July 28, 2025 23:18

Merge branch 'master' into obfuscate-test

40ccd2e

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2025

auto-submit bot added this pull request to the merge queue Aug 1, 2025

Merged via the queue into flutter:master with commit af29489 Aug 1, 2025
152 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2025

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to 15f39d189edb (49 revisions) flutter/packages#9722

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

656c4d3

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to e1f8458f7568 (51 revisions) flutter/packages#9723

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

fa0285f

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to 6feaa2c63278 (52 revisions) flutter/packages#9724

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

fce6e85

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to b588b3b46fb0 (53 revisions) flutter/packages#9725

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

94d7363

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to ce44f81c8637 (54 revisions) flutter/packages#9726

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

c12dc2e

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to 28481edd6b5d (55 revisions) flutter/packages#9727

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

d8df223

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to 871849e4b6bf (56 revisions) flutter/packages#9728

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

a20c8bb

…tion.shard (flutter/flutter#169798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

af29489 Move android_obfuscate_test from devicelab into tools integra…

28f7fe2

…tion.shard (flutter/flutter#169798)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move android_obfuscate_test from devicelab into tools integration.shard#169798

Move android_obfuscate_test from devicelab into tools integration.shard#169798
auto-submit[bot] merged 3 commits intoflutter:masterfrom
jmagman:obfuscate-test

jmagman commented May 30, 2025 •

edited

Loading

Uh oh!

jmagman May 30, 2025

Uh oh!

jmagman May 30, 2025

Uh oh!

jmagman May 30, 2025

Uh oh!

jmagman commented Jun 25, 2025

Uh oh!

flutter-dashboard bot commented Jun 25, 2025

Uh oh!

jmagman commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	testWithoutContext('validate obfuscation', () {
	// HelloPlugin class is present in project.
	ProcessResult grepResult = processManager.runSync(<String>[
	'grep',
	'-r',
	'HelloPlugin',
	pluginRoot.path,
	]);
	// Matches exits 0.
	expect(grepResult.exitCode, 0);

	// Not present in binary.
	grepResult = processManager.runSync(<String>[
	'grep',
	'HelloPlugin',
	outputAppFrameworkBinary.path,
	]);
	// Does not match exits 1.
	expect(grepResult.exitCode, 1);
	});
	});

	final Archive archive = ZipDecoder().decodeBytes(outputFile.readAsBytesSync());

	expect(archive.findFile('base/lib/arm64-v8a/libapp.so') != null, true);
	expect(archive.findFile('base/lib/arm64-v8a/libflutter.so') != null, true);
	expect(archive.findFile('component1/lib/arm64-v8a/libapp.so-2.part.so') != null, true);

Conversation

jmagman commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman May 30, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman May 30, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman May 30, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jun 25, 2025

Uh oh!

flutter-dashboard bot commented Jun 25, 2025

Uh oh!

jmagman commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmagman commented May 30, 2025 •

edited

Loading