[ Tool ] Remove support for Android x86 targets#169884
[ Tool ] Remove support for Android x86 targets#169884auto-submit[bot] merged 4 commits intomasterfrom
Conversation
Dart x86 is deprecated, no longer shipped, and will eventually be removed from the Dart VM. This PR removes the last remaining x86 target, android-x86, from the tool. Work towards #157543
|
| 'lib/arm64-v8a/libflutter.so', | ||
| // Debug mode intentionally includes `x86` and `x86_64`. | ||
| 'lib/x86/libflutter.so', | ||
| // Debug mode intentionally includes `x86_64`. |
There was a problem hiding this comment.
Not sure what this comment is supposed to mean ?
There was a problem hiding this comment.
This was mostly a mechanical update, so I'm not sure either... 😅 it can probably be removed.
There was a problem hiding this comment.
We allowed debug builds to be run on an android x86 emulator. This comment was indicating that including x86 was intentional.
Do you happen to know where |
|
Let me take a look |
|
Looks like it is here: Lines 628 to 657 in a79827a And runs a custom recipe. |
I did come across that, but it's not clear what's actually being run. |
|
Oh, I found it. I'll send you a recipes CL. |
Dart x86 is deprecated, no longer shipped, and will eventually be removed from the Dart VM. This PR removes the last remaining x86 target, android-x86, from the tool.
Work towards #157543 and #160932