Relax RadioGroup semantics to allow non-radio children by chunhtai · Pull Request #170273 · flutter/flutter

chunhtai · 2025-06-09T17:46:43Z

as title, also adjust radio group semantics to form a semantics node. This makes sure it won't merge up and end up taking other semantics node sibling as its children

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2025-06-09T17:49:10Z

packages/flutter/test/widgets/semantics_role_checks_test.dart

      expect(error.message, 'Radio groups must not have multiple checked children');
    });

-    testWidgets('error case, reports first error', (WidgetTester tester) async {


I don't know how to properly test this since now only multiple checked radio will throw error, and since this error involves all radios in the group, so it doesn't make sense to say one of the error is the first error

loic-sharma

Looks good, but I'm curious when we'd need to nest a radio group in another radio group

chunhtai · 2025-06-12T19:57:03Z

there may be use case that radio group inside another radio group, for example if chicken wing menu can have something like

wingstop example, 

[*] bone-in
    [] spicy
    [*] non-spicy
[ ] bone-less
    [] spicy
    [] non-spicy

…er/flutter#170273)

flutter/flutter@f79452e...8303a96 2025-06-13 [email protected] infa: linux_android_emulator_tests to bringup (bad kvm config) (flutter/flutter#170607) 2025-06-13 [email protected] Roll Skia from 70455b7c74dd to 438ea4e05e15 (1 revision) (flutter/flutter#170570) 2025-06-13 [email protected] [web] Add Paint dithering. (flutter/flutter#170362) 2025-06-13 [email protected] Reland (#167738) but with some flags updated to use enum (flutter/flutter#170505) 2025-06-13 [email protected] Roll Dart SDK from ac589dba5282 to 1a6f6d7c6f2c (4 revisions) (flutter/flutter#170566) 2025-06-13 [email protected] Roll Skia from 22018eab8c1f to 70455b7c74dd (1 revision) (flutter/flutter#170564) 2025-06-13 [email protected] Roll Fuchsia Linux SDK from Dueykg3VpLT5D_jSG... to lVfYTWxB0rTTuW_k3... (flutter/flutter#170557) 2025-06-13 [email protected] [Windows] Use ANGLE blit extension on GLES 2.0 (flutter/flutter#170298) 2025-06-12 [email protected] chore: move experimental setup steps to composite action (flutter/flutter#170496) 2025-06-12 [email protected] [Impeller] fix mask filter application to Vertices. (flutter/flutter#170548) 2025-06-12 [email protected] Roll Skia from b41e7017658e to 22018eab8c1f (2 revisions) (flutter/flutter#170551) 2025-06-12 [email protected] Add CupertinoSheetRoute widget of the week video (flutter/flutter#170026) 2025-06-12 [email protected] Fix stray `--packages` argument from `workspace` refactor; add a test. (flutter/flutter#170449) 2025-06-12 [email protected] Roll pub packages (flutter/flutter#170522) 2025-06-12 [email protected] Navigator should call didpop when popping page based route (flutter/flutter#170376) 2025-06-12 [email protected] Relax RadioGroup semantics to allow non-radio children (flutter/flutter#170273) 2025-06-12 [email protected] [ Widget Preview ] Refactor the `flutter widget-preview` command (flutter/flutter#170467) 2025-06-12 [email protected] Pause UIScene migration (flutter/flutter#170490) 2025-06-12 [email protected] Roll Dart SDK from 9f741ef8a689 to ac589dba5282 (3 revisions) (flutter/flutter#170519) 2025-06-12 [email protected] Roll Packages from 0b322a2 to 6d3aaf4 (2 revisions) (flutter/flutter#170528) 2025-06-12 [email protected] Fix the path to `packages_autoroller`. (flutter/flutter#170538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

as title, also adjust radio group semantics to form a semantics node. This makes sure it won't merge up and end up taking other semantics node sibling as its children ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutter/flutter@f79452e...8303a96 2025-06-13 [email protected] infa: linux_android_emulator_tests to bringup (bad kvm config) (flutter/flutter#170607) 2025-06-13 [email protected] Roll Skia from 70455b7c74dd to 438ea4e05e15 (1 revision) (flutter/flutter#170570) 2025-06-13 [email protected] [web] Add Paint dithering. (flutter/flutter#170362) 2025-06-13 [email protected] Reland (#167738) but with some flags updated to use enum (flutter/flutter#170505) 2025-06-13 [email protected] Roll Dart SDK from ac589dba5282 to 1a6f6d7c6f2c (4 revisions) (flutter/flutter#170566) 2025-06-13 [email protected] Roll Skia from 22018eab8c1f to 70455b7c74dd (1 revision) (flutter/flutter#170564) 2025-06-13 [email protected] Roll Fuchsia Linux SDK from Dueykg3VpLT5D_jSG... to lVfYTWxB0rTTuW_k3... (flutter/flutter#170557) 2025-06-13 [email protected] [Windows] Use ANGLE blit extension on GLES 2.0 (flutter/flutter#170298) 2025-06-12 [email protected] chore: move experimental setup steps to composite action (flutter/flutter#170496) 2025-06-12 [email protected] [Impeller] fix mask filter application to Vertices. (flutter/flutter#170548) 2025-06-12 [email protected] Roll Skia from b41e7017658e to 22018eab8c1f (2 revisions) (flutter/flutter#170551) 2025-06-12 [email protected] Add CupertinoSheetRoute widget of the week video (flutter/flutter#170026) 2025-06-12 [email protected] Fix stray `--packages` argument from `workspace` refactor; add a test. (flutter/flutter#170449) 2025-06-12 [email protected] Roll pub packages (flutter/flutter#170522) 2025-06-12 [email protected] Navigator should call didpop when popping page based route (flutter/flutter#170376) 2025-06-12 [email protected] Relax RadioGroup semantics to allow non-radio children (flutter/flutter#170273) 2025-06-12 [email protected] [ Widget Preview ] Refactor the `flutter widget-preview` command (flutter/flutter#170467) 2025-06-12 [email protected] Pause UIScene migration (flutter/flutter#170490) 2025-06-12 [email protected] Roll Dart SDK from 9f741ef8a689 to ac589dba5282 (3 revisions) (flutter/flutter#170519) 2025-06-12 [email protected] Roll Packages from 0b322a2 to 6d3aaf4 (2 revisions) (flutter/flutter#170528) 2025-06-12 [email protected] Fix the path to `packages_autoroller`. (flutter/flutter#170538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er/flutter#170273)

update

e7f0fb1

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jun 9, 2025

chunhtai requested a review from loic-sharma June 9, 2025 17:46

chunhtai commented Jun 9, 2025

View reviewed changes

kenzieschmoll mentioned this pull request Jun 9, 2025

Upgrade to the latest Flutter SDK flutter/devtools#9244

Merged

chunhtai added 4 commits June 9, 2025 11:21

update

f46c538

fix merge up

6bd3bad

update

1a7fb6a

update

cec64b3

loic-sharma approved these changes Jun 12, 2025

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2025

auto-submit bot added this pull request to the merge queue Jun 12, 2025

Merged via the queue into flutter:master with commit 257411d Jun 12, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

51144ad

…er/flutter#170273)

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Flutter from f79452e3f4ea to 337a007f5cfb (20 revisions) flutter/packages#9425

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

2e58d39

…er/flutter#170273)

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Flutter from f79452e3f4ea to 337a007f5cfb (20 revisions) flutter/packages#9432

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

ed60f8c

…er/flutter#170273)

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Flutter from f79452e3f4ea to 8303a96a0a99 (21 revisions) flutter/packages#9433

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

d3953ec

…er/flutter#170273)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

0471c72

…er/flutter#170273)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

fed9521

…er/flutter#170273)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

6c2ea08

…er/flutter#170273)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

257411d Relax RadioGroup semantics to allow non-radio children (flutt…

4a15a47

…er/flutter#170273)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relax RadioGroup semantics to allow non-radio children#170273

Relax RadioGroup semantics to allow non-radio children#170273
auto-submit[bot] merged 5 commits intoflutter:masterfrom
chunhtai:radio-semantics

chunhtai commented Jun 9, 2025 •

edited

Loading

Uh oh!

chunhtai Jun 9, 2025 •

edited

Loading

Uh oh!

loic-sharma left a comment

Uh oh!

chunhtai commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chunhtai commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chunhtai commented Jun 9, 2025 •

edited

Loading

chunhtai Jun 9, 2025 •

edited

Loading