CP: Pause UIScene migration (#170490)#170569
Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.34-candidate.0from Jun 16, 2025
Merged
CP: Pause UIScene migration (#170490)#170569auto-submit[bot] merged 1 commit intoflutter:flutter-3.34-candidate.0from
auto-submit[bot] merged 1 commit intoflutter:flutter-3.34-candidate.0from
Conversation
UIScene migration is not yet enforced by Apple so we have some more time to handle this. Let's pause on auto-migrating projects. Reland of flutter#170457. This PR differs as it keeps our tests migrated to UI Scene lifecycle. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
platform-ios
matanlurey
approved these changes
Jun 13, 2025
vashworth
added
the
autosubmit
auto-submit
bot
merged commit 01fde95
into
flutter:flutter-3.34-candidate.0
143 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP of #170490
This PR rolls back auto-migrating iOS apps to UIScene lifecycle. It also updates tests to ensure things work in both a state where UIScene lifecycle is already adopted and when it isn't.
A number of UIScene issues have emerged since landing this in master: #170171
In addition, there's is disagreement over how some of it is implemented.
Impacted Users: All Flutter iOS developers
Impact Description: Some method channels may crash and apps using app lifecycle events may not work properly.
Workaround: Manually removing UIApplicationSceneManifest from Info.plist and potentially also update AppDelegate.swift.
Risk: Low
Test Coverage: Yes
Validation Steps: Run
flutter build iosand see thatUIApplicationSceneManifestif not added to Info.plist.