feat: Use engine_stamp.json in flutter tool by jtmcdole · Pull Request #171454 · flutter/flutter

jtmcdole · 2025-07-01T16:14:32Z

The flutter tool will now download and use an engine_stamp.json file to determine the engine version, content hash, build date, and commit date.

The file is treated as a new DevelopmentArtifact.informative and is fetched before flutterVersion is used. This ensures we have build information for a clean checkout with no bin/cache folder. Users that download from flutter.dev will have engine_stamp.json, so its a no-op.

This change provides support for content hashed engine artifacts, who's revision (the hash) is not a git commit sha. A side benefit is "git" is only used at build time to extract this information.

Note

Content hashed artifacts are not enabled yet for downloads; bin/internal/engine.version (releases) and the shell updaters still look for the git commit sha. One can test this out by setting FLUTTER_PREBUILD_ENGINE_VERSION to the content hash.

The flutter tool will now download and use an `engine_stamp.json` file to determine the engine version, content hash, build date, and commit date. This change provides support for content hashed engine artifacts, who's revision (the hash) is not a git commit sha. A side benifit is "git" is only used at build time to extract this information. Content hashed artifacts are not enabled yet; bin/internal/engine.version (releases) and the shell updaters still look for the git commit sha. One can test this out by setting FLUTTER_PREBUILD_ENGINE_VERSION to the content hash.

jtmcdole · 2025-07-01T16:19:15Z

Failing tests look real - so moving to draft while I figure out how to recreate.

flutter-dashboard · 2025-07-01T16:21:01Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jtmcdole · 2025-07-02T20:06:01Z

Waiting on g3fix to retest.

jtmcdole · 2025-07-02T21:34:39Z

G3Fix works.

bkonyi

LGTM overall.

packages/flutter_tools/lib/src/flutter_cache.dart

packages/flutter_tools/lib/src/version.dart

…171454)

flutter/flutter@28a4e85...adffe24 2025-07-08 [email protected] Roll Skia from 0669913308d3 to e159882c6ce0 (1 revision) (flutter/flutter#171766) 2025-07-08 [email protected] Roll Skia from 36b1f71fc14f to 0669913308d3 (4 revisions) (flutter/flutter#171756) 2025-07-08 [email protected] Roll Skia from f35536730dea to 36b1f71fc14f (3 revisions) (flutter/flutter#171751) 2025-07-08 [email protected] Roll Skia from 05374bbe5377 to f35536730dea (1 revision) (flutter/flutter#171744) 2025-07-08 [email protected] Roll Skia from 4968a30d721c to 05374bbe5377 (2 revisions) (flutter/flutter#171742) 2025-07-08 [email protected] Roll Skia from ad5c330487f7 to 4968a30d721c (8 revisions) (flutter/flutter#171739) 2025-07-08 [email protected] feat: Use engine_stamp.json in flutter tool (flutter/flutter#171454) 2025-07-08 [email protected] [ Tool ] Remove long-deprecated `make-host-app-editable` (flutter/flutter#171715) 2025-07-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (#171399)" (flutter/flutter#171736) 2025-07-07 [email protected] Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (flutter/flutter#171399) 2025-07-07 [email protected] [android] release background image readers on <= Android 14 (flutter/flutter#171193) 2025-07-07 [email protected] [ Tool ] Fix crash when SIGQUIT is sent to enable the VM service for `flutter analyze --watch` (flutter/flutter#171713) 2025-07-07 [email protected] Roll Skia from 47a5693d191a to ad5c330487f7 (2 revisions) (flutter/flutter#171716) 2025-07-07 [email protected] Run hot_reload_web_test.dart on Mac/Windows (flutter/flutter#171279) 2025-07-07 [email protected] Roll Fuchsia Linux SDK from 2DeZD1utFrnSwUfVT... to AinHuT0vgOelA1g7_... (flutter/flutter#171700) 2025-07-07 [email protected] [ Tool ] Prepare for enabling `omit_obvious_*_types` and `specify_nonobvious_*_types` (flutter/flutter#171651) 2025-07-07 [email protected] Roll Packages from e4fd6c0 to 2c52f24 (1 revision) (flutter/flutter#171705) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

alexmarkov · 2025-07-11T14:28:36Z

It looks like this change broke Dart/Flutter head-head bots:

Flutter assets will be downloaded from https://storage.googleapis.com/flutter_archives_v2/monorepo/8709644868295095665. Make sure you trust this source!
Failed to download https://storage.googleapis.com/flutter_archives_v2/monorepo/8709644868295095665/flutter_infra_release/flutter/e9ae2795b8a184d7da0d901060d8e64ad0c9600c/engine_stamp.json. Ensure you have network connectivity and then try again.
Exception: 404

log

These bots run flutter update-packages -v with FLUTTER_PREBUILT_ENGINE_VERSION set.

@jtmcdole Can you advise on how to repair those bots?

The flutter tool will now download and use an `engine_stamp.json` file to determine the engine version, content hash, build date, and commit date. The file is treated as a new `DevelopmentArtifact.informative` and is fetched before flutterVersion is used. This ensures we have build information for a clean checkout with no bin/cache folder. Users that download from flutter.dev will have engine_stamp.json, so its a no-op. This change provides support for content hashed engine artifacts, who's revision (the hash) is not a git commit sha. A side benefit is "git" is only used at build time to extract this information. > [!NOTE] > Content hashed artifacts are not enabled yet for downloads; bin/internal/engine.version (releases) and the shell updaters still look for the git commit sha. One can test this out by setting `FLUTTER_PREBUILD_ENGINE_VERSION` to the content hash.

flutter/flutter@28a4e85...adffe24 2025-07-08 [email protected] Roll Skia from 0669913308d3 to e159882c6ce0 (1 revision) (flutter/flutter#171766) 2025-07-08 [email protected] Roll Skia from 36b1f71fc14f to 0669913308d3 (4 revisions) (flutter/flutter#171756) 2025-07-08 [email protected] Roll Skia from f35536730dea to 36b1f71fc14f (3 revisions) (flutter/flutter#171751) 2025-07-08 [email protected] Roll Skia from 05374bbe5377 to f35536730dea (1 revision) (flutter/flutter#171744) 2025-07-08 [email protected] Roll Skia from 4968a30d721c to 05374bbe5377 (2 revisions) (flutter/flutter#171742) 2025-07-08 [email protected] Roll Skia from ad5c330487f7 to 4968a30d721c (8 revisions) (flutter/flutter#171739) 2025-07-08 [email protected] feat: Use engine_stamp.json in flutter tool (flutter/flutter#171454) 2025-07-08 [email protected] [ Tool ] Remove long-deprecated `make-host-app-editable` (flutter/flutter#171715) 2025-07-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (#171399)" (flutter/flutter#171736) 2025-07-07 [email protected] Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (flutter/flutter#171399) 2025-07-07 [email protected] [android] release background image readers on <= Android 14 (flutter/flutter#171193) 2025-07-07 [email protected] [ Tool ] Fix crash when SIGQUIT is sent to enable the VM service for `flutter analyze --watch` (flutter/flutter#171713) 2025-07-07 [email protected] Roll Skia from 47a5693d191a to ad5c330487f7 (2 revisions) (flutter/flutter#171716) 2025-07-07 [email protected] Run hot_reload_web_test.dart on Mac/Windows (flutter/flutter#171279) 2025-07-07 [email protected] Roll Fuchsia Linux SDK from 2DeZD1utFrnSwUfVT... to AinHuT0vgOelA1g7_... (flutter/flutter#171700) 2025-07-07 [email protected] [ Tool ] Prepare for enabling `omit_obvious_*_types` and `specify_nonobvious_*_types` (flutter/flutter#171651) 2025-07-07 [email protected] Roll Packages from e4fd6c0 to 2c52f24 (1 revision) (flutter/flutter#171705) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…171454)

flutter/flutter#171454

The flutter tool will now download and use an `engine_stamp.json` file to determine the engine version, content hash, build date, and commit date. The file is treated as a new `DevelopmentArtifact.informative` and is fetched before flutterVersion is used. This ensures we have build information for a clean checkout with no bin/cache folder. Users that download from flutter.dev will have engine_stamp.json, so its a no-op. This change provides support for content hashed engine artifacts, who's revision (the hash) is not a git commit sha. A side benefit is "git" is only used at build time to extract this information. > [!NOTE] > Content hashed artifacts are not enabled yet for downloads; bin/internal/engine.version (releases) and the shell updaters still look for the git commit sha. One can test this out by setting `FLUTTER_PREBUILD_ENGINE_VERSION` to the content hash.

jtmcdole requested review from bkonyi and matanlurey July 1, 2025 16:14

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 1, 2025

jtmcdole marked this pull request as draft July 1, 2025 16:19

jtmcdole added 6 commits July 1, 2025 10:12

don't try to remove "cache/*"

e3fbe0d

make engine_stamp.json available before getting flutter version info

2b5c3ab

engine_stamp to "engine information"

764f947

--informative; the uselss flag

975c913

no, really, --informative is useless and you should ignore it.

fca4f23

precache tests (passing locally at least)

15b5671

jtmcdole marked this pull request as ready for review July 2, 2025 00:05

Merge branch 'master' into tool_engine_stamp

c25e3ca

bkonyi approved these changes Jul 4, 2025

View reviewed changes

packages/flutter_tools/lib/src/flutter_cache.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/version.dart Outdated Show resolved Hide resolved

jtmcdole added 3 commits July 7, 2025 15:05

Merge branch 'master' into tool_engine_stamp

f64ccde

dart format with 3.8

cc6db27

Comments

f2a0014

jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025

auto-submit bot added this pull request to the merge queue Jul 8, 2025

Merged via the queue into flutter:master with commit 13d2219 Jul 8, 2025
138 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2025

13d2219 feat: Use engine_stamp.json in flutter tool (flutter/flutter#…

4fbc0ef

…171454)

engine-flutter-autoroll mentioned this pull request Jul 8, 2025

Roll Flutter from 28a4e852bc90 to adffe244f3f1 (17 revisions) flutter/packages#9580

Merged

jtmcdole mentioned this pull request Jul 8, 2025

Flutter Tool reports errors on content-hash #171237

Closed

ash2moon mentioned this pull request Jul 9, 2025

flutter build apk to use aab then generate apks from aab behind --from-app-bundle #171877

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

13d2219 feat: Use engine_stamp.json in flutter tool (flutter/flutter#…

4fde763

…171454)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

13d2219 feat: Use engine_stamp.json in flutter tool (flutter/flutter#…

041efa7

…171454)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

13d2219 feat: Use engine_stamp.json in flutter tool (flutter/flutter#…

7db6e55

…171454)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

13d2219 feat: Use engine_stamp.json in flutter tool (flutter/flutter#…

98a7b51

…171454)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

13d2219 feat: Use engine_stamp.json in flutter tool (flutter/flutter#…

b098e28

…171454)

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 9, 2025

Add missing implementation to FlutterVersion

6284083

flutter/flutter#171454

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 19, 2025

Add missing implementation to FlutterVersion

e9c25c9

flutter/flutter#171454

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Use engine_stamp.json in flutter tool#171454

feat: Use engine_stamp.json in flutter tool#171454
auto-submit[bot] merged 11 commits intoflutter:masterfrom
jtmcdole:tool_engine_stamp

jtmcdole commented Jul 1, 2025 •

edited

Loading

Uh oh!

jtmcdole commented Jul 1, 2025

Uh oh!

flutter-dashboard bot commented Jul 1, 2025

Uh oh!

jtmcdole commented Jul 2, 2025

Uh oh!

jtmcdole commented Jul 2, 2025

Uh oh!

bkonyi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexmarkov commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jtmcdole commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtmcdole commented Jul 1, 2025

Uh oh!

flutter-dashboard bot commented Jul 1, 2025

Uh oh!

jtmcdole commented Jul 2, 2025

Uh oh!

jtmcdole commented Jul 2, 2025

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexmarkov commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jtmcdole commented Jul 1, 2025 •

edited

Loading