Add total execution time to the flutter upgrade command by matanlurey · Pull Request #171475 · flutter/flutter

matanlurey · 2025-07-01T20:25:12Z

bkonyi · 2025-07-02T13:56:47Z

packages/flutter_tools/lib/src/commands/upgrade.dart

      await runCommandSecondHalf(flutterVersion);
    }
+    final Duration execution = timer.elapsed;
+    globals.printStatus('Took ${execution.inMinutes} minutes');


This will print 'Took 0 minutes' if it takes less than a minute to upgrade. Can we add seconds as well (e.g., 'Completed in 3:15.0')?

If you add this, consider adding a elapsedAsMinutes helper here:

flutter/packages/flutter_tools/lib/src/base/utils.dart

Lines 90 to 100 in 1784899

final NumberFormat kSecondsFormat = NumberFormat('0.0');

final NumberFormat kMillisecondsFormat = NumberFormat.decimalPattern();

String getElapsedAsSeconds(Duration duration) {

final double seconds = duration.inMilliseconds / Duration.millisecondsPerSecond;

return '${kSecondsFormat.format(seconds)}s';

}

String getElapsedAsMilliseconds(Duration duration) {

return '${kMillisecondsFormat.format(duration.inMilliseconds)}ms';

}

…on-time-flutter-upgrade

matanlurey · 2025-07-08T19:33:34Z

Updated based on your feedback @loic-sharma @bkonyi.

I also decided to swap a mysterious bool to a typed class to encapsulate some needed logic.

One thing to consider: this is now a breaking change if a user was using --continue themselves (which we document not to do or rely on, so I don't think this is a big deal). I'm OK with writing a breaking change notice if we think that's relevant, otherwise PTAL.

matanlurey · 2025-07-08T21:04:16Z

I just realized this isn't a totally safe change, someone could be using a Flutter version many back that won't know to pass a date.

I can either:

Print out two sets of times (one for each phase), no sum
Print out a total time if --continue-started-at is passed
Some combination of both

I'm leaning (1); the complexity is already high here, and printing out two separate times, while a little less convenient, still solves the attached issue and we aren't committed to a CLI contract and could always make future changes.

bkonyi · 2025-07-08T21:35:24Z

I don't think this requires a breaking change notice given the explicit warning not to use that flag. This is one of those situations where I wish we didn't have a policy against hiding internal flags completely.

I think as long as the tool can handle the case where --continue isn't given a time, even if that means not printing the upgrade execution time at all for upgrades from versions older than this commit, this should be safe enough.

matanlurey · 2025-07-08T21:37:53Z

@bkonyi Should I assume that's a vote for (2)?

bkonyi · 2025-07-08T23:03:21Z

@bkonyi Should I assume that's a vote for (2)?

If we're going to print this without the user providing --verbose, then yes, I think that's the best solution. Otherwise, users don't know that we're actually running the tool twice as part of the upgrade process and seeing two timings printed may seem strange.

…on-time-flutter-upgrade

matanlurey · 2025-07-09T16:34:13Z

Updated. PTAL @bkonyi @loic-sharma

…ter/flutter#171475)

flutter/flutter@ac12f66...43657f3 2025-07-10 [email protected] [web] Add frame number support. (flutter/flutter#171592) 2025-07-10 [email protected] Fix the hitTest issue of reversed SliverMainAxisGroup. (flutter/flutter#171073) 2025-07-10 [email protected] Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... (flutter/flutter#171937) 2025-07-10 [email protected] Refactor compositor classes (flutter/flutter#171414) 2025-07-10 [email protected] Give an actionable error to `flutter_test.*tap` of a `RenderSliver` (flutter/flutter#171930) 2025-07-10 [email protected] Fix the issue with `SliverMainAxisGroups` growing in the reverse direction during layout. (flutter/flutter#171005) 2025-07-09 [email protected] Adds a MCP server for working with the engine (flutter/flutter#171738) 2025-07-09 [email protected] Use Async SurfaceHolder Callback to remove need for setting alpha workaround (flutter/flutter#171398) 2025-07-09 [email protected] Update `CHANGELOG` for 3.32.5, 3.32.6 stable hotfix releases (flutter/flutter#171891) 2025-07-09 [email protected] Add `flutter config --enable-omit-legacy-version-file` (flutter/flutter#171903) 2025-07-09 [email protected] Allow flutter attach to discover flutter engine running on Custom Device (flutter/flutter#170635) 2025-07-09 [email protected] Hide the rarely direct used `--sample` argument by default (flutter/flutter#171898) 2025-07-09 [email protected] Support `NO_COLOR` to opt-out of `flutter` tool ANSI colors (flutter/flutter#171892) 2025-07-09 [email protected] [Android 16] Added Docs to Warn Users that SystemChrome.setPreferredOrientations will Not Work (flutter/flutter#171089) 2025-07-09 [email protected] Add analytics events for wasm dry runs on web builds (flutter/flutter#171818) 2025-07-09 [email protected] feat: new builders for size experiment (flutter/flutter#171886) 2025-07-09 [email protected] Update `.gitignore`s (flutter/flutter#171907) 2025-07-09 [email protected] Add total execution time to the flutter upgrade command (flutter/flutter#171475) 2025-07-09 [email protected] Simplify the template for infrastructure requests (flutter/flutter#171905) 2025-07-09 [email protected] Add detailed error message for BorderRadiusDirectional (flutter/flutter#171805) 2025-07-09 [email protected] Add public postmortem of the 3.32.3 release. (flutter/flutter#171904) 2025-07-09 [email protected] Make `labels` field an array (flutter/flutter#171906) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (#171897)" (flutter/flutter#171910) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (flutter/flutter#171897) 2025-07-09 [email protected] [skia] Fix flag fiddling for Fuchsia, FreeType, & friends (flutter/flutter#171874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter#47090.

flutter/flutter@ac12f66...43657f3 2025-07-10 [email protected] [web] Add frame number support. (flutter/flutter#171592) 2025-07-10 [email protected] Fix the hitTest issue of reversed SliverMainAxisGroup. (flutter/flutter#171073) 2025-07-10 [email protected] Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... (flutter/flutter#171937) 2025-07-10 [email protected] Refactor compositor classes (flutter/flutter#171414) 2025-07-10 [email protected] Give an actionable error to `flutter_test.*tap` of a `RenderSliver` (flutter/flutter#171930) 2025-07-10 [email protected] Fix the issue with `SliverMainAxisGroups` growing in the reverse direction during layout. (flutter/flutter#171005) 2025-07-09 [email protected] Adds a MCP server for working with the engine (flutter/flutter#171738) 2025-07-09 [email protected] Use Async SurfaceHolder Callback to remove need for setting alpha workaround (flutter/flutter#171398) 2025-07-09 [email protected] Update `CHANGELOG` for 3.32.5, 3.32.6 stable hotfix releases (flutter/flutter#171891) 2025-07-09 [email protected] Add `flutter config --enable-omit-legacy-version-file` (flutter/flutter#171903) 2025-07-09 [email protected] Allow flutter attach to discover flutter engine running on Custom Device (flutter/flutter#170635) 2025-07-09 [email protected] Hide the rarely direct used `--sample` argument by default (flutter/flutter#171898) 2025-07-09 [email protected] Support `NO_COLOR` to opt-out of `flutter` tool ANSI colors (flutter/flutter#171892) 2025-07-09 [email protected] [Android 16] Added Docs to Warn Users that SystemChrome.setPreferredOrientations will Not Work (flutter/flutter#171089) 2025-07-09 [email protected] Add analytics events for wasm dry runs on web builds (flutter/flutter#171818) 2025-07-09 [email protected] feat: new builders for size experiment (flutter/flutter#171886) 2025-07-09 [email protected] Update `.gitignore`s (flutter/flutter#171907) 2025-07-09 [email protected] Add total execution time to the flutter upgrade command (flutter/flutter#171475) 2025-07-09 [email protected] Simplify the template for infrastructure requests (flutter/flutter#171905) 2025-07-09 [email protected] Add detailed error message for BorderRadiusDirectional (flutter/flutter#171805) 2025-07-09 [email protected] Add public postmortem of the 3.32.3 release. (flutter/flutter#171904) 2025-07-09 [email protected] Make `labels` field an array (flutter/flutter#171906) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (#171897)" (flutter/flutter#171910) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (flutter/flutter#171897) 2025-07-09 [email protected] [skia] Fix flag fiddling for Fuchsia, FreeType, & friends (flutter/flutter#171874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ter/flutter#171475)

Closes flutter#47090.

Add total execution time to the flutter upgrade command

3154083

matanlurey requested a review from bkonyi July 1, 2025 20:25

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 1, 2025

bkonyi reviewed Jul 2, 2025

View reviewed changes

matanlurey added 3 commits July 8, 2025 10:41

Merge remote-tracking branch 'upstream/master' into add-total-executi…

7949ee2

…on-time-flutter-upgrade

Use named class, add minutes/seconds, add more tests

6101abd

Update upgrade_test

7c0633c

matanlurey requested review from bkonyi and loic-sharma July 8, 2025 19:32

matanlurey added 2 commits July 9, 2025 09:27

Merge remote-tracking branch 'upstream/master' into add-total-executi…

2fbe07f

…on-time-flutter-upgrade

Change to --continue-started-at and make optional

24bc954

++

5904efc

bkonyi approved these changes Jul 9, 2025

View reviewed changes

Fix paths on windows

ffd4c01

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2025

auto-submit bot added this pull request to the merge queue Jul 9, 2025

Merged via the queue into flutter:master with commit e212d3d Jul 9, 2025
142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2025

engine-flutter-autoroll mentioned this pull request Jul 10, 2025

Roll Flutter from ac12f66681f1 to 43657f3baa17 (25 revisions) flutter/packages#9589

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 10, 2025

e212d3d Add total execution time to the flutter upgrade command (flut…

5849be1

…ter/flutter#171475)

azatech pushed a commit to azatech/flutter that referenced this pull request Jul 10, 2025

Add total execution time to the flutter upgrade command (flutter#171475)

953c345

Closes flutter#47090.

azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025

Add total execution time to the flutter upgrade command (flutter#171475)

40eb115

Closes flutter#47090.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e212d3d Add total execution time to the flutter upgrade command (flut…

63102ea

…ter/flutter#171475)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e212d3d Add total execution time to the flutter upgrade command (flut…

0f4e37e

…ter/flutter#171475)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e212d3d Add total execution time to the flutter upgrade command (flut…

6112080

…ter/flutter#171475)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e212d3d Add total execution time to the flutter upgrade command (flut…

9ef6b6c

…ter/flutter#171475)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

e212d3d Add total execution time to the flutter upgrade command (flut…

7518565

…ter/flutter#171475)

ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025

Add total execution time to the flutter upgrade command (flutter#171475)

93c8901

Closes flutter#47090.

lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025

Add total execution time to the flutter upgrade command (flutter#171475)

3cfc5c9

Closes flutter#47090.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add total execution time to the flutter upgrade command#171475

Add total execution time to the flutter upgrade command#171475
auto-submit[bot] merged 8 commits intoflutter:masterfrom
matanlurey:add-total-execution-time-flutter-upgrade

matanlurey commented Jul 1, 2025

Uh oh!

bkonyi Jul 2, 2025

Uh oh!

loic-sharma Jul 2, 2025

Uh oh!

matanlurey commented Jul 8, 2025

Uh oh!

matanlurey commented Jul 8, 2025

Uh oh!

bkonyi commented Jul 8, 2025

Uh oh!

matanlurey commented Jul 8, 2025

Uh oh!

bkonyi commented Jul 8, 2025

Uh oh!

matanlurey commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	final NumberFormat kSecondsFormat = NumberFormat('0.0');
	final NumberFormat kMillisecondsFormat = NumberFormat.decimalPattern();

	String getElapsedAsSeconds(Duration duration) {
	final double seconds = duration.inMilliseconds / Duration.millisecondsPerSecond;
	return '${kSecondsFormat.format(seconds)}s';
	}

	String getElapsedAsMilliseconds(Duration duration) {
	return '${kMillisecondsFormat.format(duration.inMilliseconds)}ms';
	}

Conversation

matanlurey commented Jul 1, 2025

Uh oh!

bkonyi Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey commented Jul 8, 2025

Uh oh!

matanlurey commented Jul 8, 2025

Uh oh!

bkonyi commented Jul 8, 2025

Uh oh!

matanlurey commented Jul 8, 2025

Uh oh!

bkonyi commented Jul 8, 2025

Uh oh!

matanlurey commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants