feat: Enable WidgetStateColor to be used in ChipThemeData.deleteIconColor by erickzanardo · Pull Request #171646 · flutter/flutter

erickzanardo · 2025-07-04T18:28:09Z

Use WidgetStateProperty.resolveAs for the ChipThemeData.deleteIconColor on the RawChip widget in order to allow developers to use WidgetStateProperty on that attribute.

Fixes: #171645

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…olor

packages/flutter/lib/src/material/chip.dart

packages/flutter/test/material/chip_test.dart

dkwingsmt · 2025-07-30T18:29:51Z

Seems like there are more formatting issues.

packages/flutter/test/material/chip_test.dart

dkwingsmt · 2025-08-13T18:22:49Z

@erickzanardo Did the unnecessary formatting come from running dart format? It shouldn't behave this way, but one possible reason is that you're using outdated formatting packages. Can you try updating them (flutter update-packages or update the dart package) then run the dart format again?

erickzanardo · 2025-08-13T18:30:01Z

@erickzanardo Did the unnecessary formatting come from running dart format? It shouldn't behave this way, but one possible reason is that you're using outdated formatting packages. Can you try updating them (flutter update-packages or update the dart package) then run the dart format again?

@dkwingsmt indeed they came! And I am fairly sure it came from dart bundled with flutter! I will try your advice though!

erickzanardo · 2025-08-13T19:08:16Z

@dkwingsmt I guess that did the trick! Thanks for walking me through it!

victorsanni

LGTM. Thanks for the PR.

QuncCccccc

Thank for your contribution! LGTM with nits.

QuncCccccc · 2025-08-20T01:02:13Z

packages/flutter/test/material/chip_test.dart

+  testWidgets('Chip uses the resolved color based on its state for the delete icon color', (
+    WidgetTester tester,
+  ) async {
+    final ThemeData themeData = ThemeData(primarySwatch: Colors.blue);


nit: this seems unnecessary. I think we can remove it to make test look a bit simpler.

Suggested change

final ThemeData themeData = ThemeData(primarySwatch: Colors.blue);

QuncCccccc · 2025-08-20T01:02:48Z

packages/flutter/test/material/chip_test.dart

+    final ThemeData themeData = ThemeData(primarySwatch: Colors.blue);
+    Widget buildApp({required ChipThemeData chipTheme, bool isSelected = false}) {
+      return wrapForChip(
+        child: Theme(


Then we can remove themeData here as well.

…eteIconColor (flutter/flutter#171646)

Roll Flutter from 8f94cb0 to 9ff2767 (56 revisions) flutter/flutter@8f94cb0...9ff2767 2025-09-20 [email protected] Roll Fuchsia Linux SDK from 0_jKqLGnkILvQ5C8a... to CcCe3HpQtBYhTZscb... (flutter/flutter#175698) 2025-09-20 [email protected] Roll Dart SDK from e6e9248aee4f to 9e943fe076c8 (1 revision) (flutter/flutter#175697) 2025-09-20 [email protected] Add `menuController` to `DropdownMenu` (flutter/flutter#175039) 2025-09-20 [email protected] Roll Skia from 1dae085e2f31 to a38a531dec1d (3 revisions) (flutter/flutter#175694) 2025-09-20 [email protected] [a11y] TimePicker clock is unnecessarily announced (flutter/flutter#175570) 2025-09-20 [email protected] Roll Dart SDK from 78e68d1a7dbf to e6e9248aee4f (4 revisions) (flutter/flutter#175690) 2025-09-19 [email protected] Roll Skia from b56003bf2c20 to 1dae085e2f31 (1 revision) (flutter/flutter#175674) 2025-09-19 [email protected] Update `CODEOWNERS` (for dev-tooling) (flutter/flutter#175201) 2025-09-19 [email protected] [a11y-app] Add label to TextFormField in AutoCompleteUseCase. (flutter/flutter#175576) 2025-09-19 [email protected] Fix RadioGroup single selection check. (flutter/flutter#175654) 2025-09-19 [email protected] Roll Packages from f2a65fd to 3d5c419 (2 revisions) (flutter/flutter#175668) 2025-09-19 [email protected] Roll Skia from c74d2bdbd93c to b56003bf2c20 (2 revisions) (flutter/flutter#175665) 2025-09-19 [email protected] Add `CupertinoLinearActivityIndicator` (flutter/flutter#170108) 2025-09-19 [email protected] [ Widget Preview ] Don't update filtered preview set when selecting non-source files (flutter/flutter#175596) 2025-09-19 [email protected] Roll Dart SDK from 2c79803c97db to 78e68d1a7dbf (3 revisions) (flutter/flutter#175646) 2025-09-19 [email protected] Delete unused web_unicode library (flutter/flutter#174896) 2025-09-19 [email protected] Roll Skia from 684f3a831216 to c74d2bdbd93c (2 revisions) (flutter/flutter#175644) 2025-09-19 [email protected] Roll Skia from 462bdece17bf to 684f3a831216 (3 revisions) (flutter/flutter#175641) 2025-09-19 [email protected] Roll Skia from a2c38aa9df80 to 462bdece17bf (11 revisions) (flutter/flutter#175629) 2025-09-18 [email protected] fix(tool): Use merge-base for content hash in detached HEAD (flutter/flutter#175554) 2025-09-18 [email protected] [web] Unskip Cupertino datepicker golden tests in Skwasm (flutter/flutter#174666) 2025-09-18 [email protected] Update rules to include extension rules (flutter/flutter#175618) 2025-09-18 [email protected] [engine] Cleanup Fuchsia FDIO library dependencies (flutter/flutter#174847) 2025-09-18 [email protected] Make sure that a CloseButton doesn't crash in 0x0 environment (flutter/flutter#172902) 2025-09-18 [email protected] [ Tool ] Serve DevTools from DDS, remove ResidentDevToolsHandler (flutter/flutter#174580) 2025-09-18 [email protected] [engine][fuchsia] Update to Fuchsia API level 28 and roll latest GN SDK (flutter/flutter#175425) 2025-09-18 [email protected] Added a 36 device for Firebase Lab Testing (flutter/flutter#175613) 2025-09-18 [email protected] Roll Dart SDK from 09a101793af4 to 2c79803c97db (2 revisions) (flutter/flutter#175608) 2025-09-18 [email protected] Engine Support for Dynamic View Resizing (flutter/flutter#173610) 2025-09-18 [email protected] Roll Packages from fdee698 to f2a65fd (3 revisions) (flutter/flutter#175594) 2025-09-18 [email protected] Connect the FlutterEngine to the FlutterSceneDelegate (flutter/flutter#174910) 2025-09-18 [email protected] Roll Dart SDK from de5dd0f1530f to 09a101793af4 (2 revisions) (flutter/flutter#175583) 2025-09-18 [email protected] Roll Skia from 7b9fe91446ee to a2c38aa9df80 (1 revision) (flutter/flutter#175579) 2025-09-18 [email protected] Roll Skia from ab1b10547461 to 7b9fe91446ee (4 revisions) (flutter/flutter#175569) 2025-09-18 [email protected] [a11y-app] Fix form field label and error message (flutter/flutter#174831) 2025-09-18 [email protected] Fix InputDecoration does not apply errorStyle to error (flutter/flutter#174787) 2025-09-18 [email protected] Migrate to `WidgetPropertyResolver` (flutter/flutter#175397) 2025-09-18 [email protected] Migrate to WidgetState (flutter/flutter#175396) 2025-09-18 [email protected] Roll Skia from 79ec8dfcd9d4 to ab1b10547461 (17 revisions) (flutter/flutter#175561) 2025-09-18 [email protected] Removes NOTICES from licenses input (flutter/flutter#174967) 2025-09-18 [email protected] Roll Dart SDK from 116f7fe72839 to de5dd0f1530f (2 revisions) (flutter/flutter#175557) 2025-09-17 [email protected] [reland][web] Refactor renderers to use the same frontend code #174588 (flutter/flutter#175392) 2025-09-17 [email protected] feat: Enable WidgetStateColor to be used in ChipThemeData.deleteIconColor (flutter/flutter#171646) 2025-09-17 [email protected] Filter out unexpected process logs on iOS with better regex matching. (flutter/flutter#175452) 2025-09-17 [email protected] CupertinoContextMenu child respects available screen width (flutter/flutter#175300) 2025-09-17 [email protected] Correct documentation in PredictiveBackFullscreenPageTransitionsBuilder (flutter/flutter#174362) ...

…olor (flutter#171646)  Use `WidgetStateProperty.resolveAs` for the `ChipThemeData.deleteIconColor` on the `RawChip` widget in order to allow developers to use `WidgetStateProperty` on that attribute. Fixes: flutter#171645 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Victor Sanni <[email protected]> Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

…eteIconColor (flutter/flutter#171646)

…olor (flutter#171646)  Use `WidgetStateProperty.resolveAs` for the `ChipThemeData.deleteIconColor` on the `RawChip` widget in order to allow developers to use `WidgetStateProperty` on that attribute. Fixes: flutter#171645 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Victor Sanni <[email protected]> Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

feat: Enable WidgetStateColor to be used in ChipThemeData.deleteIconC…

8891fd4

…olor

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 4, 2025

erickzanardo mentioned this pull request Jul 7, 2025

Icon colors depending on the state for Chips #171649

Open

dkwingsmt requested a review from victorsanni July 10, 2025 23:35

victorsanni reviewed Jul 11, 2025

View reviewed changes

packages/flutter/lib/src/material/chip.dart Show resolved Hide resolved

packages/flutter/test/material/chip_test.dart Outdated Show resolved Hide resolved

erickzanardo force-pushed the master branch from d275ca2 to 8891fd4 Compare July 24, 2025 13:20

erickzanardo added 2 commits July 24, 2025 10:22

removing target platform from the chip test

e360c33

Merge branch 'master' into master

7cd438a

erickzanardo requested a review from victorsanni July 24, 2025 13:27

fix formating

306dd12

victorsanni reviewed Aug 2, 2025

View reviewed changes

packages/flutter/test/material/chip_test.dart Outdated Show resolved Hide resolved

updating formating

c55cfd3

victorsanni and others added 2 commits August 13, 2025 13:56

Merge branch 'master' into master

bafd4a2

Merge branch 'master' into master

54b1314

victorsanni approved these changes Aug 14, 2025

View reviewed changes

victorsanni requested a review from QuncCccccc August 14, 2025 23:00

QuncCccccc reviewed Aug 20, 2025

View reviewed changes

victorsanni and others added 2 commits August 29, 2025 15:40

Merge branch 'master' into master

a195850

Fix nit

8b7c487

QuncCccccc approved these changes Sep 17, 2025

View reviewed changes

Merge branch 'master' into master

fc6ad03

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2025

auto-submit bot added this pull request to the merge queue Sep 17, 2025

Merged via the queue into flutter:master with commit a5f9d2b Sep 17, 2025
78 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2025

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to ef6c1d185190 (25 revisions) flutter/packages#10031

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

9c03d76

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to ba2bcd62dc5f (26 revisions) flutter/packages#10032

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

d0d3d56

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

7e46cef

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to 1dc51dbf6a7e (27 revisions) flutter/packages#10033

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

b605e11

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to b683af0cecc0 (28 revisions) flutter/packages#10034

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

9b8c674

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to 7ade3f344755 (39 revisions) flutter/packages#10035

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

b880506

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to 242958f8bad5 (42 revisions) flutter/packages#10036

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

b6de1f4

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to f930c8105beb (43 revisions) flutter/packages#10037

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

2cdc133

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to d12d8a409a7b (44 revisions) flutter/packages#10038

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

c352cce

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to cdbfd49962cf (45 revisions) flutter/packages#10040

Closed

Piinks mentioned this pull request Sep 19, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

11f7dbd

…eteIconColor (flutter/flutter#171646)

engine-flutter-autoroll mentioned this pull request Sep 20, 2025

Roll Flutter from 8f94cb0d8f01 to 9ff2767f3cb6 (56 revisions) flutter/packages#10041

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

a5f9d2b feat: Enable WidgetStateColor to be used in ChipThemeData.del…

656ce6e

…eteIconColor (flutter/flutter#171646)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enable WidgetStateColor to be used in ChipThemeData.deleteIconColor#171646

feat: Enable WidgetStateColor to be used in ChipThemeData.deleteIconColor#171646
auto-submit[bot] merged 10 commits intoflutter:masterfrom
erickzanardo:master

erickzanardo commented Jul 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

dkwingsmt commented Jul 30, 2025

Uh oh!

Uh oh!

dkwingsmt commented Aug 13, 2025

Uh oh!

erickzanardo commented Aug 13, 2025

Uh oh!

erickzanardo commented Aug 13, 2025

Uh oh!

victorsanni left a comment

Uh oh!

QuncCccccc left a comment

Uh oh!

QuncCccccc Aug 20, 2025

Uh oh!

QuncCccccc Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

erickzanardo commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

dkwingsmt commented Jul 30, 2025

Uh oh!

Uh oh!

dkwingsmt commented Aug 13, 2025

Uh oh!

erickzanardo commented Aug 13, 2025

Uh oh!

erickzanardo commented Aug 13, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erickzanardo commented Jul 4, 2025 •

edited

Loading