fix: focus traversal into nested scrollable #172283
fix: focus traversal into nested scrollable #172283Andro999b wants to merge 15 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
framework
…lutter into focus_traversal_scroll_scope
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hey @Andro999b! Welcome! Thanks for contributing!
| variant: KeySimulatorTransitModeVariant.all(), | ||
| ); | ||
|
|
||
| testWidgets( |
There was a problem hiding this comment.
These tests all pass without the above change, which will not prevent us from regressing this in the future. Can you add a test that verifies that the expected behavior does not work without this change?
There was a problem hiding this comment.
Thanks for pointing. I will revisit my tests.
|
There may be a duplicate PR here: #172875 |
|
Closing per #172875 (comment) |
2 participants
DirectionalFocusTraversalPolicyMixinthere is a check that preventsScrollablefrom losing a focus by checking if focusable have same parentScrollable. It works fine in most cases but mix of horizontal scrollable in vertical scrollable breaks focus traversal. To correct this behavior Axis check were added in this PR.