Migrate to null aware elements - Part 2 by jamilsaadeh97 · Pull Request #172306 · flutter/flutter

jamilsaadeh97 · 2025-07-17T19:38:22Z

Replace null checks with null aware elements - part 2

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

victorsanni · 2025-07-23T20:10:37Z

packages/integration_test/test/binding_fail_test.dart

                  return json.cast();
                }
-                return <Map<String, dynamic>>[if (json != null) json as Map<String, dynamic>];
+                return <Map<String, dynamic>>[?json as Map<String, dynamic>?];


Is the type now nullable? Previously it was non-nullable. Or is this a non-issue?

The nullable cast is necessary since the null aware element only works on nullable types.
But at the end the return type wont be nullable so it's a non-issue

json has always been nullable but previously it was converted after null check, while now it's before.

victorsanni

This will need a test-exemption.

dkwingsmt

LGTM

stuartmorgan-g · 2025-07-25T11:46:36Z

test-exempt: code refactor with no semantic change

@jamilsaadeh97

## Description Continuing the work from @jamilsaadeh97 to replace verbose null checks with modern [null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements) syntax. This PR cleans up the remaining files not covered in the previous parts, making the code more concise. ## Related PRs - #172198 - #172306 - #172307 - #172322 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

Replace null checks with null aware elements - part 2 Part of flutter#172188 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@jamilsaadeh97

## Description Continuing the work from @jamilsaadeh97 to replace verbose null checks with modern [null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements) syntax. This PR cleans up the remaining files not covered in the previous parts, making the code more concise. ## Related PRs - flutter#172198 - flutter#172306 - flutter#172307 - flutter#172322 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

Replace null checks with null aware elements - part 2 Part of flutter#172188 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@jamilsaadeh97

## Description Continuing the work from @jamilsaadeh97 to replace verbose null checks with modern [null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements) syntax. This PR cleans up the remaining files not covered in the previous parts, making the code more concise. ## Related PRs - flutter#172198 - flutter#172306 - flutter#172307 - flutter#172322 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

Replace null checks with null aware elements - part 2 Part of flutter#172188 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@jamilsaadeh97

## Description Continuing the work from @jamilsaadeh97 to replace verbose null checks with modern [null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements) syntax. This PR cleans up the remaining files not covered in the previous parts, making the code more concise. ## Related PRs - flutter#172198 - flutter#172306 - flutter#172307 - flutter#172322 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

Replace null checks with null aware elements - part 2 Part of flutter#172188 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@jamilsaadeh97

## Description Continuing the work from @jamilsaadeh97 to replace verbose null checks with modern [null_aware_elements](https://dart.dev/tools/linter-rules/use_null_aware_elements) syntax. This PR cleans up the remaining files not covered in the previous parts, making the code more concise. ## Related PRs - flutter#172198 - flutter#172306 - flutter#172307 - flutter#172322 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

jamilsaadeh97 added 3 commits July 17, 2025 22:34

migrate flutter_goldens

4783b98

migrate integration_test

4ef059d

migrate flutter_localizations

98557db

jamilsaadeh97 requested a review from matanlurey as a code owner July 17, 2025 19:38

ricardodalarme mentioned this pull request Jul 19, 2025

Migrate to null aware elements - Part 5 #172418

Merged

9 tasks

dkwingsmt requested review from dkwingsmt and victorsanni July 23, 2025 18:19

victorsanni reviewed Jul 23, 2025

View reviewed changes

victorsanni approved these changes Jul 23, 2025

View reviewed changes

dkwingsmt approved these changes Jul 24, 2025

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2025

auto-submit bot added this pull request to the merge queue Jul 30, 2025

Merged via the queue into flutter:master with commit 5e74afc Jul 30, 2025
72 of 73 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

42aa5c2

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 2c21273bfde5 (25 revisions) flutter/packages#9707

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

a366e59

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 5a078b8b4820 (26 revisions) flutter/packages#9708

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

75b280e

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 7a5d1ab2e208 (27 revisions) flutter/packages#9709

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

5d6b1de

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 28b09850d053 (29 revisions) flutter/packages#9711

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

8e29607

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 443f6760b13c (30 revisions) flutter/packages#9712

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

086e2ff

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to ae0d0f415e68 (31 revisions) flutter/packages#9713

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

839b1a9

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 5b78ecca51f0 (33 revisions) flutter/packages#9714

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

9256e93

engine-flutter-autoroll mentioned this pull request Jul 31, 2025

Roll Flutter from c3279caa127d to 016143afdebf (34 revisions) flutter/packages#9715

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

f52b753

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to 15f39d189edb (49 revisions) flutter/packages#9722

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

517053e

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to e1f8458f7568 (51 revisions) flutter/packages#9723

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

7d791e1

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to 6feaa2c63278 (52 revisions) flutter/packages#9724

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

7898064

engine-flutter-autoroll mentioned this pull request Aug 1, 2025

Roll Flutter from c3279caa127d to b588b3b46fb0 (53 revisions) flutter/packages#9725

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

18c190f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

b1afe9c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

b718b06

Piinks mentioned this pull request Aug 1, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

5e74afc Migrate to null aware elements - Part 2 (flutter/flutter#172306)

cef78ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to null aware elements - Part 2#172306

Migrate to null aware elements - Part 2#172306
auto-submit[bot] merged 3 commits intoflutter:masterfrom
jamilsaadeh97:null_aware_elements_2

jamilsaadeh97 commented Jul 17, 2025 •

edited

Loading

Uh oh!

victorsanni Jul 23, 2025

Uh oh!

jamilsaadeh97 Jul 23, 2025

Uh oh!

dkwingsmt Jul 23, 2025

Uh oh!

victorsanni left a comment

Uh oh!

dkwingsmt left a comment

Uh oh!

stuartmorgan-g commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jamilsaadeh97 commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

victorsanni Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jamilsaadeh97 Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jamilsaadeh97 commented Jul 17, 2025 •

edited

Loading