Add hitTestChildren to baseline-aligned stack by victorsanni · Pull Request #172485 · flutter/flutter

victorsanni · 2025-07-21T19:08:50Z

Fixes [Apple Pencil][Regression] CupertinoTextField doesn't accept input from Apple Pencil

justinmc

LGTM 👍

I wonder why the EditableText was still tappable without this change?

victorsanni · 2025-07-21T21:30:35Z

I wonder why the EditableText was still tappable without this change?

No idea, my wild guess is the field itself wrapping the EditableText is still tappable, and focuses on tap. And maybe focus is all that's needed for many EditableText features.

LongCatIsLooong · 2025-07-21T22:33:24Z

packages/flutter/lib/src/cupertino/text_field.dart

+
+  @override
+  bool hitTestChildren(BoxHitTestResult result, {required Offset position}) {
+    final RenderBox editableText = _editableTextChild;


We don't have to hit-test the placeholder? Does the API take a string or an InlineSpan?

…r#172485)

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes http://github.com/flutter/flutter/issues/171510

flutter/flutter@70cdc0c...ee0cc66 2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512) 2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552) 2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206) 2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508) 2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970) 2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485) 2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515) 2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486) 2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506) 2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504) 2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821) 2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505) 2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330) 2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262) 2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479) 2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917) 2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282) 2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471) 2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475) 2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851) 2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271) 2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927) 2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328) 2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400) 2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327) 2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329) 2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315) 2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326) 2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes http://github.com/flutter/flutter/issues/171510

…r#172485)

Fixes http://github.com/flutter/flutter/issues/171510

Add hitTestChildren to baseline-aligned stack

e98c753

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Jul 21, 2025

victorsanni added 2 commits July 21, 2025 12:09

Merge branch 'master' into text-filed

ee59208

Add test

1794cec

victorsanni marked this pull request as ready for review July 21, 2025 21:01

victorsanni requested review from LongCatIsLooong and justinmc July 21, 2025 21:01

justinmc approved these changes Jul 21, 2025

View reviewed changes

Merge branch 'master' into text-filed

b273683

LongCatIsLooong approved these changes Jul 21, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2025

auto-submit bot added this pull request to the merge queue Jul 22, 2025

Merged via the queue into flutter:master with commit 6a3ebfe Jul 22, 2025
74 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2025

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to d16e5b9971e7 (26 revisions) flutter/packages#9659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

6a3ebfe Add hitTestChildren to baseline-aligned stack (flutter/flutte…

08c25a3

…r#172485)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9660

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

6a3ebfe Add hitTestChildren to baseline-aligned stack (flutter/flutte…

ab4022e

…r#172485)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to 404fb3f14fdd (27 revisions) flutter/packages#9661

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

6a3ebfe Add hitTestChildren to baseline-aligned stack (flutter/flutte…

c03e196

…r#172485)

engine-flutter-autoroll mentioned this pull request Jul 22, 2025

Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) flutter/packages#9662

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025

6a3ebfe Add hitTestChildren to baseline-aligned stack (flutter/flutte…

ed146bf

…r#172485)

Piinks mentioned this pull request Jul 25, 2025

Flutter Notable Commits - 2025 #161460

Closed

azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025

Add hitTestChildren to baseline-aligned stack (flutter#172485)

59826d0

Fixes http://github.com/flutter/flutter/issues/171510

ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025

Add hitTestChildren to baseline-aligned stack (flutter#172485)

a1973f4

Fixes http://github.com/flutter/flutter/issues/171510

mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025

Add hitTestChildren to baseline-aligned stack (flutter#172485)

81aea48

Fixes http://github.com/flutter/flutter/issues/171510

korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025

Add hitTestChildren to baseline-aligned stack (flutter#172485)

d06eae7

Fixes http://github.com/flutter/flutter/issues/171510

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

6a3ebfe Add hitTestChildren to baseline-aligned stack (flutter/flutte…

3f804e8

…r#172485)

lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025

Add hitTestChildren to baseline-aligned stack (flutter#172485)

c8099d6

Fixes http://github.com/flutter/flutter/issues/171510

victorsanni deleted the text-filed branch January 12, 2026 23:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hitTestChildren to baseline-aligned stack#172485

Add hitTestChildren to baseline-aligned stack#172485
auto-submit[bot] merged 4 commits intoflutter:masterfrom
victorsanni:text-filed

victorsanni commented Jul 21, 2025 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

victorsanni commented Jul 21, 2025

Uh oh!

LongCatIsLooong Jul 21, 2025

Uh oh!

victorsanni Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

victorsanni commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

victorsanni commented Jul 21, 2025

Uh oh!

LongCatIsLooong Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

victorsanni commented Jul 21, 2025 •

edited

Loading