Disable smooth resizing when UI and platform threads are merged.#172835
Disable smooth resizing when UI and platform threads are merged.#172835robert-ancell wants to merge 1 commit intoflutter:masterfrom
Conversation
We can't get this without returning the thread to Flutter, thus breaking the GTK draw update.
github-actions
bot
added
engine
|
@knopp any ideas on how to do smooth resizing with merged threads? Would it be possible for the embedder to call into the engine to do the update in this case? |
|
This should be possible by pumping (only) flutter event loop messages instead of I'm having my laptop serviced this week (hopefully), once it is back I can give it a shot. |
| FlCompositorSoftware* fl_compositor_software_new(FlEngine* engine) { | ||
| FlCompositorSoftware* self = FL_COMPOSITOR_SOFTWARE( | ||
| g_object_new(fl_compositor_software_get_type(), nullptr)); | ||
| self->smooth_resize = !fl_engine_get_has_ui_on_platform_thread(engine); |
There was a problem hiding this comment.
Nit: Why not pass smooth_resize as a bool to the constructor instead of passing the entire engine?
There was a problem hiding this comment.
I did this for consistency with the OpenGL compositor mostly. I was also thinking this - are we asking the compositor to do smooth resizing or is the compositor deciding if it is capable? (This is what I ended up with). I think we'll be able to remove this in the future so it's probably not a big issue.
|
Fixed in #172893 |
|
Warning There is an error in the Gemini Code Assist config file for this repository at |
3 participants
We can't get this without returning the thread to Flutter, thus breaking the GTK draw update.