Remove shortner by rekire · Pull Request #172844 · flutter/flutter

rekire · 2025-07-28T09:07:21Z

Replacing shortner urls with the long versions. Fixes #172843

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This reverts commit d3285e2.

rekire · 2025-07-28T09:12:58Z

I included accidentally an unintended commit which I reverted.

reidbaker · 2025-07-28T14:05:38Z

dev/integration_tests/flutter_gallery/lib/gallery/about.dart

              _LinkTextSpan(
                style: linkStyle,
-                url: 'https://goo.gl/iv1p4G',
+                url: 'https://github.com/flutter/gallery',


note for other reviewers, In addition to this removing a shortened url the previous url links to a dead location.

reidbaker · 2025-07-28T14:06:42Z

dev/integration_tests/new_gallery/lib/studies/reply/waterfall_notched_rectangle.dart

    //
    // A detailed explanation and the derivation of the formulas below is
-    // available at: https://goo.gl/Ufzrqn
+    // available at: https://docs.google.com/document/d/e/2PACX-1vRVPWGtR85bawGynRSWzYTKgQtqrxCnxXCKC5xM9ab3IvtRHueku4rRIuJ4TbedzyMz2oy2pkzM71-_/pub


Note for reviewers: This is the same url as the shortened resolution.

reidbaker · 2025-07-28T14:08:45Z

engine/src/flutter/third_party/tonic/dart_args.h

@jason-simmons should this pr modify the contents of the third_party directory?

This is ok - Tonic is marked as "third party" because it originated in a different repository. But the version that Flutter uses is maintained locally within our repository.

reidbaker · 2025-07-28T14:09:28Z

packages/flutter/lib/src/material/arc.dart

    final Offset end = this.end!;

-    // An explanation with a diagram can be found at https://goo.gl/vMSdRg
+    // An explanation with a diagram can be found at https://docs.google.com/document/d/1kF7vhX_RpQCIjQYT6lZdLFs4Dl6hHxoXNkTQfzyHNlw/


Note for reviewers: This is the same url as the shortened resolution.

reidbaker · 2025-07-28T14:09:59Z

packages/flutter/lib/src/painting/notched_shapes.dart

    //
    // A detailed explanation and the derivation of the formulas below is
-    // available at: https://goo.gl/Ufzrqn
+    // available at: https://docs.google.com/document/d/e/2PACX-1vRVPWGtR85bawGynRSWzYTKgQtqrxCnxXCKC5xM9ab3IvtRHueku4rRIuJ4TbedzyMz2oy2pkzM71-_/pub


Note for reviewers: This is the same url as the shortened resolution.

reidbaker · 2025-07-28T14:10:23Z

packages/flutter_tools/lib/src/android/gradle.dart

      _logger.printStatus(
        'To avoid potential build failures, you can quickly migrate your app '
-        'by following the steps on https://goo.gl/CP92wY .',
+        'by following the steps on https://docs.flutter.dev/release/breaking-changes/androidx-migration .',


Note for reviewers: This is the same url as the shortened resolution.

reidbaker · 2025-07-28T14:10:34Z

packages/flutter_tools/test/commands.shard/permeable/build_apk_test.dart

            containsIgnoringWhitespace(
              'To avoid potential build failures, you can quickly migrate your app by '
-              'following the steps on https://goo.gl/CP92wY',
+              'following the steps on https://docs.flutter.dev/release/breaking-changes/androidx-migration',


Note for reviewers: This is the same url as the shortened resolution.

reidbaker · 2025-07-28T14:10:41Z

packages/flutter_tools/test/commands.shard/permeable/build_appbundle_test.dart

          containsIgnoringWhitespace(
            'To avoid potential build failures, you can quickly migrate your app by '
-            'following the steps on https://goo.gl/CP92wY',
+            'following the steps on https://docs.flutter.dev/release/breaking-changes/androidx-migration',


Note for reviewers: This is the same url as the shortened resolution.

Roll Flutter from 20788c0 to cfbaa18 (43 revisions) flutter/flutter@20788c0...cfbaa18 2025-07-28 [email protected] Remove shortner (flutter/flutter#172844) 2025-07-28 [email protected] Update `flutter pub get` to use `flutter.version.json` (instead of `version`) (flutter/flutter#172798) 2025-07-27 [email protected] Roll Fuchsia Linux SDK from i7RS-4iBtdndwa3Jy... to tK_PAaLeo0pUxi8hv... (flutter/flutter#172827) 2025-07-26 [email protected] Roll Fuchsia Linux SDK from 4IewCwqcEm7r4QsXd... to i7RS-4iBtdndwa3Jy... (flutter/flutter#172808) 2025-07-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: get content hash for master on local engine branches (#172792)" (flutter/flutter#172805) 2025-07-26 [email protected] fix: build size_exp artifacts in post (flutter/flutter#172802) 2025-07-26 [email protected] fix: get content hash for master on local engine branches (flutter/flutter#172792) 2025-07-25 [email protected] Update `main`/`master` repoExceptions analysis set (flutter/flutter#172796) 2025-07-25 [email protected] Remove deprecated `--[no-]-disable-dds` (flutter/flutter#172791) 2025-07-25 [email protected] `last_engine_commit.ps1`: Use `$flutterRoot` instead of `$gitTopLevel` (flutter/flutter#172786) 2025-07-25 [email protected] Check file contents, remove tests that are now invalid (`: 'none'`) (flutter/flutter#172788) 2025-07-25 [email protected] windows: allow pwsh.bat wrapper (flutter/flutter#171778) 2025-07-25 [email protected] [Impeller] Log glCheckFrameBufferStatus output when it fails in blit pass. (flutter/flutter#172592) 2025-07-25 [email protected] Remove deprecated `AssetManifest.json` file (flutter/flutter#172594) 2025-07-25 [email protected] Refactor `verifyVersion` into typed `Version` object, use it (flutter/flutter#172780) 2025-07-25 [email protected] Bump the customer tests to pick up an update to Zulip's tests, for th… (flutter/flutter#172733) 2025-07-25 [email protected] Rename `AppRunLogger`, stop writing status messages that break JSON (flutter/flutter#172591) 2025-07-25 [email protected] Add `--dart-define`, `-D` to `assemble`, deprecate `--define`, `-d`. (flutter/flutter#172510) 2025-07-25 [email protected] Fix previous text input connection interrupts enter/space (flutter/flutter#171973) 2025-07-25 [email protected] Update CHANGELOG.md for 3.32.8 (flutter/flutter#172779) 2025-07-25 [email protected] Fix an `omit-type` lint that is breaking the tree (flutter/flutter#172776) 2025-07-25 [email protected] feat(tool): Respect user-data-dir flag from web-browser-flag (flutter/flutter#169445) 2025-07-25 [email protected] [web] Fix empty first frame in multiview mode (flutter/flutter#172493) 2025-07-25 [email protected] Migrate to null aware elements - Part 3 (flutter/flutter#172307) 2025-07-25 [email protected] Update few links in docs (flutter/flutter#172166) 2025-07-25 [email protected] Roll Skia from 768ace3fd144 to 409e1c7ba09b (1 revision) (flutter/flutter#172745) 2025-07-25 [email protected] Roll Fuchsia Linux SDK from a_55b5hqpRnigzuNC... to 4IewCwqcEm7r4QsXd... (flutter/flutter#172742) 2025-07-25 [email protected] Roll Skia from 094ac350125f to 768ace3fd144 (18 revisions) (flutter/flutter#172735) 2025-07-25 [email protected] Remove 2023 deprecated `'platforms'` key from daemon output (flutter/flutter#172593) 2025-07-24 [email protected] Manual roll of Dart from 26dece893751 to 5ede85aff798 (flutter/flutter#172731) 2025-07-24 [email protected] 169108 ci debug (flutter/flutter#172589) 2025-07-24 [email protected] Improve assertion message in `_MixedBorderRadius.resolve()` (flutter/flutter#172100) 2025-07-24 [email protected] Make sure that a BottomAppBar doesn't crash in 0x0 environment (flutter/flutter#172097) 2025-07-24 [email protected] Handle#6537 bottom navigation bar (flutter/flutter#172404) 2025-07-24 [email protected] Make sure that a MaterialBanner doesn't crash in 0x0 environment (flutter/flutter#172074) 2025-07-24 [email protected] Remove support for `pluginClass: none` (on `master`; `> 3.35.0`) (flutter/flutter#172579) 2025-07-24 [email protected] Make sure that a Card doesn't crash in 0x0 environment (flutter/flutter#172373) 2025-07-24 [email protected] Make sure that an AboutDialog doesn't crash in 0x0 environment (flutter/flutter#172444) 2025-07-24 [email protected] Make sure that an ActionChip doesn't crash in 0x0 environment (flutter/flutter#172684) 2025-07-24 [email protected] Delete (unused) `dev/checks_tool` directory (flutter/flutter#172715) 2025-07-24 [email protected] [Android] Add missing ci configuration for `Linux android_java17_tool_integration_tests` (flutter/flutter#172702) 2025-07-24 [email protected] Flutter-Cherrypick-Process.md - Spell cherry-pick consistently (flutter/flutter#172697) 2025-07-24 [email protected] Bringup `linux_web_engine_tests`; failing 4+ times in a row (flutter/flutter#172714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

Replacing shortner urls with the long versions. Fixes flutter#172843 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

rekire added 2 commits July 28, 2025 10:58

Fix handling of generate lock files

d3285e2

Remove shortner urls

5f0d4ed

rekire requested a review from a team as a code owner July 28, 2025 09:07

Revert "Fix handling of generate lock files"

17c02f8

This reverts commit d3285e2.

github-actions bot removed the platform-android Android applications specifically label Jul 28, 2025

reidbaker approved these changes Jul 28, 2025

View reviewed changes

reidbaker added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 28, 2025

reidbaker requested a review from jason-simmons July 28, 2025 14:11

jason-simmons approved these changes Jul 28, 2025

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2025

auto-submit bot added this pull request to the merge queue Jul 28, 2025

Merged via the queue into flutter:master with commit cfbaa18 Jul 28, 2025
176 of 177 checks passed

engine-flutter-autoroll mentioned this pull request Jul 28, 2025

Roll Flutter from 20788c07fcb8 to cfbaa18bdecc (43 revisions) flutter/packages#9688

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2025

cfbaa18 Remove shortner (flutter/flutter#172844)

3a922d9

rekire deleted the remove_shortner branch July 28, 2025 18:04

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

cfbaa18 Remove shortner (flutter/flutter#172844)

630cfc2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove shortner#172844

Remove shortner#172844
auto-submit[bot] merged 3 commits intoflutter:masterfrom
rekire:remove_shortner

rekire commented Jul 28, 2025 •

edited

Loading

Uh oh!

rekire commented Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

jason-simmons Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

reidbaker Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rekire commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

rekire commented Jul 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rekire commented Jul 28, 2025 •

edited

Loading