Make sure that a CheckboxListTile doesn't crash in 0x0 environment by ahmedsameha1 · Pull Request #173151 · flutter/flutter

ahmedsameha1 · 2025-08-02T04:04:44Z

This is my attempt to handle #6537 for the CheckboxListTile UI control.

gemini-code-assist

Code Review

This PR adds a regression test for a crash in CheckboxListTile when rendered in a zero-sized area. The test is a good addition, but the PR seems to be missing the actual code fix for the crash it's testing against. Merging this as-is could introduce a failing test. I've suggested a more descriptive name for the test to improve clarity, in line with our style guide's emphasis on readability. The test's widget tree can be simplified by removing a redundant Center widget, following the 'write what you need and no more' principle. I've referenced the Flutter Style Guide where applicable in my comments.

packages/flutter/test/material/checkbox_list_tile_test.dart

dkwingsmt

LGTM

MitchellGoodwin

LGTM as well!

dkwingsmt

Some changes per the latest discussion

dkwingsmt · 2025-09-03T17:41:57Z

packages/flutter/test/material/checkbox_list_tile_test.dart

    expect(secondaryOffset.dy - tileOffset.dy, bottomPositionSecondary);
  });
+
+  testWidgets('CheckboxListTile renders at zero area', (WidgetTester tester) async {


Suggested change

testWidgets('CheckboxListTile renders at zero area', (WidgetTester tester) async {

testWidgets('CheckboxListTile does not crash at zero area', (WidgetTester tester) async {

dkwingsmt · 2025-09-03T17:42:39Z

packages/flutter/test/material/checkbox_list_tile_test.dart

+    final Finder xText = find.text('X');
+    expect(tester.getSize(xText).isEmpty, isTrue);


Suggested change

final Finder xText = find.text('X');

expect(tester.getSize(xText).isEmpty, isTrue);

expect(tester.getSize(find.byType(CheckboxListTile)), Size.zero);

dkwingsmt

Checklist:

The test is in the correct file
The test name goes “does not crash at zero area”
The target widget is wrapped by Center (or is fullscreen)
The target widget does not have an overlay, or the overlay is tested
The target widget is expected to have a size of exactly Size.zero

auto-submit · 2025-09-18T05:14:06Z

autosubmit label was removed for flutter/flutter/173151, because - The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-09-23T20:31:51Z

autosubmit label was removed for flutter/flutter/173151, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-10-01T18:29:15Z

autosubmit label was removed for flutter/flutter/173151, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-10-08T18:23:38Z

autosubmit label was removed for flutter/flutter/173151, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-10-16T21:50:50Z

autosubmit label was removed for flutter/flutter/173151, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-11-02T19:24:29Z

autosubmit label was removed for flutter/flutter/173151, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…nment (flutter/flutter#173151)

…lutter#173151) This is my attempt to handle flutter#6537 for the CheckboxListTile UI control. Co-authored-by: Tong Mu <[email protected]>

…nment (flutter/flutter#173151)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 2, 2025

gemini-code-assist bot reviewed Aug 2, 2025

View reviewed changes

packages/flutter/test/material/checkbox_list_tile_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/checkbox_list_tile_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/checkbox_list_tile_test.dart Show resolved Hide resolved

dkwingsmt requested review from MitchellGoodwin and dkwingsmt August 6, 2025 18:34

dkwingsmt approved these changes Aug 8, 2025

View reviewed changes

dkwingsmt self-requested a review August 27, 2025 18:23

MitchellGoodwin approved these changes Sep 3, 2025

View reviewed changes

dkwingsmt reviewed Sep 3, 2025

View reviewed changes

ahmedsameha1 force-pushed the handle#6537-CheckboxListTile branch from 8f7dac0 to 5635d14 Compare September 4, 2025 09:41

dkwingsmt approved these changes Sep 18, 2025

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2025

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

MitchellGoodwin force-pushed the handle#6537-CheckboxListTile branch from 82e7400 to 7d83d25 Compare October 1, 2025 17:27

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2025

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

dkwingsmt force-pushed the handle#6537-CheckboxListTile branch from b0400a6 to 0481794 Compare October 8, 2025 23:21

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

Make sure that a CheckboxListTile doesn't crash in 0x0 environment

5859547

dkwingsmt force-pushed the handle#6537-CheckboxListTile branch from 0481794 to 5859547 Compare October 16, 2025 21:49

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2025

Merge branch 'master' into handle#6537-CheckboxListTile

f14881e

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2025

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2025

auto-submit bot added this pull request to the merge queue Nov 2, 2025

Merged via the queue into flutter:master with commit 604bc86 Nov 2, 2025
79 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2025

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Flutter from 6f8abdd77820 to bd24c21d833b (65 revisions) flutter/packages#10350

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

57a885e

…nment (flutter/flutter#173151)

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Flutter from 6f8abdd77820 to bf4957815e10 (66 revisions) flutter/packages#10351

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

017c0cb

…nment (flutter/flutter#173151)

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Flutter from 6f8abdd77820 to 633d6591a1f0 (67 revisions) flutter/packages#10353

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

dbc4f1b

…nment (flutter/flutter#173151)

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Flutter from 6f8abdd77820 to b87e863b80ad (68 revisions) flutter/packages#10354

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

27a8b48

…nment (flutter/flutter#173151)

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Flutter from 6f8abdd77820 to 82ff983ee5a9 (69 revisions) flutter/packages#10355

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

b209b90

…nment (flutter/flutter#173151)

engine-flutter-autoroll mentioned this pull request Nov 3, 2025

Roll Flutter from 6f8abdd77820 to 8e567b884d95 (70 revisions) flutter/packages#10356

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

3fc153b

…nment (flutter/flutter#173151)

engine-flutter-autoroll mentioned this pull request Nov 4, 2025

Roll Flutter from 027f2e410241 to afbfaf93566f (69 revisions) flutter/packages#10359

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

f798ff3

…nment (flutter/flutter#173151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

371892e

…nment (flutter/flutter#173151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

2597316

…nment (flutter/flutter#173151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2025

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

b66a218

…nment (flutter/flutter#173151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

604bc86 Make sure that a CheckboxListTile doesn't crash in 0x0 enviro…

5aa4ed0

…nment (flutter/flutter#173151)

	testWidgets('CheckboxListTile renders at zero area', (WidgetTester tester) async {
	testWidgets('CheckboxListTile does not crash at zero area', (WidgetTester tester) async {

		final Finder xText = find.text('X');
		expect(tester.getSize(xText).isEmpty, isTrue);

	final Finder xText = find.text('X');
	expect(tester.getSize(xText).isEmpty, isTrue);
	expect(tester.getSize(find.byType(CheckboxListTile)), Size.zero);

Conversation

ahmedsameha1 commented Aug 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 18, 2025

Uh oh!

auto-submit bot commented Sep 23, 2025

Uh oh!

auto-submit bot commented Oct 1, 2025

Uh oh!

auto-submit bot commented Oct 8, 2025

Uh oh!

auto-submit bot commented Oct 16, 2025

Uh oh!

auto-submit bot commented Nov 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants