Fix: Active step fully colored in vertical mode by rkishan516 · Pull Request #173152 · flutter/flutter

rkishan516 · 2025-08-02T04:39:41Z

Fix: Active step fully colored in vertical mode
fixes: #169661

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

The pull request introduces a fix to ensure that the active step in a vertical stepper has a fully colored connector line. A new test case has been added to validate this behavior. One suggestion is to improve the test case by using named constants for colors.

gemini-code-assist · 2025-08-02T04:41:50Z

packages/flutter/test/material/stepper_test.dart

+  testWidgets('Vertical stepper active step has fully colored connector line', (
+    WidgetTester tester,
+  ) async {
+    await tester.pumpWidget(
+      MaterialApp(
+        home: Scaffold(
+          body: Center(
+            child: Stepper(
+              controlsBuilder: (_, _) => const SizedBox.shrink(),
+              connectorThickness: 3,
+              connectorColor: MaterialStateProperty.resolveWith<Color>(
+                (Set<MaterialState> states) => states.contains(MaterialState.selected)
+                    ? const Color(0xFF2196F3)
+                    : const Color(0xFF9E9E9E),
+              ),
+              steps: const <Step>[
+                Step(title: Text('step1'), content: Text('step1 content'), isActive: true),
+                Step(title: Text('step2'), content: Text('step2 content')),
+              ],
+            ),
+          ),
+        ),
+      ),
+    );
+
+    final Finder connectorLines = find.byWidgetPredicate(
+      (Widget widget) =>
+          widget is ColoredBox &&
+          widget.child is SizedBox &&
+          (widget.child! as SizedBox).width == 3.0,
+    );
+
+    expect(connectorLines, findsWidgets);
+
+    final List<ColoredBox> lineWidgets = tester.widgetList<ColoredBox>(connectorLines).toList();
+    final List<Color> colors = lineWidgets.map((ColoredBox box) => box.color).toList();
+    // Both top and bottom box should be colored.
+    expect(colors.where((Color c) => c == const Color(0xFF2196F3)).length, equals(2));
+  });


Consider defining the colors used in this test as named constants to improve readability and maintainability. This aligns with the style guide's emphasis on code clarity.¹

const Color activeColor = Color(0xFF2196F3); const Color inactiveColor = Color(0xFF9E9E9E); await tester.pumpWidget( MaterialApp( home: Scaffold( body: Center( child: Stepper( controlsBuilder: (_, _) => const SizedBox.shrink(), connectorThickness: 3, connectorColor: MaterialStateProperty.resolveWith<Color>( (Set<MaterialState> states) => states.contains(MaterialState.selected) ? activeColor : inactiveColor, ), steps: const <Step>[ Step(title: Text('step1'), content: Text('step1 content'), isActive: true), Step(title: Text('step2'), content: Text('step2 content')) ], ), ), ), ), ); final Finder connectorLines = find.byWidgetPredicate( (Widget widget) => widget is ColoredBox && widget.child is SizedBox && (widget.child! as SizedBox).width == 3.0, ); expect(connectorLines, findsWidgets); final List<ColoredBox> lineWidgets = tester.widgetList<ColoredBox>(connectorLines).toList(); final List<Color> colors = lineWidgets.map((ColoredBox box) => box.color).toList(); // Both top and bottom box should be colored. expect(colors.where((Color c) => c == activeColor).length, equals(2));

Style Guide References

Footnotes

Optimize for readability: Code is read more often than it is written. (link) ↩

dkwingsmt

LGTM except a nit. Thank you!

packages/flutter/test/material/stepper_test.dart

QuncCccccc

NICE fix! LGTM! Thank you for your contribution:)

…ter#173152)

flutter/flutter@a4cb00a...c65f01d 2025-08-26 [email protected] Roll Packages from fe66130 to 1ef712e (4 revisions) (flutter/flutter#174442) 2025-08-26 [email protected] Revert "Directly generate a Mach-O dynamic library using gen_snapshot (#171626) (flutter/flutter#174392) 2025-08-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 5.4.0 to 5.5.0 in the all-github-actions group (flutter/flutter#174436) 2025-08-26 [email protected] Roll Skia from 9daab16abbf9 to 21214d63fc40 (1 revision) (flutter/flutter#174431) 2025-08-26 [email protected] Roll Fuchsia Linux SDK from UiY8gj468PZUj6QTm... to L5zGzsIWIS8N36AFQ... (flutter/flutter#174430) 2025-08-26 [email protected] Roll Dart SDK from f1f90d413dd3 to 9054cd8af73c (2 revisions) (flutter/flutter#174428) 2025-08-26 [email protected] Roll Skia from afb5c22d9ba0 to 9daab16abbf9 (2 revisions) (flutter/flutter#174429) 2025-08-26 [email protected] Roll Skia from 2227187dbdcf to afb5c22d9ba0 (1 revision) (flutter/flutter#174425) 2025-08-26 [email protected] [iOS][Secure Paste] Custom edit menu actions (flutter/flutter#171825) 2025-08-26 [email protected] Make SystemUiOverlayStyle to be diagnosticable (flutter/flutter#174018) 2025-08-26 [email protected] Fix: Active step fully colored in vertical mode (flutter/flutter#173152) 2025-08-26 [email protected] Migrate to use `WidgetStateProperty` (flutter/flutter#174323) 2025-08-26 [email protected] Roll Skia from ed42a94ee066 to 2227187dbdcf (3 revisions) (flutter/flutter#174417) 2025-08-26 [email protected] Roll Dart SDK from a0e39d9b4a58 to f1f90d413dd3 (1 revision) (flutter/flutter#174409) 2025-08-26 [email protected] [Impeller] Flush the data written to the device buffer by RoundSuperellipseGeometry (flutter/flutter#174316) 2025-08-26 [email protected] Remove obsolete vulkan_window source files (flutter/flutter#174087) 2025-08-25 [email protected] [web] Migrate non-CanvasKit-specific tests to ui/ (flutter/flutter#174396) 2025-08-25 [email protected] Create Hot Restart over websocket test (flutter/flutter#173852) 2025-08-25 [email protected] Roll Dart SDK from e283a9e88242 to a0e39d9b4a58 (1 revision) (flutter/flutter#174383) 2025-08-25 [email protected] Update `master` CHANGELOG for 3.35.2 (flutter/flutter#174399) 2025-08-25 [email protected] Roll Skia from da724d312e65 to ed42a94ee066 (4 revisions) (flutter/flutter#174394) 2025-08-25 [email protected] Update dwds to 25.0.3 (flutter/flutter#174379) 2025-08-25 [email protected] Fix logic statements in year2023 documentation (flutter/flutter#174120) 2025-08-25 [email protected] Release thread-local resources when submitting a Flutter GPU command buffer (flutter/flutter#173663) 2025-08-25 [email protected] [web] Refactor LayerScene out of CanvasKit (flutter/flutter#174375) 2025-08-25 [email protected] Stream logs from `devicectl` and `lldb` (flutter/flutter#173724) 2025-08-25 [email protected] NavigatorPopScope examples no longer use deprecated onPop. (flutter/flutter#174291) 2025-08-25 [email protected] fix typo in test documentation function name (flutter/flutter#174297) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fix: Active step fully colored in vertical mode fixes: flutter#169661 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. Co-authored-by: Qun Cheng <[email protected]>

…ter#173152)

Fix: Active step fully colored in vertical mode fixes: flutter#169661 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. Co-authored-by: Qun Cheng <[email protected]>

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 2, 2025

rkishan516 force-pushed the stepper-color branch from dc7d08c to 68788e5 Compare August 2, 2025 04:40

gemini-code-assist bot reviewed Aug 2, 2025

View reviewed changes

rkishan516 force-pushed the stepper-color branch from 68788e5 to 8f8f317 Compare August 2, 2025 04:44

dkwingsmt self-requested a review August 6, 2025 18:35

dkwingsmt approved these changes Aug 20, 2025

View reviewed changes

packages/flutter/test/material/stepper_test.dart Show resolved Hide resolved

dkwingsmt requested a review from QuncCccccc August 20, 2025 18:28

Fix: Active step fully colored in vertical mode

935fac6

rkishan516 force-pushed the stepper-color branch from 8f8f317 to 935fac6 Compare August 21, 2025 02:07

QuncCccccc approved these changes Aug 26, 2025

View reviewed changes

Merge branch 'master' into stepper-color

b0e1ba4

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2025

auto-submit bot added this pull request to the merge queue Aug 26, 2025

Merged via the queue into flutter:master with commit 42ba7a1 Aug 26, 2025
77 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2025

engine-flutter-autoroll mentioned this pull request Aug 26, 2025

Roll Flutter from a4cb00ae1509 to 7905cb782e02 (26 revisions) flutter/packages#9891

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2025

42ba7a1 Fix: Active step fully colored in vertical mode (flutter/flut…

4ad10e5

…ter#173152)

engine-flutter-autoroll mentioned this pull request Aug 26, 2025

Roll Flutter from a4cb00ae1509 to f9382a463a42 (27 revisions) flutter/packages#9893

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2025

42ba7a1 Fix: Active step fully colored in vertical mode (flutter/flut…

d84597c

…ter#173152)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2025

42ba7a1 Fix: Active step fully colored in vertical mode (flutter/flut…

80f9229

…ter#173152)

engine-flutter-autoroll mentioned this pull request Aug 26, 2025

Roll Flutter from a4cb00ae1509 to c65f01dc373c (28 revisions) flutter/packages#9894

Merged

Piinks mentioned this pull request Aug 29, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

42ba7a1 Fix: Active step fully colored in vertical mode (flutter/flut…

354d782

…ter#173152)

rkishan516 deleted the stepper-color branch February 20, 2026 03:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Active step fully colored in vertical mode#173152

Fix: Active step fully colored in vertical mode#173152
auto-submit[bot] merged 2 commits intoflutter:masterfrom
rkishan516:stepper-color

rkishan516 commented Aug 2, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 2, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rkishan516 commented Aug 2, 2025

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 2, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants