Prepare for iOS debugging with lldb and devicectl by vashworth · Pull Request #173417 · flutter/flutter

vashworth · 2025-08-07T16:00:11Z

This PR introduces new classes and methods needed to transition to using devicectl (for installing and launching) and lldb (for debugging) for deploying apps to iOS 17+ physical devices.

The new classes/methods are not used yet to reduce risk for cherry-picking. A follow up PR will adopt them.

Part 1 of #173416.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request introduces new classes and methods to support debugging on iOS 17+ physical devices using devicectl and lldb. The changes are well-structured and include comprehensive tests for the new functionality. My review focuses on improving robustness and documentation. I've suggested a change to make JSON parsing safer in IOSCoreDeviceControl.terminateProcess to prevent potential unhandled exceptions. I've also pointed out a missing doc comment for a new public method to align with the repository's style guide.

packages/flutter_tools/lib/src/ios/core_devices.dart

jmagman

Minor nits, LGTM!

jmagman · 2025-08-07T18:11:30Z

packages/flutter_tools/lib/src/ios/core_devices.dart

+    } else {
+      // This should not happen. Currently, only PrebuiltIOSApp and
+      // BuildableIOSApp extend from IOSApp.
+      _logger.printError('IOSApp type ${package.runtimeType} is not recognized.');


Something to think about when working in flutter_tools:
printTrace is more appropriate for logs that are useful for our debugging when an issue is filed. Developers see printError logs though, is there anything actionable they can do at this point? This log message isn't useful to them.

jmagman · 2025-08-07T18:19:00Z

packages/flutter_tools/lib/src/ios/lldb.dart

+    Timer? timer;
+    try {
+      timer = Timer(const Duration(minutes: 1), () {


Use startSpinner and slowWarningCallback

startSpinner doesn't work if there is already a spinner going:

flutter/packages/flutter_tools/lib/src/ios/devices.dart

Line 518 in 3be0441

Status startAppStatus = _logger.startProgress('Installing and launching...');

auto-submit · 2025-08-07T19:07:08Z

autosubmit label was removed for flutter/flutter/173417, because - The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

This PR introduces new classes and methods needed to transition to using `devicectl` (for installing and launching) and `lldb` (for debugging) for deploying apps to iOS 17+ physical devices. The new classes/methods are not used yet to reduce risk for cherry-picking. A follow up PR will adopt them. Part 1 of flutter#173416. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…utter#173417)

flutter/flutter@92a6bfb...3821790 2025-08-08 [email protected] Use LLDB as the default debugging method for iOS 17+ and Xcode 26+ (flutter/flutter#173443) 2025-08-08 [email protected] Roll Fuchsia Linux SDK from i4vsuEGyP8Xeb5tiy... to HclTm0V8hgSpfqmtG... (flutter/flutter#173462) 2025-08-08 [email protected] Support launching a HTTPS URL (flutter/flutter#164720) 2025-08-08 [email protected] Roll Dart SDK from c48772a79e1f to 4b7b565eb468 (1 revision) (flutter/flutter#173454) 2025-08-08 [email protected] Roll Dart SDK from ba58b96a80d7 to c48772a79e1f (3 revisions) (flutter/flutter#173451) 2025-08-07 [email protected] Web dev proxy (flutter/flutter#172175) 2025-08-07 [email protected] Roll ICU from b929596baebf to 1b2e3e8a421e (7 revisions) (flutter/flutter#173436) 2025-08-07 [email protected] [A11y] TextField prefix icon and suffix icon create a sibling node' (flutter/flutter#173312) 2025-08-07 [email protected] [Android templates] Remove jetifier usage (flutter/flutter#173431) 2025-08-07 [email protected] Remove a couple of asserts from display_list_unittest (flutter/flutter#173381) 2025-08-07 [email protected] Fix ScaffoldGeometry null scale with noAnimation FAB (flutter/flutter#172914) 2025-08-07 [email protected] Prepare for iOS debugging with lldb and devicectl (flutter/flutter#173417) 2025-08-07 [email protected] Fix `ReorderableList` proxy animation for partial drag-back (flutter/flutter#172380) 2025-08-07 [email protected] [ios26]Do not report error for Info.plist key not found (flutter/flutter#172913) 2025-08-07 [email protected] Manual roll to 3.10.0-75.1.beta (flutter/flutter#173423) 2025-08-07 [email protected] [web] add --static-assets-url argument to build web (flutter/flutter#171638) 2025-08-07 [email protected] Adds deprecation for impeller opt out on android (flutter/flutter#173375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR introduces new classes and methods needed to transition to using `devicectl` (for installing and launching) and `lldb` (for debugging) for deploying apps to iOS 17+ physical devices. The new classes/methods are not used yet to reduce risk for cherry-picking. A follow up PR will adopt them. Part 1 of flutter#173416. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…utter#173417)

This PR introduces new classes and methods needed to transition to using `devicectl` (for installing and launching) and `lldb` (for debugging) for deploying apps to iOS 17+ physical devices. The new classes/methods are not used yet to reduce risk for cherry-picking. A follow up PR will adopt them. Part 1 of flutter#173416. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

vashworth added 2 commits August 6, 2025 20:13

Prepare for iOS debugging with lldb and devicectl

ce1c77a

++

96c0694

vashworth requested a review from a team as a code owner August 7, 2025 16:00

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Aug 7, 2025

++

a7697d2

gemini-code-assist bot reviewed Aug 7, 2025

View reviewed changes

packages/flutter_tools/lib/src/ios/core_devices.dart Show resolved Hide resolved

packages/flutter_tools/lib/src/ios/core_devices.dart Show resolved Hide resolved

vashworth added 2 commits August 7, 2025 11:26

++

cf173a7

++

34eb6b9

vashworth requested review from bkonyi and jmagman August 7, 2025 16:41

fix analyze error, add missing test

e3d837a

jmagman approved these changes Aug 7, 2025

View reviewed changes

print non-user messages to trace

f6a3e23

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

fix tests

1841aa8

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

auto-submit bot added this pull request to the merge queue Aug 7, 2025

Merged via the queue into flutter:master with commit b57c974 Aug 7, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

jmagman added the cp: beta cherry pick this pull request to beta release candidate branch label Aug 7, 2025

jmagman mentioned this pull request Aug 7, 2025

[CP-beta]Prepare for iOS debugging with lldb and devicectl #173439

Merged

5 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2025

b57c974 Prepare for iOS debugging with lldb and devicectl (flutter/fl…

d4cc643

…utter#173417)

engine-flutter-autoroll mentioned this pull request Aug 8, 2025

Roll Flutter from 92a6bfbfd6ef to ec81e2ea34c8 (14 revisions) flutter/packages#9774

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2025

b57c974 Prepare for iOS debugging with lldb and devicectl (flutter/fl…

cea08f3

…utter#173417)

engine-flutter-autoroll mentioned this pull request Aug 8, 2025

Roll Flutter from 92a6bfbfd6ef to aef15c12f410 (16 revisions) flutter/packages#9777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2025

b57c974 Prepare for iOS debugging with lldb and devicectl (flutter/fl…

9710048

…utter#173417)

engine-flutter-autoroll mentioned this pull request Aug 8, 2025

Roll Flutter from 92a6bfbfd6ef to 38217906e95c (17 revisions) flutter/packages#9778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

b57c974 Prepare for iOS debugging with lldb and devicectl (flutter/fl…

1af8a21

…utter#173417)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for iOS debugging with lldb and devicectl#173417

Prepare for iOS debugging with lldb and devicectl#173417
auto-submit[bot] merged 8 commits intoflutter:masterfrom
vashworth:lldb_devicectl_deploy_v1

vashworth commented Aug 7, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

jmagman left a comment

Uh oh!

jmagman Aug 7, 2025

Uh oh!

jmagman Aug 7, 2025

Uh oh!

vashworth Aug 7, 2025

Uh oh!

auto-submit bot commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vashworth commented Aug 7, 2025

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants