Move Linux coverage back to bringup#174171
Merged
matanlurey merged 1 commit intoflutter:masterfrom Aug 21, 2025
Merged
Conversation
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
loic-sharma
approved these changes
Aug 20, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the Linux coverage test to bringup mode to handle its flakiness. My feedback is to add a TODO with a tracking issue for this flaky test, as per the repository's guidelines for managing test flakiness. This will help ensure the issue is not forgotten.
4 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 21, 2025
flutter/flutter@960d107...d2ac021 2025-08-21 [email protected] [web] Delete unused utils (flutter/flutter#174160) 2025-08-21 [email protected] Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626) 2025-08-21 [email protected] Update the text input team's issue triage query (flutter/flutter#173999) 2025-08-21 [email protected] Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170) 2025-08-21 [email protected] whitespace (flutter/flutter#174210) 2025-08-21 [email protected] Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000) 2025-08-20 [email protected] Move `Linux coverage` back to bringup (flutter/flutter#174171) 2025-08-20 [email protected] Engine build setup for Android RISCV64. (flutter/flutter#173672) 2025-08-20 [email protected] [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001) 2025-08-20 [email protected] Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732) 2025-08-20 [email protected] Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109) 2025-08-20 [email protected] Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
Because this only runs every 6 commits, it being flaky takes a long time to recover. It's not a priority to keep green and un-flaky at the moment.
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
Because this only runs every 6 commits, it being flaky takes a long time to recover. It's not a priority to keep green and un-flaky at the moment.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
Because this only runs every 6 commits, it being flaky takes a long time to recover. It's not a priority to keep green and un-flaky at the moment.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
Because this only runs every 6 commits, it being flaky takes a long time to recover. It's not a priority to keep green and un-flaky at the moment.
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
Because this only runs every 6 commits, it being flaky takes a long time to recover. It's not a priority to keep green and un-flaky at the moment.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Because this only runs every 6 commits, it being flaky takes a long time to recover. It's not a priority to keep green and un-flaky at the moment.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Marked as bringup as of #174171. With the new dashboard level flake suppression, it will no longer take a long time to mark things as flaky. Also, this seems to be running on every commit now?
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
Marked as bringup as of flutter#174171. With the new dashboard level flake suppression, it will no longer take a long time to mark things as flaky. Also, this seems to be running on every commit now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because this only runs every 6 commits, it being flaky takes a long time to recover.
It's not a priority to keep green and un-flaky at the moment.