Build engine TUs with C++20.#174471
Conversation
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the engine build configuration to use C++20 instead of C++17. It also includes several formatting changes and adds compiler flags to handle the transition, such as disabling C++20 modules and suppressing warnings related to deprecated this captures. My review focuses on improving code conciseness and ensuring adherence to the GN style guide for formatting.
chinmaygarde
force-pushed
the
attemptc20
branch
from
2dd52bb to
24883de
Compare
github-actions
bot
added
a: desktop
chinmaygarde
changed the title
|
|
||
| if (is_clang) { | ||
| extra_warning_flags_cc = [ | ||
| # TODO(XXXX): Third-party dependency (Angle) needs to patched to work |
There was a problem hiding this comment.
Will replace with bug once filed.
There was a problem hiding this comment.
Flutter is currently using a version of ANGLE that is 2 years old.
A few months ago I started working on a roll of ANGLE but never landed it. I'd be interested in reviving that work and rolling forward to a version that does not have this issue.
|
|
||
| if (is_clang) { | ||
| extra_warning_flags_cc = [ | ||
| # TODO(XXXX): Third-party dependency (Angle) needs to patched to work |
There was a problem hiding this comment.
Flutter is currently using a version of ANGLE that is 2 years old.
A few months ago I started working on a roll of ANGLE but never landed it. I'd be interested in reviving that work and rolling forward to a version that does not have this issue.
github-actions
bot
added
the
platform-linux
github-actions
bot
added
the
platform-windows
|
@chinmaygarde @gaaclarke I think this is good to go now. Reviews on the additional patches? There were a couple of windows specific fixups necessary around the use of |
github-actions
bot
added
platform-ios
|
Double checked with @jason-simmons for the update and he says LGTM. Landing. |
chinmaygarde
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
The changes: * Creating a bit-mask with different enum values is now a warning. Fixed offending instances. * `char8_t` is a different type. Fixed those instances. * Disabling modules in Objective-C requires bypassing the driver. * Aggregate initialization fails when there are other constructors for structs. Added explicit constructors. * `gn format` doesn't seem to be run on erstwhile buildroot GN files. Fixes the formatting. But can back this out since it is technically unrelated to C++20.
The changes: * Creating a bit-mask with different enum values is now a warning. Fixed offending instances. * `char8_t` is a different type. Fixed those instances. * Disabling modules in Objective-C requires bypassing the driver. * Aggregate initialization fails when there are other constructors for structs. Added explicit constructors. * `gn format` doesn't seem to be run on erstwhile buildroot GN files. Fixes the formatting. But can back this out since it is technically unrelated to C++20.
The changes: * Creating a bit-mask with different enum values is now a warning. Fixed offending instances. * `char8_t` is a different type. Fixed those instances. * Disabling modules in Objective-C requires bypassing the driver. * Aggregate initialization fails when there are other constructors for structs. Added explicit constructors. * `gn format` doesn't seem to be run on erstwhile buildroot GN files. Fixes the formatting. But can back this out since it is technically unrelated to C++20.
3 participants
The changes:
char8_tis a different type. Fixed those instances.gn formatdoesn't seem to be run on erstwhile buildroot GN files. Fixes the formatting. But can back this out since it is technically unrelated to C++20.