[3.36] CP #174459 (Fix bug in test_golden_comparator)#174603
Conversation
Closes flutter#174267. The actual fix is 1-line, but of course there is no test suite to verify that, so that took the bulk of the time.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the test_golden_comparator where a failed comparison could cause a crash. The fix involves changing the exception handling to catch Object? instead of just Exception, which ensures that FlutterError (which does not extend Exception) is also caught. Additionally, a new integration test has been added to serve as a regression test, verifying that failed golden file comparisons are handled correctly without crashing.
matanlurey
added
the
autosubmit
auto-submit
bot
merged commit 6c79484
into
flutter:flutter-3.36-candidate.0
2 participants
Manual CP for #174459.