[CP-stable][Impeller] Flush the data written to the device buffer by RoundSuperellipseGeometry (#174316)#174663
Conversation
…llipseGeometry (flutter#174316) Fixes flutter#174100
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a rendering artifact issue with superellipses in Impeller by ensuring the device buffer is flushed after vertex data is written. The fix in RoundSuperellipseGeometry is accompanied by a new unit test that verifies this flushing behavior. The changes are logical and the fix is well-contained. I have one suggestion to improve the test implementation's adherence to the project's C++ style guide.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/174663, because - The status or check suite Linux linux_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
matanlurey
added
the
autosubmit
auto-submit
bot
merged commit e9f7d4b
into
flutter:flutter-3.35-candidate.0
…ffer by RoundSuperellipseGeometry (#174316) (flutter/flutter#174663)
…ffer by RoundSuperellipseGeometry (#174316) (flutter/flutter#174663)
…ffer by RoundSuperellipseGeometry (#174316) (flutter/flutter#174663)
2 participants
Issue Link:
#174100
Changelog Description:
Fixes errors seen when rendering superellipses on Impeller.
Impact Description:
This affects apps like the one in #174100 that render Cupertino widgets which use superellipses. The app may show flickering or other artifacts when rendered with Impeller (particularly on the GLES back end).
Workaround:
Disable Impeller
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
Run the app in #174100 on an Android device and select the Impeller GLES back end. Confirm that it can scroll without flickering.