Fixing list tile size in the presence of a large subtitle#17580
Merged
gspencergoog merged 1 commit intoflutter:masterfrom May 14, 2018
Merged
Fixing list tile size in the presence of a large subtitle#17580gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog merged 1 commit intoflutter:masterfrom
Conversation
HansMuller
approved these changes
May 14, 2018
Contributor
There was a problem hiding this comment.
We should also verify that the top of the title is > 0. Once the MD team has signed of on a min vertical padding value (or some algorithm) we could refine testVerticalGeometry() further
Contributor
Author
There was a problem hiding this comment.
Done. Also verified that the top centers the title in the widget.
Contributor
There was a problem hiding this comment.
I think this should be lessThan for now (because min vertical padding is > 0)
gspencergoog
force-pushed
the
list_tile_size
branch
from
5b6eea5 to
3251c7d
Compare
HansMuller
added a commit
to HansMuller/flutter
that referenced
this pull request
May 16, 2018
HansMuller
pushed a commit
that referenced
this pull request
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take into account the subtitle height when adjusting the height of the widget. Added a test.