Change kRadialReactionRadius from 24 to 20#17620
Merged
HansMuller merged 1 commit intoflutter:masterfrom May 15, 2018
Merged
Conversation
gspencergoog
approved these changes
May 15, 2018
Contributor
|
|
Contributor
|
When making breaking changes of this nature please apply the breaking change policy: (And when reviewing PRs of this nature, please check that the process is being applied. :-) ) Going forward, we probably need to stop making this kind of breaking change (e.g. by padding the checkboxes so they maintain their size even as we change the size of the splash). We have too many customers now to be able to break people's layouts. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to reducing the radial ink splash size for
Radio,CheckboxandSwitch, this change effectively reduces the sizes ofCheckboxandRadioto 40x40 per the most recent Material spec. It will also unblock two recently revertedListTilePRs:#17496
#17580
This change was originally part of #14483. It will affect some layouts.
The current appearance of the radio buttons and the radial splash for checkbox and switch:
The new appearance: